public inbox for [email protected]  
help / color / mirror / Atom feed
From: Euler Taveira de Oliveira <[email protected]>
To: Greg Smith <[email protected]>
Cc: [email protected]
Subject: Re: somewhat wrong archive_command example
Date: Wed, 21 Sep 2011 21:59:43 -0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On 21-09-2011 20:02, Greg Smith wrote:
> Attached version fixes the late night brain fade errors. I think the right
> thing to do next is to package this up into a doc update that corrects the
> errors in that section too; just clean the whole thing up while I'm poking at
> it. I'll submit that over to the hackers list so that everyone can take a shot
> at correcting my shell code.
>
Just a few comments:

(i) full path for ARCHIVE (say /path/to/archive) and backup_in_progress. 
Absolute paths are easier to check than relative ones;
(ii) is echo with unquoted string portable? I don't know but it confuses 
readability.


-- 
    Euler Taveira de Oliveira - Timbira       http://www.timbira.com.br/
    PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento



view thread (24+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: somewhat wrong archive_command example
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox