Subject: Re: Docbook 5.x
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, obartunov@gmail.com,
 Alvaro Herrera <alvherre@2ndquadrant.com>,
 Alexander Lakhin <a.lakhin@postgrespro.ru>
References: <57179283.6080704@purtz.de>
 <20160503193441.GA61759@alvherre.pgsql>
 <CAF4Au4zUVOuWjWc+B72yvvpVo=TJad6=x9chig7Ls9DNa7Kgrg@mail.gmail.com>
 <db902495-52f2-ee33-b229-5fe094cf4937@2ndquadrant.com>
 <572AD007.60900@gmail.com>
 <bcc78f65-ef7f-22ea-0d7a-a83b7b7538b6@2ndquadrant.com>
 <5752E599.2090505@gmail.com>
 <de53dbdf-a0f1-5673-bbee-ca4f3d75f278@2ndquadrant.com>
 <576d0623-a89c-b3de-e321-dc48a579ff1a@2ndquadrant.com>
 <eb1abd5e-4210-b5c5-522c-d15e4e62a09b@gmail.com>
 <b4f74ac9-09ba-d198-092b-e2bfbf1c0194@2ndquadrant.com>
Cc: =?UTF-8?Q?J=c3=bcrgen_Purtz?= <juergen@purtz.de>,
 pgsql-docs@postgresql.org
From: Alexander Law <exclusion@gmail.com>
Message-ID: <4adecfc6-2f2e-2ff2-bfa3-58b7d397227b@gmail.com>
Date: Tue, 23 Aug 2016 17:23:15 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <b4f74ac9-09ba-d198-092b-e2bfbf1c0194@2ndquadrant.com>
Content-Type: multipart/mixed;
 boundary="------------2A62B59B5DB3A23BDF3113E2"
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

This is a multi-part message in MIME format.
--------------2A62B59B5DB3A23BDF3113E2
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

Hello,
>> The next items in our plan were:
> An immediate problem is that the patched stuff no longer works with
> older stylesheets (1.76.1?).  I'm glad to leave older stuff behind for a
> 400% speedup, but we need to analyze the exact effect and possibly
> document it or work around it.
Please consider committing attached patch. Commented-out call-template 
does nothing so we can just customize our customized templates further 
to support 1.76.
I've just performed the build with Ubuntu 13.04/docbook 1.76.1 - it works.
(In case the call-template generated something it would appear in 
bookindex.html only.)
>
>> - Wait a while to make sure everyone is happy with the performance. Keep
>> tweaking if necessary.
>> - Port all DSSSL customizations to XSLT.  Manually evaluate output for
>> quality.
>>
>> Should we now compare DSSSL outputs with XSLT?
>> I had some success with it before. See my letter:
>> https://www.postgresql.org/message-id/57712848.7060306%40gmail.com
>> Those xslt's (see xhtml-like-dsssl.patch) can help us to see all the
>> differences and to decide which customizations to keep.
> It looks like the idea there is to whack the XSLT stylesheets until the
> output looks exactly like the DSSSL output?  I'm not sure that's
> terribly useful.  It would probably be a lot of work, which we'll just
> end up removing eventually.  I'd rather just fix any formatting issues
> we find and move forward.
That work is done already and it's results are countable and observable 
differences. (See comments in the xslt.)
For example, with DSSSL we don't get a chapter TOC when the chapter 
contains only one sect1 (with XSLT we get the TOC with the one item).
We also had subtoc for sect1/refentry and sect1/simplesect, but with 
XSLT it's absent.
So if all such differences are not important, let's move forward.

Best regards,
Alexander


--------------2A62B59B5DB3A23BDF3113E2
Content-Type: text/x-patch;
 name="stylesheet-speedup-docbook-1.76.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="stylesheet-speedup-docbook-1.76.patch"

diff --git a/doc/src/sgml/stylesheet-speedup-xhtml.xsl b/doc/src/sgml/stylesheet-speedup-xhtml.xsl
index 8428dc5..b6df684 100644
--- a/doc/src/sgml/stylesheet-speedup-xhtml.xsl
+++ b/doc/src/sgml/stylesheet-speedup-xhtml.xsl
@@ -122,7 +122,8 @@
 
       <a>
         <xsl:apply-templates select="." mode="class.attribute"/>
-        <xsl:call-template name="id.attribute"/>
+<!--    Optimization for pgsql-docs: this call adds nothing but fails with docbook 1.76 -->
+<!--    <xsl:call-template name="id.attribute"/> -->
         <xsl:attribute name="href">
           <xsl:call-template name="href.target">
             <xsl:with-param name="object" select="$target[1]"/>
@@ -146,7 +147,8 @@
 
       <a>
         <xsl:apply-templates select="." mode="class.attribute"/>
-        <xsl:call-template name="id.attribute"/>
+<!--    Optimization for pgsql-docs: this call adds nothing but fails with docbook 1.76 -->
+<!--    <xsl:call-template name="id.attribute"/> -->
         <xsl:attribute name="href">
           <xsl:call-template name="href.target">
             <xsl:with-param name="object" select="$target[1]"/>

--------------2A62B59B5DB3A23BDF3113E2
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

--------------2A62B59B5DB3A23BDF3113E2--