DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=message-id:date:from:to:subject:mime-version:content-type
	:content-disposition:user-agent;
	b=pRQjxs7hbC9RR1z9BiUU2ifaH07p4Chy6WNwsYlNqu8i9WksK+MODcBEGRGycYy+nc
	CtgU2tZ6VbGJbhpuzX0Kt2PlOVQJusovTP9KT3Hx3coQ36fjXji05Mq6hoQM2zAcf9Kr
	3vCjpSGS5AJ1f+5+6cWGVtI5RsZoU9lBF0Xvg=
Message-ID: <4c052c68.20a5720a.3577.33e6@mx.google.com>
Date: Tue, 1 Jun 2010 09:51:02 -0600
From: Joshua Tolley <eggyknap@gmail.com>
To: pgsql-docs@postgresql.org
Subject: commit_delay and commit_siblings -- restart or reload?
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="c7hkjup166d4FzgN"
Content-Disposition: inline
User-Agent: Mutt/1.5.18 (2008-05-17)


--c7hkjup166d4FzgN
Content-Type: multipart/mixed; boundary="8TaQrIeukR7mmbKf"
Content-Disposition: inline


--8TaQrIeukR7mmbKf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

The documentation for commit_delay and commit_siblings doesn't mention whether
a reload or restart is required to set them. I recommend something like the
trivial attached docs patch to make it clear(er) that a reload is required.

--
Joshua Tolley / eggyknap
End Point Corporation
http://www.endpoint.com

--8TaQrIeukR7mmbKf
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="commit_delay.docs.patch"

diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 48ad9f6..c513eba 100644
*** a/doc/src/sgml/config.sgml
--- b/doc/src/sgml/config.sgml
*************** SET ENABLE_SEQSCAN TO OFF;
*** 1643,1649 ****
          commit. Therefore, the delay is only performed if at least
          <varname>commit_siblings</varname> other transactions are
          active at the instant that a server process has written its
!         commit record. The default is zero (no delay).
         </para>
        </listitem>
       </varlistentry>
--- 1643,1651 ----
          commit. Therefore, the delay is only performed if at least
          <varname>commit_siblings</varname> other transactions are
          active at the instant that a server process has written its
!         commit record. The default is zero (no delay). This parameter can only
!         be set in the <filename>postgresql.conf</> file or on the server
!         command line.
         </para>
        </listitem>
       </varlistentry>
*************** SET ENABLE_SEQSCAN TO OFF;
*** 1659,1665 ****
          before performing the <varname>commit_delay</> delay. A larger
          value makes it more probable that at least one other
          transaction will become ready to commit during the delay
!         interval. The default is five transactions.
         </para>
        </listitem>
       </varlistentry>
--- 1661,1669 ----
          before performing the <varname>commit_delay</> delay. A larger
          value makes it more probable that at least one other
          transaction will become ready to commit during the delay
!         interval. The default is five transactions. This parameter can only be
!         set in the <filename>postgresql.conf</> file or on the server command
!         line.
         </para>
        </listitem>
       </varlistentry>

--8TaQrIeukR7mmbKf--

--c7hkjup166d4FzgN
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkwFLGYACgkQRiRfCGf1UMMVmgCfY8SGJBPd8PIbT27uHYJ5s2Pc
yKIAn1JRuRb2yJxqm9GFn/cWinF/h+N5
=buFD
-----END PGP SIGNATURE-----

--c7hkjup166d4FzgN--