pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedMinipatch concerning tags
3+ messages / 2 participants
[nested] [flat]
* Minipatch concerning tags
@ 2023-10-20 08:22 Maxim Yablokov <m.yablokov@postgrespro.ru>
2023-10-21 07:11 ` Re: Minipatch concerning tags Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 3+ messages in thread
From: Maxim Yablokov @ 2023-10-20 08:22 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org
Hello!
PostgresPro documentation team (Ekaterina Kiryanova, Elena Indrupskaya,
Oleg Sibiryakov and me) have prepared a patch with some improvements
concerning missed/inapt tags. Please have a look.
--
Best regards,
Maxim Yablokov
Technical writer-translator
Postgres Professional <https://postgrespro.com/;
Attachments:
[text/x-patch] tags.patch (7.1K, ../../4c2a430b-32e2-44e2-aeca-03b7db6824e4@postgrespro.ru/3-tags.patch)
download | inline diff:
diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
index d3458840fbe..cdc53b0b9f4 100644
--- a/doc/src/sgml/catalogs.sgml
+++ b/doc/src/sgml/catalogs.sgml
@@ -7943,7 +7943,7 @@ SCRAM-SHA-256$<replaceable><iteration count></replaceable>:<replaceable>&l
disk and apply at once after the transaction is committed on the
publisher and received by the subscriber,
<literal>p</literal> = apply changes directly using a parallel apply
- worker if available (same as 't' if no worker is available)
+ worker if available (same as <literal>t</literal> if no worker is available)
</para></entry>
</row>
diff --git a/doc/src/sgml/custom-rmgr.sgml b/doc/src/sgml/custom-rmgr.sgml
index baf86b1c07d..d5f5cce0d6b 100644
--- a/doc/src/sgml/custom-rmgr.sgml
+++ b/doc/src/sgml/custom-rmgr.sgml
@@ -96,8 +96,8 @@ extern void RegisterCustomRmgr(RmgrId rmid, const RmgrData *rmgr);
</para>
<note>
<para>
- The extension must remain in shared_preload_libraries as long as any
- custom WAL records may exist in the system. Otherwise
+ The extension must remain in <varname>shared_preload_libraries</varname>
+ as long as any custom WAL records may exist in the system. Otherwise
<productname>PostgreSQL</productname> will not be able to apply or decode
the custom WAL records, which may prevent the server from starting.
</para>
diff --git a/doc/src/sgml/ecpg.sgml b/doc/src/sgml/ecpg.sgml
index 54de81158b5..cc8f6d4739d 100644
--- a/doc/src/sgml/ecpg.sgml
+++ b/doc/src/sgml/ecpg.sgml
@@ -1506,7 +1506,7 @@ EXEC SQL TYPE serial_t IS long;
</para>
<para>
- Any word you declare as a typedef cannot be used as an SQL keyword
+ Any word you declare as a <literal>typedef</literal> cannot be used as an SQL keyword
in <literal>EXEC SQL</literal> commands later in the same program.
For example, this won't work:
<programlisting>
diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml
index f4b1f811899..8e0b2705d34 100644
--- a/doc/src/sgml/installation.sgml
+++ b/doc/src/sgml/installation.sgml
@@ -2743,8 +2743,8 @@ ninja install
<para>
The default backend Meson uses is ninja and that should suffice for
most use cases. However, if you'd like to fully integrate with Visual
- Studio, you can set the <option>BACKEND</option> to
- <command>vs</command>.
+ Studio, you can set the <replaceable>BACKEND</replaceable> to
+ <literal>vs</literal>.
</para>
</listitem>
</varlistentry>
diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml
index cbd3aa804f7..69f19e6dcc7 100644
--- a/doc/src/sgml/logicaldecoding.sgml
+++ b/doc/src/sgml/logicaldecoding.sgml
@@ -330,9 +330,9 @@ postgres=# select * from pg_logical_slot_get_changes('regression_slot', NULL, NU
on standby also get invalidated if <varname>wal_level</varname> on the
primary is reduced to less than <literal>logical</literal>.
This is done as soon as the standby detects such a change in the WAL stream.
- It means that, for walsenders which are lagging (if any), some WAL records up
- to the <varname>wal_level</varname> parameter change on the primary won't be
- decoded.
+ It means that, for <literal>walsender</literal>s that are lagging (if any),
+ some WAL records up to the <varname>wal_level</varname> parameter change
+ on the primary won't be decoded.
</para>
<para>
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index b11d9a6ba35..c5997b1e64c 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -2437,11 +2437,12 @@ psql "dbname=postgres replication=database" -c "IDENTIFY_SYSTEM;"
<term>Int32</term>
<listitem>
<para>
- The standby's current global xmin, excluding the catalog_xmin from any
- replication slots. If both this value and the following
- catalog_xmin are 0 this is treated as a notification that hot standby
- feedback will no longer be sent on this connection. Later non-zero
- messages may reinitiate the feedback mechanism.
+ The standby's current global <literal>xmin</literal>, excluding the
+ <literal>catalog_xmin</literal> from any replication slots. If both
+ this value and the following <literal>catalog_xmin</literal>
+ are 0, this is treated as a notification that hot standby feedback
+ will no longer be sent on this connection. Later non-zero messages
+ may reinitiate the feedback mechanism.
</para>
</listitem>
</varlistentry>
@@ -2450,7 +2451,7 @@ psql "dbname=postgres replication=database" -c "IDENTIFY_SYSTEM;"
<term>Int32</term>
<listitem>
<para>
- The epoch of the global xmin xid on the standby.
+ The epoch of the global <literal>xmin</literal> xid on the standby.
</para>
</listitem>
</varlistentry>
@@ -2459,8 +2460,9 @@ psql "dbname=postgres replication=database" -c "IDENTIFY_SYSTEM;"
<term>Int32</term>
<listitem>
<para>
- The lowest catalog_xmin of any replication slots on the standby. Set to 0
- if no catalog_xmin exists on the standby or if hot standby feedback is being
+ The lowest <literal>catalog_xmin</literal> of any replication
+ slots on the standby. Set to 0 if no <literal>catalog_xmin</literal>
+ exists on the standby or if hot standby feedback is being
disabled.
</para>
</listitem>
@@ -2470,7 +2472,7 @@ psql "dbname=postgres replication=database" -c "IDENTIFY_SYSTEM;"
<term>Int32</term>
<listitem>
<para>
- The epoch of the catalog_xmin xid on the standby.
+ The epoch of the <literal>catalog_xmin</literal> xid on the standby.
</para>
</listitem>
</varlistentry>
diff --git a/doc/src/sgml/xact.sgml b/doc/src/sgml/xact.sgml
index b467660eeec..1813cd07748 100644
--- a/doc/src/sgml/xact.sgml
+++ b/doc/src/sgml/xact.sgml
@@ -70,7 +70,7 @@
</para>
<para>
- In addition to <literal>vxid</literal> and <type>xid</type>,
+ In addition to <literal>vxid</literal> and <literal>xid</literal>,
prepared transactions are also assigned Global Transaction
Identifiers (<acronym>GID</acronym>). GIDs are string literals up
to 200 bytes long, which must be unique amongst other currently
@@ -121,7 +121,7 @@
<para>
Subtransactions can be started explicitly using the
<command>SAVEPOINT</command> command, but can also be started in
- other ways, such as PL/pgSQL's <command>EXCEPTION</command> clause.
+ other ways, such as PL/pgSQL's <literal>EXCEPTION</literal> clause.
PL/Python and PL/TCL also support explicit subtransactions.
Subtransactions can also be started from other subtransactions.
The top-level transaction and its child subtransactions form a
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Minipatch concerning tags
2023-10-20 08:22 Minipatch concerning tags Maxim Yablokov <m.yablokov@postgrespro.ru>
@ 2023-10-21 07:11 ` Michael Paquier <michael@paquier.xyz>
2023-10-23 01:01 ` Re: Minipatch concerning tags Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 3+ messages in thread
From: Michael Paquier @ 2023-10-21 07:11 UTC (permalink / raw)
To: Maxim Yablokov <m.yablokov@postgrespro.ru>; +Cc: pgsql-docs@lists.postgresql.org
On Fri, Oct 20, 2023 at 11:22:55AM +0300, Maxim Yablokov wrote:
> PostgresPro documentation team (Ekaterina Kiryanova, Elena Indrupskaya, Oleg
> Sibiryakov and me) have prepared a patch with some improvements concerning
> missed/inapt tags. Please have a look.
Most of what you are proposing makes sense.
> - It means that, for walsenders which are lagging (if any), some WAL records up
> + It means that, for <literal>walsender</literal>s that are lagging (if any),
But not this one. This could just be "WAL senders", but we also use
the term "walsender" in physical and logical replication areas, so a
plural looks OK for me here, leaving it as it is now.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../ZTN5tn9-GMkFkbhR@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Minipatch concerning tags
2023-10-20 08:22 Minipatch concerning tags Maxim Yablokov <m.yablokov@postgrespro.ru>
2023-10-21 07:11 ` Re: Minipatch concerning tags Michael Paquier <michael@paquier.xyz>
@ 2023-10-23 01:01 ` Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 3+ messages in thread
From: Michael Paquier @ 2023-10-23 01:01 UTC (permalink / raw)
To: Maxim Yablokov <m.yablokov@postgrespro.ru>; +Cc: pgsql-docs@lists.postgresql.org
On Sat, Oct 21, 2023 at 04:11:50PM +0900, Michael Paquier wrote:
> But not this one. This could just be "WAL senders", but we also use
> the term "walsender" in physical and logical replication areas, so a
> plural looks OK for me here, leaving it as it is now.
I have reverted this change, added one markup for a catalog_xmin that
was missed, fixed a few whitespaces, and applied it on HEAD.
Thanks!
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../ZTXF_on70-YF3KXQ@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2023-10-23 01:01 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-10-20 08:22 Minipatch concerning tags Maxim Yablokov <m.yablokov@postgrespro.ru>
2023-10-21 07:11 ` Michael Paquier <michael@paquier.xyz>
2023-10-23 01:01 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox