Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uTwLN-00CWpt-Rx for pgsql-docs@arkaria.postgresql.org; Tue, 24 Jun 2025 05:37:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uTwLL-009WJ0-GZ for pgsql-docs@arkaria.postgresql.org; Tue, 24 Jun 2025 05:37:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uTwLL-009WIs-91 for pgsql-docs@lists.postgresql.org; Tue, 24 Jun 2025 05:37:15 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with smtp (Exim 4.96) (envelope-from ) id 1uTwLJ-003fzS-1J for pgsql-docs@lists.postgresql.org; Tue, 24 Jun 2025 05:37:15 +0000 Received: from [192.168.11.9] (p1696134-ipoe.ipoe.ocn.ne.jp [118.0.93.133]) by oss.nttdata.com (Postfix) with ESMTPSA id 79FE26063B; Tue, 24 Jun 2025 14:37:08 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com Message-ID: <4cf5c255-6801-4ca0-ae40-f1a418cb34c3@oss.nttdata.com> Date: Tue, 24 Jun 2025 14:37:07 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Fix incorrect UUID index entry in function documentation From: Fujii Masao To: Daniel Gustafsson Cc: Masahiko Sawada , pgsql-docs@lists.postgresql.org References: <274659ec-3eed-40fb-85d3-bc35014c57a1@oss.nttdata.com> <5508B177-2609-442F-9FB5-B24CF9C51556@yesql.se> <2b4a16fc-cec0-4e15-b8b1-c1a22401005b@oss.nttdata.com> Content-Language: en-US In-Reply-To: <2b4a16fc-cec0-4e15-b8b1-c1a22401005b@oss.nttdata.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025/06/24 0:46, Fujii Masao wrote: >=20 >=20 > On 2025/06/23 23:52, Daniel Gustafsson wrote: >>> On 23 Jun 2025, at 16:40, Fujii Masao w= rote: >> >>> So barring any objections, I will commit the patch. >> >> +1, LGTM. >=20 > Thanks for the review! >=20 >> =C2=A0There is one more occurrence though, the relnotes seem to need t= he >> same treatment as they talk about UUID functions and not the UUID data= type: >> >> diff --git a/doc/src/sgml/release-18.sgml b/doc/src/sgml/release-18.sg= ml >> index 662c7d8890f..fba01d3ca44 100644 >> --- a/doc/src/sgml/release-18.sgml >> +++ b/doc/src/sgml/release-18.sgml >> @@ -2498,7 +2498,7 @@ Author: Masahiko Sawada >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >> -=C2=A0=C2=A0=C2=A0=C2=A0 Add UU= ID >> +=C2=A0=C2=A0=C2=A0=C2=A0 Add U= UID >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 version 7 generation function > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 linkend=3D"func_uuid_gen_table"><= function>uuidv7() >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (Andrey Borodin) >=20 > That "UUID" here seems to refer to the general concept, so I don't thin= k > it needs to link specifically to the UUID functions page. Since the UUI= D > data type page already provides a basic explanation, it makes sense for > the link to point there. Also, since "uuidv7()" and "uuidv4()" there > already link to the UUID functions page, that seems sufficient to me. > Thought? I've committed the proposed patch first. If we later agree to change this part as well, we can commit that separately. Regards, --=20 Fujii Masao NTT DATA Japan Corporation