Feedback-ID: i131946ab:Fastmail
Message-ID: <4e34fcb4-6791-0266-7352-27b769c478f9@enterprisedb.com>
Date: Wed, 26 Apr 2023 08:08:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.0
Subject: Re: confusing positioning of notes in connection settings
Content-Language: en-US
To: "Jonathan S. Katz" <jkatz@postgresql.org>,
 Pg Docs <pgsql-docs@lists.postgresql.org>
References: <6f825d42-a1ce-492a-2ea7-c83e6e65fa8b@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <6f825d42-a1ce-492a-2ea7-c83e6e65fa8b@postgresql.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/4e34fcb4-6791-0266-7352-27b769c478f9%40enterprisedb.com>
Precedence: bulk

On 22.04.23 21:53, Jonathan S. Katz wrote:
> While testing a few other things on the connection settings page[1], I 
> noticed the notes on the "tcp_*" family of settings. While scrolling 
> further down the page, I found myself slightly confused over which note 
> corresponded to which setting (example in screenshot).
> 
> Given the nature of these notes, i.e. to say that the setting is not 
> supported in Windows, couldn't we just add that text to the description 
> of the parameter and remove the note? I think that'd make it a bit 
> clearer which comment applies to which parameter.

I agree we could fold the notes (and other similar notes nearby) into 
the main text.  Or we could just remove them, because the main text 
already contains the information in more general form.

I wonder if the notes are even true.  The text for 
tcp_keepalives_interval already says that it is only supported if 
TCP_KEEPCNT is supported.  There is no specific code for Windows. 
Random googling suggests that TCP_KEEPCNT does exist on Windows.