Message-ID: <4e4141ed-d0f3-4cec-b668-885e59e06c0c@postgrespro.ru>
Date: Tue, 25 Nov 2025 10:08:18 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Documentation improvement patch
To: Daniel Gustafsson <daniel@yesql.se>,
 Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-docs@lists.postgresql.org
References: <e62bedb5-c26f-4d37-b4ed-ce9b55f1e980@postgrespro.ru>
 <3881A97B-0146-4389-9C39-3C596536750B@yesql.se>
 <b9ff5247-04a0-4fe5-9e2f-454b0c7bde7f@postgrespro.ru>
 <84E4E3E6-D702-4604-AE0B-AF92B80B3833@yesql.se>
 <284a26c6-0a38-47ab-bd73-e28943029046@postgrespro.ru>
 <6de77026-b34f-4f32-a0f3-2dc345c4b1bf@eisentraut.org>
 <93538952-E9CC-492C-9BDD-9249AD4C6B91@yesql.se>
 <c2ca18b0-bf47-4566-a4e6-ef0fb676ac21@eisentraut.org>
 <EF13E1C9-2E72-4EA7-8562-A85F4184BD4E@yesql.se>
Content-Language: en-US
From: Oleg <o.sibiryakov@postgrespro.ru>
In-Reply-To: <EF13E1C9-2E72-4EA7-8562-A85F4184BD4E@yesql.se>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/4e4141ed-d0f3-4cec-b668-885e59e06c0c%40postgrespro.ru>
Precedence: bulk

Daniel, Peter, thank you for the thorough review of the patch.

--
Oleg Sibiryakov

On 19.11.2025 17:14, Daniel Gustafsson wrote:
>> On 19 Nov 2025, at 12:02, Peter Eisentraut <peter@eisentraut.org> wrote:
>> The following changes are left in your patch that should not be changed per the above discussion (all in doc/src/sgml/protocol.sgml):
> I did consider these to be separate but re-reading I agree that they should be
> removed.
>
>> Separately, maybe this could be improved further:
>>
>> -        Sets the maximum number of open files each server subprocess is
>> +        Sets the maximum number of files each server subprocess is
>>          allowed to open simultaneously;  files already opened in the
>>
>> I think it would be more correct to say something like "... number of files each server subprocess is allowed to have open simultaneously ..." (not how many open actions are happening concurrently).
> I wonder if the original intent was to write "Sets the maximum number of open
> files each server subprocess is allowed to have simultaneously;"?  That being
> said, your suggestion is better so I'll go with that.
>
> I will push the patch  with the above changes a bit later today.
>
> --
> Daniel Gustafsson
>
>
>