Subject: Re: wal_init_zero and wal_recycle
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Thomas Munro <thomas.munro@gmail.com>, Simon Riggs <simon@2ndquadrant.com>
Cc: pgsql-docs@lists.postgresql.org
References: <b5190ab4-a169-6a42-0e49-aed0807c8976@oss.nttdata.com>
 <CANP8+jJ0NnEnXbe+Rp-T1u-irLX61wtKJ5ORSx8WZW2HtjtOXw@mail.gmail.com>
 <CA+hUKGLZ0WPUZiD+2Yehxx_ToBqur2A4-md6GDZ80HJr9moWdw@mail.gmail.com>
 <ee25c1cc-624b-1043-bd77-f6a9262a1b97@oss.nttdata.com>
Message-ID: <4fce0f34-833b-603c-745f-5a6ab0790183@oss.nttdata.com>
Date: Tue, 2 Jun 2020 14:25:02 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.8.1
MIME-Version: 1.0
In-Reply-To: <ee25c1cc-624b-1043-bd77-f6a9262a1b97@oss.nttdata.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2020/05/29 13:13, Fujii Masao wrote:
> 
> 
> On 2020/05/28 8:43, Thomas Munro wrote:
>> On Wed, May 27, 2020 at 7:09 PM Simon Riggs <simon@2ndquadrant.com> wrote:
>>> On Wed, 27 May 2020 at 04:27, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> The group of wal_init_zero and wal_recycle is WAL_SETTINGS in guc.c,
>>>> but their descriptions are located in "19.6. Replication"/"19.6.1. Sending
>>>> Servers" section. This seems a documentation bug. They should be located
>>>> in "19.5. Write Ahead Log"/"19.5.1. Settings". Thought?
>>>
>>>
>>> +1
> 
> Thanks! Patch attached.
> Since they are located just before wal_buffers in postgresql.conf.sample,
> I moved the descriptions of them also just before that of wal_buffers
> in "Write Ahead Log"/"Settings" section.

Barring any objection, I will commit this patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION