From: Tom Lane <tgl@sss.pgh.pa.us>
To: Euler Taveira <euler@timbira.com.br>
cc: vodevsh@gmail.com, pgsql-docs@postgresql.org
Subject: Re: misleading ALTER TABLE SET STORAGE
In-reply-to: <271e1212-5159-f939-ed9c-10573a538f69@timbira.com.br>
References: <20161108142739.27613.11510@wrigleys.postgresql.org>
 <271e1212-5159-f939-ed9c-10573a538f69@timbira.com.br>
Comments: In-reply-to Euler Taveira <euler@timbira.com.br>
	message dated "Thu, 10 Nov 2016 11:46:34 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5018.1478790246.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 10 Nov 2016 10:04:06 -0500
Message-ID: <5019.1478790246@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

Euler Taveira <euler@timbira.com.br> writes:
> On 08-11-2016 11:27, vodevsh@gmail.com wrote:
>> Was reading
>> https://www.postgresql.org/docs/current/static/storage-toast.html and the
>> bit with &quot;...table column can be altered with ALTER TABLE SET STORA=
GE...&quot;
>> appeared misleading to me.

> AFAICS ALTER TABLE SET STORAGE means ALTER TABLE ... ALTER COLUMN SET
> STORAGE. There is no ALTER TABLE SET STORAGE per table. It seems you are
> confusing with ALTER TABLE SET (storage_parameter =3D value, ...).

> Perhaps, we should use the complete command (ALTER TABLE tablename ALTER
> COLUMN colname SET STORAGE storagetype) or link ALTER TABLE to avoid
> confusion.

Our usual practice is to insert ellipses where there are omissions,
so this probably ought to read "ALTER TABLE ... SET STORAGE".  We could
go with "ALTER TABLE ... ALTER COLUMN ... SET STORAGE", but that's
more verbose and not any more correct.

A link might not be a bad thing either, but it's sort of an independent
question.

			regards, tom lane


--=20
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs