Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lp92I-0004fc-BI for pgsql-docs@arkaria.postgresql.org; Fri, 04 Jun 2021 12:34:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lp92H-0002OR-9u for pgsql-docs@arkaria.postgresql.org; Fri, 04 Jun 2021 12:34:49 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lp92G-0002OI-Vh for pgsql-docs@lists.postgresql.org; Fri, 04 Jun 2021 12:34:49 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lp92E-0006SZ-20 for pgsql-docs@lists.postgresql.org; Fri, 04 Jun 2021 12:34:47 +0000 Received: by mail-ed1-x52e.google.com with SMTP id u24so10911250edy.11 for ; Fri, 04 Jun 2021 05:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec-at.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version; bh=pyOpVfvMEu4ESBR/AiBmuTtxLhwQuwKjABmvbQcK8gQ=; b=u1VLIxEahohY0ATSHwtzFPv0TbUFO9Ni6L9AVmDcvVF0nYmpmvUrxpbP7DhnkF3eqU Z4bga+Eypsav9HuBkvWkuXtRKMQyYWGSboZfWQcCQrHzd+MjQS5SXX9XJsFfcPDNrc23 UJH8ZvqdGW5mKmjlTmbwBX+9hkNhNdWeuBoZ7+yAHZ1ge3SMaaeuLFB5a/UJOUc1iFzc l6HJ+6G/kdogk5lxZg/98x8x4B8ud7MAUisgZE+2xCSOu2YzgoWqlE/OCN+3tJSNZ9F8 6pfm19dmsM+5d6CD4Jp5O1r5c7SUDmq5e4NlqIq/9ZVuILHnhIL+LEA7uPyjDotpY72z /EEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version; bh=pyOpVfvMEu4ESBR/AiBmuTtxLhwQuwKjABmvbQcK8gQ=; b=ORWoCQGOXn15amLc4+hU5UjmUsqRs8Ey7/jvUpJAymocIfC0iUyW2hFDLLehPTX0UQ HUK8a5MhSkJ5oSFgUQaQ1S6ULQQQsZ9SetKz1OEDpXuYUIsHaAN9JZC4oVnFPsTDXn+b ZQ/S19eegZcTQJJKU/+8aUecvU+RcKVd9/C0sCjw5NaMrmi6wKndGrvcvzZicSSMFFTS pgblaRrMUOKYQmlPmyly+LcLE1aQAZPshvkjvlTy+3xqprhuhyBycpRUjvD11ZRLsRpW 8aiBCEB5IIwWdX/u2bWZKebLXB24aBjXvXS6U1p4wckIzdpjZ9DqIBUCXazg4pkbmmHb WPjQ== X-Gm-Message-State: AOAM532FTCZb20SkDKKJ1g5E4mhFDpz48D+bY2leXxBVG+BU9rhuG7vh gxos1TzUFTdmi8i1chavxWiVgQ== X-Google-Smtp-Source: ABdhPJzUcQ2GdvQiTRnb4WBygZE2QtQ+eOj+PC0N9KbsOsk7c2ut6kDLBRZZwH2tx9oDd2g0D0Ad+w== X-Received: by 2002:aa7:dd0b:: with SMTP id i11mr4338790edv.51.1622810084222; Fri, 04 Jun 2021 05:34:44 -0700 (PDT) Received: from localhost.localdomain (217-149-174-252.nat.highway.telekom.at. [217.149.174.252]) by smtp.gmail.com with ESMTPSA id b24sm3141424edw.4.2021.06.04.05.34.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 05:34:43 -0700 (PDT) Message-ID: <514fe5ce4714b7b33cb0a611f0c7b72df413bef5.camel@cybertec.at> Subject: Re: Update maintenance_work_mem/autovacuum_work_mem to reflect the 1GB limitation with VACUUM From: Laurenz Albe To: Masahiko Sawada Cc: =?ISO-8859-1?Q?Mart=EDn_Marqu=E9s?= , pgsql-docs@lists.postgresql.org Date: Fri, 04 Jun 2021 14:34:42 +0200 In-Reply-To: References: <1c6fa18692a77ff6098dedc0c150df24ffe9db89.camel@cybertec.at> Content-Type: multipart/mixed; boundary="=-X7NHXK2eDtTbgRFEI2qY" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=-X7NHXK2eDtTbgRFEI2qY Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2021-06-02 at 18:16 +0900, Masahiko Sawada wrote: > > > We should add a line that indicates that there is a limitation (that > > > should be IMO, backported to documentation of earlier versions as it > > > affects all supported versions), at least until such limitation is > > > lifted. > > Here is a patch for that, > > The patch adds the description in the autovacuum_work_mem section. > Isn't it better to add it in mantenance_work section or VACUUM command > section since this limitation is not only for autovacuum? You are right; theoretically, the correct place to document that would be the VACUUM documentation. But I guess that most people who are curious about VACUUM's memory usage will read the documentation for "maintenance_work_mem" or "autovacuum_work_mem". I have fixed a typo and added a similar paragraph to "maintenance_work_mem". Yours, Laurenz Albe --=-X7NHXK2eDtTbgRFEI2qY Content-Disposition: attachment; filename="0001-Document-the-1GB-memory-limit-for-VACUUM.v2.patch" Content-Type: text/x-patch; name="0001-Document-the-1GB-memory-limit-for-VACUUM.v2.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBhOTQ4MTFlNDVkZjk2ODQ2Y2IwNTMxNjE1ZTlkNzczZjY5ZDJjYzJkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h dD4KRGF0ZTogRnJpLCA0IEp1biAyMDIxIDE0OjMwOjA4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g RG9jdW1lbnQgdGhlIDFHQiBtZW1vcnkgbGltaXQgZm9yIFZBQ1VVTQoKLS0tCiBkb2Mvc3JjL3Nn bWwvY29uZmlnLnNnbWwgfCAxMSArKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDExIGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9kb2Mvc3JjL3NnbWwvY29uZmlnLnNnbWwgYi9kb2Mvc3Jj L3NnbWwvY29uZmlnLnNnbWwKaW5kZXggN2UzMmIwNjg2Yy4uMDk3NjQ5NDUwNiAxMDA2NDQKLS0t IGEvZG9jL3NyYy9zZ21sL2NvbmZpZy5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9jb25maWcuc2dt bApAQCAtMTg4Miw2ICsxODgyLDEyIEBAIGluY2x1ZGVfZGlyICdjb25mLmQnCiAgICAgICAgIHRv byBoaWdoLiAgSXQgbWF5IGJlIHVzZWZ1bCB0byBjb250cm9sIGZvciB0aGlzIGJ5IHNlcGFyYXRl bHkKICAgICAgICAgc2V0dGluZyA8eHJlZiBsaW5rZW5kPSJndWMtYXV0b3ZhY3V1bS13b3JrLW1l bSIvPi4KICAgICAgICA8L3BhcmE+CisgICAgICAgPHBhcmE+CisgICAgICAgIEFsc28sIG5vdGUg dGhhdCA8Y29tbWFuZD5WQUNVVU08L2NvbW1hbmQ+IGhhcyBhIGhhcmQtY29kZWQgbGltaXQgb2Yg MUdCCisgICAgICAgIGZvciB0aGUgYW1vdW50IG9mIG1lbW9yeSB1c2VkLCBzbyBzZXR0aW5nCisg ICAgICAgIDx2YXJuYW1lPm1haW50ZW5hbmNlX3dvcmtfbWVtPC92YXJuYW1lPiBoaWdoZXIgdGhh biB0aGF0IGhhcyBubyBlZmZlY3QKKyAgICAgICAgYXMgZmFyIGFzIDxjb21tYW5kPlZBQ1VVTTwv Y29tbWFuZD4gaXMgY29uY2VybmVkLgorICAgICAgIDwvcGFyYT4KICAgICAgIDwvbGlzdGl0ZW0+ CiAgICAgIDwvdmFybGlzdGVudHJ5PgogCkBAIC0xOTAxLDYgKzE5MDcsMTEgQEAgaW5jbHVkZV9k aXIgJ2NvbmYuZCcKICAgICAgICAgYmUgdXNlZCBpbnN0ZWFkLiAgVGhlIHNldHRpbmcgaGFzIG5v IGVmZmVjdCBvbiB0aGUgYmVoYXZpb3Igb2YKICAgICAgICAgPGNvbW1hbmQ+VkFDVVVNPC9jb21t YW5kPiB3aGVuIHJ1biBpbiBvdGhlciBjb250ZXh0cy4KICAgICAgICA8L3BhcmE+CisgICAgICAg PHBhcmE+CisgICAgICAgIE5vdGUgdGhhdCA8Y29tbWFuZD5WQUNVVU08L2NvbW1hbmQ+IGhhcyBh IGhhcmQtY29kZWQgbGltaXQgb2YgMUdCCisgICAgICAgIGZvciB0aGUgYW1vdW50IG9mIG1lbW9y eSB1c2VkLCBzbyBzZXR0aW5nCisgICAgICAgIDx2YXJuYW1lPmF1dG92YWN1dW1fd29ya19tZW08 L3Zhcm5hbWU+IGhpZ2hlciB0aGFuIHRoYXQgaGFzIG5vIGVmZmVjdC4KKyAgICAgICA8L3BhcmE+ CiAgICAgICA8L2xpc3RpdGVtPgogICAgICA8L3Zhcmxpc3RlbnRyeT4KIAotLSAKMi4yNi4zCgo= --=-X7NHXK2eDtTbgRFEI2qY--