Message-ID: <51aeaae5.a5ac420a.05d9.4850@mx.google.com>
Date: Tue, 4 Jun 2013 21:05:57 -0600
From: eggyknap <eggyknap@gmail.com>
To: pgsql-docs@postgresql.org
Subject: Minor quibble with description of WINDOW clause
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="IjNIXuzrMEaOuFwn"
Content-Disposition: inline
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org


--IjNIXuzrMEaOuFwn
Content-Type: multipart/mixed; boundary="N5iGxCIPT7YMRg16"
Content-Disposition: inline


--N5iGxCIPT7YMRg16
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

The way the WINDOW clause docs are currently worded, it's clear from the
grammar tree that such clauses come toward the end of the query. But this
phrase made me wonder, incorrectly, whether they were supposed to come before
calls to window functions, somehow:

"...where window_name is a name that can be referenced from subsequent window
definitions or OVER clauses"

See http://www.postgresql.org/docs/9.3/static/sql-select.html#SQL-WINDOW for
the full context.

I'd have preferred to see "...from OVER clauses or subsequent window
definitions", which the attached simple patch does. And if I'm the only one
that likes the idea of such a change, I'll gladly go away quietly. :)

--
Joshua Tolley / eggyknap
End Point Corporation
http://www.endpoint.com

--N5iGxCIPT7YMRg16
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="window.doc.patch"

diff --git a/doc/src/sgml/ref/select.sgml b/doc/src/sgml/ref/select.sgml
index 213ea09..68309ba 100644
--- a/doc/src/sgml/ref/select.sgml
+++ b/doc/src/sgml/ref/select.sgml
@@ -654,8 +654,8 @@ HAVING <replaceable class="parameter">condition</replaceable>
 WINDOW <replaceable class="parameter">window_name</replaceable> AS ( <replaceable class="parameter">window_definition</replaceable> ) [, ...]
 </synopsis>
     where <replaceable class="parameter">window_name</replaceable> is
-    a name that can be referenced from subsequent window definitions or
-    <literal>OVER</> clauses, and
+    a name that can be referenced from <literal>OVER</> clauses or
+    subsequent window definitions, and
     <replaceable class="parameter">window_definition</replaceable> is
 <synopsis>
 [ <replaceable class="parameter">existing_window_name</replaceable> ]

--N5iGxCIPT7YMRg16--

--IjNIXuzrMEaOuFwn
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBAgAGBQJRrqsVAAoJEAn8+lmCiIgHgDcP/inwTme22CpWBb9YHe+J+odS
L6dKysqSFI1JZiI3P17aS6aslWIVhNFClejSToC/er7sH+fUUrBlhX4yXC2MYBAi
Wht5AmVU0dFEKdjapANpxTDW6l12iz9VNGAm3/hajcVbiLj+aZMy7FbUz7qnh7Hs
WS7Zzk/CPJFqb/bpFIUtN4Zg7NVgYQEheDrpy1CuqLmzP+Edeq6jZJNMsk7qZvdH
Gvt8v+Y33x6ENzvB5A+M5ZzJqT2WtOXOQXZs88IwXbgDJJvhoMa3Ag76KoP4Uif1
xHSaY59pQtLaTMYyOwaQFBOG/7AY1J4K9JOc3ElhhYog4dJcVBcnx4RL/IJiS28T
bJQJtbV9OR+oPWNaLCsBDBTRGPFp3NKW6KKZ/qCos42QoNzwvkZJJAbMC7ubqxbT
F07odsNmbpicgMO35QnPRhE+XivFq2vXvkpnK7INx5WNXOVuYqB2QseT8XTmzwoX
3CEROdW7CZnBqV2sCfEVG+BRi6YCpbT5fTZHQPYMsH3TbB56xRyjx+V5YKcoxEqi
HSGGQDfCVVE9UxQEfxDd6jieSv3d0TML0ObVUvCYI/OTSKngraAVSA5WcZoOaZzk
zBrSZdPY5VQYZENlSJJOgsgSo0d2znHOFdh0wRN/sNPt2b0QHqRTJ6oD72fAq2IS
5dQKKTtei7giq1RTwB4i
=v0t8
-----END PGP SIGNATURE-----

--IjNIXuzrMEaOuFwn--