From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: mpnash@google.com, pgsql-docs@lists.postgresql.org
Subject: Re: Typo/wording on
 https://www.postgresql.org/docs/current/catalog-pg-class.html
In-reply-to: <A4F03320-8592-4BF6-8C22-B81CF681BD96@yesql.se>
References: <169518739902.3727338.4793815593763320945@wrigleys.postgresql.org>
 <A4F03320-8592-4BF6-8C22-B81CF681BD96@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Wed, 20 Sep 2023 10:52:51 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <520463.1695217750.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 20 Sep 2023 09:49:10 -0400
Message-ID: <520464.1695217750@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/520464.1695217750%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
>> On 20 Sep 2023, at 07:23, PG Doc comments form <noreply@postgresql.org>=
 wrote:
>> I've just read this:
>> "catalogs tables and most everything else that has columns or is otherw=
ise
>> similar to a table"
>> It seems that it should be:
>> "catalogs tables and almost everything else that has columns or is othe=
rwise
>> similar to a table"

> While I'm not a native english speaker I do believe this wording is corr=
ect
> (although I guess your version would be semantically the same or very cl=
ose to
> it).  It was done in commit 83501ef4ca some 20+ years ago.

"Most" here is good English, although I concede it's a slightly
old-fashioned usage.  Maybe it'd be clearer to just remove the
word altogether.

If we were going to touch this sentence I'd worry about some other
things too.  Use of "catalogs" as a verb is probably not the greatest
choice right here, since one could easily think that the verb is
missing and what was meant was "pg_class lists catalogs, [user]
tables, and ...".  Also, I think that the reference to special
relations is obsolete --- we don't list any relkind for that anymore.
What probably does deserve to be called out in place of those is
composite types, since their appearance in pg_class might be pretty
surprising to newbies.

			regards, tom lane