public inbox for [email protected]
help / color / mirror / Atom feedPatch for CREATE RULE sgml
7+ messages / 5 participants
[nested] [flat]
* Patch for CREATE RULE sgml
@ 2014-03-20 20:24 Emanuel Calvo <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Emanuel Calvo @ 2014-03-20 20:24 UTC (permalink / raw)
To: pgsql-docs
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Hi guys,
I realized that the output of the CREATE RULE has not a detailed
output for the "events" parameter.
But the question here is that I'm not sure which format follow:
- --
{ INSERT | UPDATE | DELETE | SELECT}
or
INSERT
UPDATE
DELETE
SELECT
- --
I attach a patch for each one.
Regards,
- --
- --
Emanuel Calvo
Consultant // 2ndQuadrant
Bs. As., Argentina // (GMT-3)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.18 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBCgAGBQJTK05yAAoJEIBeI/HMagHmXEkQAJdXdqtPkRi8ZueupUYQxq9+
wJGOeBRGQRYLxZF2n6lqPy789JhjC8n9WyF5/In1zp9LAbbhLXQGaiR+Rueb5Xyv
c7m/4+qmrDnds8qTHtNZl7gdDqNm8Qbl8K5/puYKrifBBC6R11HrPiAGckbZuoB9
aO5GJn/qtBNVPDH+1MWhGXu4IRJpFNiH/BW5BD7R3vSMUaO4dbFxE9bmc9seeZL+
67SSMTANgROsjKkYP/roRRrYyW10AF3/20VLoFdfgYtXRDgo2eBJyR+TokjEhvce
h7EOROPpoNFkVHUpaN5UOMYmvlJH+D1IX6pex6nUsQ1YDI0mFJWV+UEKzozC3FO6
BFDRipsrTmzNxo+/BfLsRXhmmiHjaLlsLRZS3aiA41q3BxcbmL7lta4xIdxd+x9T
RCHzb96dJqrB2bp9PgaSgH/lxOqTwCQ4rylK3gUOeWpMU8TzLwyuy4bUD2bQYgFj
SkLl1aWYTs3WQFPQJ5tO2J3LO6hfvMbxBCAAloeqaghlo2uhnWHQpD+YIMR9/vGx
3bDiVMh2MWWWF4CNe9RQxW5jYwK8JtR79D5u6lNXK4zJ+NYJqYa3kUOprfZnVuM7
pH2EQEnMWQ6PdlSkNv/1lgRBXzb2rynaht9qzsWylhpiieM2+O6w7MsqsPNdPMP7
sii2/ymQmu5yatHo/Mwc
=rkEY
-----END PGP SIGNATURE-----
--
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
Attachments:
[text/x-diff] add_events_on_create_rule.patch (881B, 2-add_events_on_create_rule.patch)
download | inline diff:
diff --git a/doc/src/sgml/ref/create_rule.sgml b/doc/src/sgml/ref/create_rule.sgml
index d3212b5..22b46e2 100644
--- a/doc/src/sgml/ref/create_rule.sgml
+++ b/doc/src/sgml/ref/create_rule.sgml
@@ -24,6 +24,9 @@ PostgreSQL documentation
CREATE [ OR REPLACE ] RULE <replaceable class="parameter">name</replaceable> AS ON <replaceable class="parameter">event</replaceable>
TO <replaceable class="parameter">table_name</replaceable> [ WHERE <replaceable class="parameter">condition</replaceable> ]
DO [ ALSO | INSTEAD ] { NOTHING | <replaceable class="parameter">command</replaceable> | ( <replaceable class="parameter">command</replaceable> ; <replaceable class="parameter">command</replaceable> ... ) }
+
+<phrase>where <replaceable class="parameter">event</replaceable> can be one of:</phrase>
+ { INSERT | UPDATE | DELETE | SELECT}
</synopsis>
</refsynopsisdiv>
[text/x-diff] add_events_on_create_rule_2.patch (888B, 3-add_events_on_create_rule_2.patch)
download | inline diff:
diff --git a/doc/src/sgml/ref/create_rule.sgml b/doc/src/sgml/ref/create_rule.sgml
index d3212b5..a4df024 100644
--- a/doc/src/sgml/ref/create_rule.sgml
+++ b/doc/src/sgml/ref/create_rule.sgml
@@ -24,6 +24,12 @@ PostgreSQL documentation
CREATE [ OR REPLACE ] RULE <replaceable class="parameter">name</replaceable> AS ON <replaceable class="parameter">event</replaceable>
TO <replaceable class="parameter">table_name</replaceable> [ WHERE <replaceable class="parameter">condition</replaceable> ]
DO [ ALSO | INSTEAD ] { NOTHING | <replaceable class="parameter">command</replaceable> | ( <replaceable class="parameter">command</replaceable> ; <replaceable class="parameter">command</replaceable> ... ) }
+
+<phrase>where <replaceable class="parameter">event</replaceable> can be one of:</phrase>
+ INSERT
+ UPDATE
+ DELETE
+ SELECT
</synopsis>
</refsynopsisdiv>
^ permalink raw reply [nested|flat] 7+ messages in thread
* Patch for CREATE RULE sgml -- Was in: [DOCS]
@ 2014-03-21 15:56 Emanuel Calvo <[email protected]>
parent: Emanuel Calvo <[email protected]>
0 siblings, 2 replies; 7+ messages in thread
From: Emanuel Calvo @ 2014-03-21 15:56 UTC (permalink / raw)
To: [email protected] <[email protected]>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Hi guys,
I realized that the output of the CREATE RULE has not a detailed
output for the "events" parameter.
But the question here is that I'm not sure which format follow:
{ INSERT | UPDATE | DELETE | SELECT}
or
INSERT
UPDATE
DELETE
SELECT
- --
I attach a patch for each one.
I sent a mail to pgsql-docs but no response has been received.
Thanks and regards,
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.18 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBCgAGBQJTLGERAAoJEIBeI/HMagHmUYcP/ibZQaTYDgLmclqgv6wbeTnT
m9d9mhYEJVhdyowGcJ5s+OSCN5tj2vGJifjxUAQ+6hW+0mzj9kqQLoWJyb9DYn1o
AbbUM6+p2Q1+P5KAUYMVZDRiGN6EqFPw2BgsXhIA2rXHT/PiSPpKvFK6wQ0rmSyX
houtfrXEl4zzLHyrmHZmWHyz6DgPyTM/jtHTd/yhAl1OxKR5V583bHEfDUz3zYEX
v6NjBiq5TY6uaXVF0B0cya8nRfW3KP240cwZTF5zRoyHZ1LNlHLPEPs2huNZPLbk
tp3UIHhdiZKl7ddJcWTTeuv4ABQXQVBLQwHWR91szMr+dz/Wsk0zmeFNzlCKCzzN
cehz5n6yewIiosS1MlD7lxOAHPN0yiXtsjiOWoQYbLaxkcTO74oUZK1iWXD025TB
vSegM0L1a1GJFNjyZhQnUgMLWELhsC5y1g7Pn7D9YkzeyicEFtFRTkGDR9eh9LmV
PNtV4w5M/hZtbappfoW7IL6tLtZnjHUA+UjPflnoae0uQ8G+MOW+3rkXt30BksdR
VXvbhXTXaKLj2cEs8cfyBuVUs8AwBGssjfX2OxkSYjvGYcHVoSN/o0cqOWUD/mMi
98ORZcLrzWk70kQ0zxW9wIXbkp4M+8uogyzL9ViveiLREHYD9SRlWMGPpgbcs/aM
fB7fgznJGvXZoRefJKdQ
=UWLa
-----END PGP SIGNATURE-----
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachments:
[text/x-diff] add_events_on_create_rule.patch (882B, 2-add_events_on_create_rule.patch)
download | inline diff:
diff --git a/doc/src/sgml/ref/create_rule.sgml b/doc/src/sgml/ref/create_rule.sgml
index d3212b5..22b46e2 100644
--- a/doc/src/sgml/ref/create_rule.sgml
+++ b/doc/src/sgml/ref/create_rule.sgml
@@ -24,6 +24,9 @@ PostgreSQL documentation
CREATE [ OR REPLACE ] RULE <replaceable class="parameter">name</replaceable> AS ON <replaceable class="parameter">event</replaceable>
TO <replaceable class="parameter">table_name</replaceable> [ WHERE <replaceable class="parameter">condition</replaceable> ]
DO [ ALSO | INSTEAD ] { NOTHING | <replaceable class="parameter">command</replaceable> | ( <replaceable class="parameter">command</replaceable> ; <replaceable class="parameter">command</replaceable> ... ) }
+
+<phrase>where <replaceable class="parameter">event</replaceable> can be one of:</phrase>
+ { INSERT | UPDATE | DELETE | SELECT}
</synopsis>
</refsynopsisdiv>
[text/x-diff] add_events_on_create_rule_2.patch (889B, 3-add_events_on_create_rule_2.patch)
download | inline diff:
diff --git a/doc/src/sgml/ref/create_rule.sgml b/doc/src/sgml/ref/create_rule.sgml
index d3212b5..a4df024 100644
--- a/doc/src/sgml/ref/create_rule.sgml
+++ b/doc/src/sgml/ref/create_rule.sgml
@@ -24,6 +24,12 @@ PostgreSQL documentation
CREATE [ OR REPLACE ] RULE <replaceable class="parameter">name</replaceable> AS ON <replaceable class="parameter">event</replaceable>
TO <replaceable class="parameter">table_name</replaceable> [ WHERE <replaceable class="parameter">condition</replaceable> ]
DO [ ALSO | INSTEAD ] { NOTHING | <replaceable class="parameter">command</replaceable> | ( <replaceable class="parameter">command</replaceable> ; <replaceable class="parameter">command</replaceable> ... ) }
+
+<phrase>where <replaceable class="parameter">event</replaceable> can be one of:</phrase>
+ INSERT
+ UPDATE
+ DELETE
+ SELECT
</synopsis>
</refsynopsisdiv>
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Patch for CREATE RULE sgml -- Was in: [DOCS]
@ 2014-03-22 01:15 Michael Paquier <[email protected]>
parent: Emanuel Calvo <[email protected]>
1 sibling, 1 reply; 7+ messages in thread
From: Michael Paquier @ 2014-03-22 01:15 UTC (permalink / raw)
To: Emanuel Calvo <[email protected]>; +Cc: [email protected] <[email protected]>
On Sat, Mar 22, 2014 at 12:56 AM, Emanuel Calvo
<[email protected]> wrote:
> I realized that the output of the CREATE RULE has not a detailed
> output for the "events" parameter.
>
> But the question here is that I'm not sure which format follow:
>
> { INSERT | UPDATE | DELETE | SELECT}
>
> or
>
> INSERT
> UPDATE
> DELETE
> SELECT
> - --
>
>
> I attach a patch for each one.
>
> I sent a mail to pgsql-docs but no response has been received.
The list of events possible is already listed in the section
"Parameters" => "event":
Page: http://www.postgresql.org/docs/devel/static/sql-createrule.html
Quote: "The event is one of SELECT, INSERT, UPDATE, or DELETE."
Regards,
--
Michael
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Patch for CREATE RULE sgml -- Was in: [DOCS]
@ 2014-03-22 02:18 Jaime Casanova <[email protected]>
parent: Michael Paquier <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Jaime Casanova @ 2014-03-22 02:18 UTC (permalink / raw)
To: Michael Paquier <[email protected]>; +Cc: Emanuel Calvo <[email protected]>; [email protected] <[email protected]>
On Fri, Mar 21, 2014 at 8:15 PM, Michael Paquier
<[email protected]> wrote:
>
> On Sat, Mar 22, 2014 at 12:56 AM, Emanuel Calvo
> <[email protected]> wrote:
> > I realized that the output of the CREATE RULE has not a detailed
> > output for the "events" parameter.
> >
> The list of events possible is already listed in the section
> "Parameters" => "event":
AFAIU, the synopsis is used to build the help command (\h) in psql.
Currently in that help the events doesn't appear.
btw, CREATE TRIGGER already looks this way:
http://www.postgresql.org/docs/current/static/sql-createtrigger.html
--
Jaime Casanova www.2ndQuadrant.com
Professional PostgreSQL: Soporte 24x7 y capacitación
Phone: +593 4 5107566 Cell: +593 987171157
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Patch for CREATE RULE sgml -- Was in: [DOCS]
@ 2014-03-22 06:32 Michael Paquier <[email protected]>
parent: Jaime Casanova <[email protected]>
0 siblings, 0 replies; 7+ messages in thread
From: Michael Paquier @ 2014-03-22 06:32 UTC (permalink / raw)
To: Jaime Casanova <[email protected]>; +Cc: Emanuel Calvo <[email protected]>; [email protected] <[email protected]>
On Sat, Mar 22, 2014 at 11:18 AM, Jaime Casanova <[email protected]> wrote:
> On Fri, Mar 21, 2014 at 8:15 PM, Michael Paquier
> <[email protected]> wrote:
>>
>> On Sat, Mar 22, 2014 at 12:56 AM, Emanuel Calvo
>> <[email protected]> wrote:
>> > I realized that the output of the CREATE RULE has not a detailed
>> > output for the "events" parameter.
>> >
>> The list of events possible is already listed in the section
>> "Parameters" => "event":
>
> AFAIU, the synopsis is used to build the help command (\h) in psql.
> Currently in that help the events doesn't appear.
> btw, CREATE TRIGGER already looks this way:
> http://www.postgresql.org/docs/current/static/sql-createtrigger.html
You are right, I forgot this one... In this case patch 2 could be backpatched...
--
Michael
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Patch for CREATE RULE sgml -- Was in: [DOCS]
@ 2014-03-24 12:51 Fujii Masao <[email protected]>
parent: Emanuel Calvo <[email protected]>
1 sibling, 1 reply; 7+ messages in thread
From: Fujii Masao @ 2014-03-24 12:51 UTC (permalink / raw)
To: Emanuel Calvo <[email protected]>; +Cc: [email protected] <[email protected]>
On Sat, Mar 22, 2014 at 12:56 AM, Emanuel Calvo
<[email protected]> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
>
>
> Hi guys,
>
> I realized that the output of the CREATE RULE has not a detailed
> output for the "events" parameter.
>
> But the question here is that I'm not sure which format follow:
>
> { INSERT | UPDATE | DELETE | SELECT}
>
> or
>
> INSERT
> UPDATE
> DELETE
> SELECT
> - --
>
>
> I attach a patch for each one.
Though I'm not sure the right policy of the format in synopsis, ISTM that
the following format is suitable in this case, i.e., if the value list
is very simple.
Patch attached.
SELECT | INSERT | UPDATE | DELETE
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachments:
[text/x-patch] add_events_on_create_rule_fujii.patch (805B, 2-add_events_on_create_rule_fujii.patch)
download | inline diff:
*** a/doc/src/sgml/ref/create_rule.sgml
--- b/doc/src/sgml/ref/create_rule.sgml
***************
*** 24,29 **** PostgreSQL documentation
--- 24,33 ----
CREATE [ OR REPLACE ] RULE <replaceable class="parameter">name</replaceable> AS ON <replaceable class="parameter">event</replaceable>
TO <replaceable class="parameter">table_name</replaceable> [ WHERE <replaceable class="parameter">condition</replaceable> ]
DO [ ALSO | INSTEAD ] { NOTHING | <replaceable class="parameter">command</replaceable> | ( <replaceable class="parameter">command</replaceable> ; <replaceable class="parameter">command</replaceable> ... ) }
+
+ <phrase>where <replaceable class="parameter">event</replaceable> can be one of:</phrase>
+
+ SELECT | INSERT | UPDATE | DELETE
</synopsis>
</refsynopsisdiv>
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Patch for CREATE RULE sgml -- Was in: [DOCS]
@ 2014-04-22 21:54 Bruce Momjian <[email protected]>
parent: Fujii Masao <[email protected]>
0 siblings, 0 replies; 7+ messages in thread
From: Bruce Momjian @ 2014-04-22 21:54 UTC (permalink / raw)
To: Fujii Masao <[email protected]>; +Cc: Emanuel Calvo <[email protected]>; [email protected] <[email protected]>
On Mon, Mar 24, 2014 at 09:51:07PM +0900, Fujii Masao wrote:
> On Sat, Mar 22, 2014 at 12:56 AM, Emanuel Calvo
> <[email protected]> wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA512
> >
> >
> >
> > Hi guys,
> >
> > I realized that the output of the CREATE RULE has not a detailed
> > output for the "events" parameter.
> >
> > But the question here is that I'm not sure which format follow:
> >
> > { INSERT | UPDATE | DELETE | SELECT}
> >
> > or
> >
> > INSERT
> > UPDATE
> > DELETE
> > SELECT
> > - --
> >
> >
> > I attach a patch for each one.
>
> Though I'm not sure the right policy of the format in synopsis, ISTM that
> the following format is suitable in this case, i.e., if the value list
> is very simple.
> Patch attached.
>
> SELECT | INSERT | UPDATE | DELETE
Patch applied.
--
Bruce Momjian <[email protected]> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2014-04-22 21:54 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2014-03-20 20:24 Patch for CREATE RULE sgml Emanuel Calvo <[email protected]>
2014-03-21 15:56 ` Patch for CREATE RULE sgml -- Was in: [DOCS] Emanuel Calvo <[email protected]>
2014-03-22 01:15 ` Re: Patch for CREATE RULE sgml -- Was in: [DOCS] Michael Paquier <[email protected]>
2014-03-22 02:18 ` Re: Patch for CREATE RULE sgml -- Was in: [DOCS] Jaime Casanova <[email protected]>
2014-03-22 06:32 ` Re: Patch for CREATE RULE sgml -- Was in: [DOCS] Michael Paquier <[email protected]>
2014-03-24 12:51 ` Re: Patch for CREATE RULE sgml -- Was in: [DOCS] Fujii Masao <[email protected]>
2014-04-22 21:54 ` Re: Patch for CREATE RULE sgml -- Was in: [DOCS] Bruce Momjian <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox