Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-docs-owner+M8033=pgsql+2Ddocs=arkaria.postgresql.org@postgresql.org>)
 id 1XGYLu-00040a-IV
 for pgsql-docs@arkaria.postgresql.org; Sun, 10 Aug 2014 19:00:22 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.80) (envelope-from
 <pgsql-docs-owner+M8033=pgsql+2Ddocs=arkaria.postgresql.org@postgresql.org>)
 id 1XGYLt-0005E0-4H
 for pgsql-docs@arkaria.postgresql.org; Sun, 10 Aug 2014 19:00:21 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
 by malur.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256)
 (Exim 4.80) (envelope-from <vik.fearing@dalibo.com>)
 id 1XGYLs-0005Dq-7Q
 for pgsql-docs@postgresql.org; Sun, 10 Aug 2014 19:00:20 +0000
Received: from mimolette.dalibo.net ([212.85.154.222])
 by magus.postgresql.org with esmtp (Exim 4.80)
 (envelope-from <vik.fearing@dalibo.com>) id 1XGYLn-0000qQ-V3
 for pgsql-docs@postgresql.org; Sun, 10 Aug 2014 19:00:19 +0000
Received: from [192.168.42.137] (unknown [37.163.238.0])
 by mimolette.dalibo.net (Postfix) with ESMTPSA id 0E2305080732;
 Sun, 10 Aug 2014 21:00:07 +0200 (CEST)
Message-ID: <53E7C12F.3020901@dalibo.com>
Date: Sun, 10 Aug 2014 20:59:59 +0200
From: Vik Fearing <vik.fearing@dalibo.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.0
MIME-Version: 1.0
To: MauMau <maumau307@gmail.com>, PG Docs <pgsql-docs@postgresql.org>
Subject: Re: pageinspect forks
References: <53D8E0D9.9090300@dalibo.com>
 <510823BF13464AAE872F0C81C194E86C@maumau>
In-Reply-To: <510823BF13464AAE872F0C81C194E86C@maumau>
Content-Type: multipart/mixed; boundary="------------070601030902060303040404"
X-Pg-Spam-Score: -1.9 (-)
List-Archive: <http://archives.postgresql.org/pgsql-docs>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-docs.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@postgresql.org>
List-Post: <mailto:pgsql-docs@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-docs>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-docs>
X-Mailing-List: pgsql-docs
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

This is a multi-part message in MIME format.
--------------070601030902060303040404
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 08/10/2014 03:24 PM, MauMau wrote:
> From: "Vik Fearing" <vik.fearing@dalibo.com>
>> I noticed that the documentation for pageinspect lists the different
>> forks but omits the initialization fork.
>>
>> Here is a trivial patch to fix that.
> 
> Could you also improve the doc by changing "table" to "relation" in the
> description of get_raw_page()?  Having a quick look at the code, it
> seems that the function can also handle indexes.
> 
>        table and returns a copy as a <type>bytea</> value.  This allows a


Good catch.  I wasn't sure whether using "relation" or "table or index"
was better, but after a quick test it seems it works for sequences, too,
so I've gone with "relation".

It doesn't work with views, of course, but it does work with
materialized views.

Modified patch attached.
-- 
Vik

--------------070601030902060303040404
Content-Type: text/x-diff;
 name="pageinspect_init_fork.v2.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="pageinspect_init_fork.v2.patch"

*** a/doc/src/sgml/pageinspect.sgml
--- b/doc/src/sgml/pageinspect.sgml
***************
*** 28,38 ****
      <listitem>
       <para>
        <function>get_raw_page</function> reads the specified block of the named
!       table and returns a copy as a <type>bytea</> value.  This allows a
        single time-consistent copy of the block to be obtained.
        <replaceable>fork</replaceable> should be <literal>'main'</literal> for
!       the main data fork, or <literal>'fsm'</literal> for the free space map,
!       or <literal>'vm'</literal> for the visibility map.
       </para>
      </listitem>
     </varlistentry>
--- 28,39 ----
      <listitem>
       <para>
        <function>get_raw_page</function> reads the specified block of the named
!       relation and returns a copy as a <type>bytea</> value.  This allows a
        single time-consistent copy of the block to be obtained.
        <replaceable>fork</replaceable> should be <literal>'main'</literal> for
!       the main data fork, <literal>'fsm'</literal> for the free space map,
!       <literal>'vm'</literal> for the visibility map, or <literal>'init'</literal>
!       for the initialization fork.
       </para>
      </listitem>
     </varlistentry>

--------------070601030902060303040404
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

--------------070601030902060303040404--