public inbox for [email protected]
help / color / mirror / Atom feedFrom: Josh Berkus <[email protected]>
To: Tom Lane <[email protected]>
To: Kevin Grittner <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: Sample archive_command is still problematic
Date: Mon, 11 Aug 2014 15:20:10 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <WM!ad04baf68b55fc012ecde338c38dfa35fe607c8e9415983d94eb18a03017599e437653a42580391e963642b85709668e!@asav-2.01.com>
References: <[email protected]>
<[email protected]>
<WM!2e9e963ef1fa06e085aa9dbf135a205b718dad5470c1598eeabb71225f19676528ed8e4fad97f9075cbabdcbac8b68ac!@asav-1.01.com>
<[email protected]>
<[email protected]>
<[email protected]>
<WM!ad04baf68b55fc012ecde338c38dfa35fe607c8e9415983d94eb18a03017599e437653a42580391e963642b85709668e!@asav-2.01.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-docs>
On 08/11/2014 12:49 PM, Tom Lane wrote:
> Kevin Grittner <[email protected]> writes:
>> Josh Berkus <[email protected]> wrote:
>>> Yeah, realistically, I think we need to start supplying a script or two
>>> in /contrib and referencing that.� I'm not sure how to make it work for
>>> the Windows users though.
>
>> That might work.� We should do something, though.� The example we
>> give in the docs is not production quality IMO, and is something of
>> an embarrassment.
>
> Well, it's not really intended to be production grade, and I think the
> docs say so (perhaps not emphatically enough).
Thing is, if we supply a sample command in the docs ... even if it's
preceeded by ***DO NOT USE WILL EAT YOUR SERVER*** ... people will still
copy-and-paste it, and then put it into production.
> The problem with such things as sample scripts is that it might get hard
> for people to tell the difference between barnacles (like email ;-))
> and properties that they'd better preserve in any custom script.
> The documentation is primarily trying to make the point that the archive
> action must not overwrite any existing file (which is such a property)
> and that's why it has the test ! -f. It doesn't really address the
> question of appropriate error handling, which is what Josh is on about.
I'm suggesting that we've established that there is no one-liner which
will not cause real problems for users who copy it. Given that, we
should not supply a one-liner, even as an example; we should supply some
sample scripts, and a reference in the docs:
"Please look at /share/archiving-scripts/ for some sample shell scripts
for archiving, or use a project like WAL-E, Barman, or OmniPITR."
The alternative is to supply a C utility ourselves for log copying, but
I think the presence of multiple archiving utilities is a good argument
that it's not possible for any given utility to cover more than 30% of
use-cases.
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
--
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
view thread (25+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Sample archive_command is still problematic
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox