Message-ID: <53F38726.2040804@agliodbs.com>
Date: Tue, 19 Aug 2014 10:19:34 -0700
From: Josh Berkus <josh@agliodbs.com>
Organization: PostgreSQL Experts Inc.
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Tom Lane <tgl@sss.pgh.pa.us>
CC: Magnus Hagander <magnus@hagander.net>, Kevin Grittner <kgrittn@ymail.com>,
 Peter Eisentraut <peter_e@gmx.net>, MauMau <maumau307@gmail.com>,
 "pgsql-docs@postgresql.org" <pgsql-docs@postgresql.org>
Subject: Re: Sample archive_command is still problematic
References: <53E5603B.5040102@agliodbs.com>
 <1407777686.41146.YahooMailNeo@web122306.mail.ne1.yahoo.com>
 <0F73426A2EA544878BCAC33BB989D671@maumau> <53EBCCEA.3090604@gmx.net>
 <1407965034.12878.YahooMailNeo@web122304.mail.ne1.yahoo.com>
 <CABUevEwiaBWkgV+RX=Y77hauz-oKSo=7Tu7S7a8DN4dXGZSdTQ@mail.gmail.com>
 <WM!82507310e76be1df29048280e058916e28f087da5fbabb90b2b211e11d1cadd78895174bd7e489fa8d894cb824320620!@asav-2.01.com>
 <53F233E1.3030605@agliodbs.com> <5718.1408383072@sss.pgh.pa.us>
 <WM!babf90da7866940a682481e46c386e7c69000c9a267ccfe19e97313775bb5606a68d4d2e6154337bfc31bd0d337be822!@asav-1.01.com>
In-Reply-To: 
 <WM!babf90da7866940a682481e46c386e7c69000c9a267ccfe19e97313775bb5606a68d4d2e6154337bfc31bd0d337be822!@asav-1.01.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

On 08/18/2014 10:31 AM, Tom Lane wrote:
> Josh Berkus <josh@agliodbs.com> writes:
>> 2) One reason users are using the "test -f" version of the archive
>> command is that we put it in the same postgresql.conf.  I would suggest
>> that we don't put *any* archive command in the sample postgresql.conf,
>> since there is no command we can supply which isn't a potential foot-gun.
> 
> If you want to remove the last line of this:
> 
> #archive_command = ''		# command to use to archive a logfile segment
> 				# placeholders: %p = path of file to archive
> 				#               %f = file name only
> 				# e.g. 'test ! -f /mnt/server/archivedir/%f && cp %p /mnt/server/archivedir/%f'
> 
> I'm okay with that.  But if you want to remove the sample command from the
> SGML docs I'm going to push back a bit harder...

Well, if we want a sample command in the docs, then we should actually
give a few different sample commands and even a sample shell script.  If
we give the users several alternatives, maybe they'll actually think
about it instead of just C&P.

Make sense?

-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs