Message-ID: <540855D0.4020108@joh.to>
Date: Thu, 04 Sep 2014 14:06:40 +0200
From: Marko Tiikkaja <marko@joh.to>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8;
 rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: PG Docs <pgsql-docs@postgresql.org>
Subject: Broken example in PL/PgSQL documentation
Content-Type: multipart/mixed; boundary="------------070300040209030209020507"
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

This is a multi-part message in MIME format.
--------------070300040209030209020507
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

Just came across a broken example in the docs:

local:marko=#* select * from extended_sales(1);
ERROR:  column reference "quantity" is ambiguous
LINE 1: SELECT quantity, quantity * price FROM sales
                ^
DETAIL:  It could refer to either a PL/pgSQL variable or a table column.
QUERY:  SELECT quantity, quantity * price FROM sales
                  WHERE itemno = p_itemno
CONTEXT:  PL/pgSQL function "extended_sales" line 3 at RETURN QUERY

Patch to fix this attached.


.marko

--------------070300040209030209020507
Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0";
 name="plpgsql_return_query.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="plpgsql_return_query.patch"

*** a/doc/src/sgml/plpgsql.sgml
--- b/doc/src/sgml/plpgsql.sgml
***************
*** 487,494 **** $$ LANGUAGE plpgsql;
  CREATE FUNCTION extended_sales(p_itemno int)
  RETURNS TABLE(quantity int, total numeric) AS $$
  BEGIN
!     RETURN QUERY SELECT quantity, quantity * price FROM sales
!                  WHERE itemno = p_itemno;
  END;
  $$ LANGUAGE plpgsql;
  </programlisting>
--- 487,494 ----
  CREATE FUNCTION extended_sales(p_itemno int)
  RETURNS TABLE(quantity int, total numeric) AS $$
  BEGIN
!     RETURN QUERY SELECT sales.quantity, sales.quantity * sales.price FROM sales
!                  WHERE sales.itemno = p_itemno;
  END;
  $$ LANGUAGE plpgsql;
  </programlisting>

--------------070300040209030209020507
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

--------------070300040209030209020507--