Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-docs-owner+M8241=pgsql+2Ddocs=arkaria.postgresql.org@postgresql.org>)
 id 1Yxmkp-0005kC-44
 for pgsql-docs@arkaria.postgresql.org; Thu, 28 May 2015 01:37:03 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.80) (envelope-from
 <pgsql-docs-owner+M8241=pgsql+2Ddocs=arkaria.postgresql.org@postgresql.org>)
 id 1Yxmko-0002Bh-JT
 for pgsql-docs@arkaria.postgresql.org; Thu, 28 May 2015 01:37:02 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
 by malur.postgresql.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA256:256)
 (Exim 4.80) (envelope-from <jd@commandprompt.com>)
 id 1Yxmkn-0002BZ-UR
 for pgsql-docs@postgresql.org; Thu, 28 May 2015 01:37:02 +0000
Received: from lists.commandprompt.com ([69.168.55.30])
 by makus.postgresql.org with esmtp (Exim 4.84)
 (envelope-from <jd@commandprompt.com>) id 1Yxmkk-0006VY-Ay
 for pgsql-docs@postgresql.org; Thu, 28 May 2015 01:37:00 +0000
Received: from [192.168.1.3] (spinlock.commandprompt.com [69.168.55.30])
 by lists.commandprompt.com (Postfix) with ESMTPA id 5FC0334C;
 Wed, 27 May 2015 18:36:57 -0700 (PDT)
Received: from [192.168.1.3] ([67.168.169.165] helo=[192.168.1.3]) by
 assp.commandprompt.com with ESMTPS(AES128-SHA) (2.1.1);
 27 May 2015 18:36:56 -0700
Message-ID: <55667149.9070609@commandprompt.com>
Date: Wed, 27 May 2015 18:37:13 -0700
From: "Joshua D. Drake" <jd@commandprompt.com>
Organization: Command Prompt, Inc.
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Alvaro Herrera <alvherre@2ndquadrant.com>
CC: pgsql-docs <pgsql-docs@postgresql.org>
Subject: Re: per feedback I received directly, pg_dump manpage patch
References: <55665072.9020409@commandprompt.com>
 <20150528013101.GG5885@postgresql.org>
In-Reply-To: <20150528013101.GG5885@postgresql.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Assp-Version: 2.1.1(11364) on assp.commandprompt.com
X-Assp-Client-SSL: yes
X-Assp-ID: assp.commandprompt.com m1-77017-00307
X-Assp-Envelope-From: jd@commandprompt.com
X-Assp-Intended-For: pgsql-docs@postgresql.org
X-Assp-Original-Subject: Re: [DOCS] per feedback I received directly,
 pg_dump manpage patch
X-Pg-Spam-Score: -1.9 (-)
List-Archive: <http://archives.postgresql.org/pgsql-docs>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-docs.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@postgresql.org>
List-Post: <mailto:pgsql-docs@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-docs>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-docs>
X-Mailing-List: pgsql-docs
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org


On 05/27/2015 06:31 PM, Alvaro Herrera wrote:
>
> Joshua D. Drake wrote:
>> The man page does not clearly state that pg_dump will not dump things like
>> users or roles. It does mention briefly in the notes section that pg_dumpall
>> is needed for items that are set via SET but that isn't very clear on the
>> other items.
>
> I agree that we need a warning about this, but I think it should be a
> bit more generic rather than focused exclusively on pg_dumpall; perhaps
> something like "global objs such as roles/tblspcs should be backed up
> separately, for example using pg_dumpall".

As the only way to back up global objects is pg_dumpall....?


>
> I didn't check the location of the warning in your patch, or whether a
> warning is really appropriate rather than, say, <note> or a plain
> <para>.

The warning is directly after the first paragraph. I thought about using 
<note> but I think this does warrant a <warning>. You can't actually 
restore a database correctly without pg_dump + pg_dumpall (in this context).

JD



-- 
Command Prompt, Inc. - http://www.commandprompt.com/  503-667-4564
PostgreSQL Centered full stack support, consulting and development.
Announcing "I'm offended" is basically telling the world you can't
control your own emotions, so everyone else should do it for you.


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs