Message-ID: <55675B81.8030109@gmx.net>
Date: Thu, 28 May 2015 14:16:33 -0400
From: Peter Eisentraut <peter_e@gmx.net>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10;
 rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: "Joshua D. Drake" <jd@commandprompt.com>,
 pgsql-docs <pgsql-docs@postgresql.org>
Subject: Re: per feedback I received directly, pg_dump manpage patch
References: <55665072.9020409@commandprompt.com>
In-Reply-To: <55665072.9020409@commandprompt.com>
Content-Type: multipart/mixed; boundary="------------090700030803000805040008"
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

This is a multi-part message in MIME format.
--------------090700030803000805040008
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 5/27/15 7:17 PM, Joshua D. Drake wrote:
> The man page does not clearly state that pg_dump will not dump things
> like users or roles. It does mention briefly in the notes section that
> pg_dumpall is needed for items that are set via SET but that isn't very
> clear on the other items.

How about this patch?


--------------090700030803000805040008
Content-Type: text/x-diff;
 name="pg_dump-note.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="pg_dump-note.patch"

diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml
index a6e7b08..33a1902 100644
--- a/doc/src/sgml/ref/pg_dump.sgml
+++ b/doc/src/sgml/ref/pg_dump.sgml
@@ -46,6 +46,12 @@
   </para>
 
   <para>
+   <application>pg_dump</application> only dumps a single database.  To save
+   global objects that are common to all databases in a cluster, such as roles
+   and tablespaces, use <xref linkend="app-pg-dumpall">.
+  </para>
+
+  <para>
    Dumps can be output in script or archive file formats. Script
    dumps are plain-text files containing the SQL commands required
    to reconstruct the database to the state it was in at the time it was

--------------090700030803000805040008
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

--------------090700030803000805040008--