public inbox for [email protected]
help / color / mirror / Atom feedFrom: Charles Clavadetscher <[email protected]>
To: Stephen Frost <[email protected]>
Cc: [email protected]
Subject: Re: [DOCS] Missing COMMENT ON POLICY
Date: Sun, 13 Sep 2015 15:26:58 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-hackers>
Hello Stephen
On 13/09/2015 14:49, Stephen Frost wrote:
> Charles,
>
> Just FYI, on these lists, we'd prefer it if you wouldn't top-post.
>
> * Charles Clavadetscher ([email protected]) wrote:
>> Yes, of course. I will take care of that and send a new patch.
> Thanks!
>
>> Who will then git push it?
> I'd be happy to take care of it, though any of the committers may pick
> it up, of course. If there's a concern about the patch being missed or
> forgotten then it can be added to the commitfest system (here:
> http://commitfest.postgresql.org). I don't believe there's a risk of
> that here, but you're welcome to add it if you'd like, of course.
>
>> Thank you for your feedback.
> Thank you for working on this!
>
> Stephen
In the attachement the new patch. I was not able to create one with both
commits so I also added the first one.
I think that documentation should be as complete as possible, but if you
say that there is no risk in missing the update, then I don't see a need
to add a line in the commitfest.
Thank you also for the hint on top-posting. I was not aware of that.
Have a good Sunday.
Charles
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachments:
[application/softgrid-patch] comment_on_policy.patch (1.2K, 2-comment_on_policy.patch)
download | inline diff:
commit 0327154ba838894ccfb3420daed94b9832fd8bfa
Author: Charles Clavadetscher <[email protected]>
Date: Sun Sep 13 08:08:00 2015 +0200
Added POLICY to list of COMMENT ON objects.
diff --git a/doc/src/sgml/ref/comment.sgml b/doc/src/sgml/ref/comment.sgml
index 1030738..2133e77 100644
--- a/doc/src/sgml/ref/comment.sgml
+++ b/doc/src/sgml/ref/comment.sgml
@@ -43,6 +43,7 @@ COMMENT ON
OPERATOR <replaceable class="PARAMETER">operator_name</replaceable> (<replaceable class="PARAMETER">left_type</replaceable>, <replaceable class="PARAMETER">right_type</replaceable>) |
OPERATOR CLASS <replaceable class="PARAMETER">object_name</replaceable> USING <replaceable class="parameter">index_method</replaceable> |
OPERATOR FAMILY <replaceable class="PARAMETER">object_name</replaceable> USING <replaceable class="parameter">index_method</replaceable> |
+ POLICY <replaceable class="PARAMETER">policy_name</replaceable> ON <replaceable class="PARAMETER">table_name</replaceable> |
[ PROCEDURAL ] LANGUAGE <replaceable class="PARAMETER">object_name</replaceable> |
ROLE <replaceable class="PARAMETER">object_name</replaceable> |
RULE <replaceable class="PARAMETER">rule_name</replaceable> ON <replaceable class="PARAMETER">table_name</replaceable> |
[application/softgrid-patch] definitions_and_example_for_comment_on_policy.patch (1.9K, 3-definitions_and_example_for_comment_on_policy.patch)
download | inline diff:
commit 9f48b64e5220d5e5fa96a2a254219acd3e727072
Author: Charles Clavadetscher <[email protected]>
Date: Sun Sep 13 15:01:55 2015 +0200
Addition of defintions and an example for COMMENT ON POLICY.
diff --git a/doc/src/sgml/ref/comment.sgml b/doc/src/sgml/ref/comment.sgml
index 2133e77..197f78a 100644
--- a/doc/src/sgml/ref/comment.sgml
+++ b/doc/src/sgml/ref/comment.sgml
@@ -115,6 +115,7 @@ COMMENT ON
<term><replaceable class="parameter">function_name</replaceable></term>
<term><replaceable class="parameter">operator_name</replaceable></term>
<term><replaceable class="parameter">rule_name</replaceable></term>
+ <term><replaceable class="parameter">policy_name</replaceable></term>
<term><replaceable class="parameter">trigger_name</replaceable></term>
<listitem>
<para>
@@ -134,9 +135,9 @@ COMMENT ON
<term><replaceable class="parameter">domain_name</replaceable></term>
<listitem>
<para>
- When creating a comment on a constraint on a table or a domain, these
- parameters specify the name of the table or domain on which the
- constraint is defined.
+ When creating a comment on a constraint, a table, a domain or
+ a policy these parameters specify the name of the table or domain on
+ which the constraint is defined.
</para>
</listitem>
</varlistentry>
@@ -316,6 +317,7 @@ COMMENT ON OPERATOR ^ (text, text) IS 'Performs intersection of two texts';
COMMENT ON OPERATOR - (NONE, integer) IS 'Unary minus';
COMMENT ON OPERATOR CLASS int4ops USING btree IS '4 byte integer operators for btrees';
COMMENT ON OPERATOR FAMILY integer_ops USING btree IS 'all integer operators for btrees';
+COMMENT ON POLICY my_policy ON mytable IS 'Filter rows by users';
COMMENT ON ROLE my_role IS 'Administration group for finance tables';
COMMENT ON RULE my_rule ON my_table IS 'Logs updates of employee records';
COMMENT ON SCHEMA my_schema IS 'Departmental data';
view thread (11+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [DOCS] Missing COMMENT ON POLICY
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox