Subject: Re: [DOCS] Missing COMMENT ON POLICY
To: Stephen Frost <sfrost@snowman.net>
References: <016a01d0ede6$1fc6af00$5f540d00$@swisspug.org>
 <016c01d0edec$81975df0$84c619d0$@swisspug.org>
 <20150913123038.GF3685@tamriel.snowman.net>
 <01e601d0ee21$aa4deef0$fee9ccd0$@swisspug.org>
 <20150913124934.GH3685@tamriel.snowman.net> <55F579A2.4080801@swisspug.org>
Cc: pgsql-hackers@postgresql.org
From: Charles Clavadetscher <clavadetscher@swisspug.org>
Message-ID: <55F58771.7040001@swisspug.org>
Date: Sun, 13 Sep 2015 16:25:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <55F579A2.4080801@swisspug.org>
Content-Type: multipart/mixed; boundary="------------060509030003040905060609"
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

This is a multi-part message in MIME format.
--------------060509030003040905060609
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit

Stephen

On 13/09/2015 15:26, Charles Clavadetscher wrote:
> Hello Stephen
>
> On 13/09/2015 14:49, Stephen Frost wrote:
>> Charles,
>>
>> Just FYI, on these lists, we'd prefer it if you wouldn't top-post.
>>
>> * Charles Clavadetscher (clavadetscher@swisspug.org) wrote:
>>> Yes, of course. I will take care of that and send a new patch.
>> Thanks!
>>
>>> Who will then git push it?
>> I'd be happy to take care of it, though any of the committers may pick
>> it up, of course.  If there's a concern about the patch being missed or
>> forgotten then it can be added to the commitfest system (here:
>> http://commitfest.postgresql.org).  I don't believe there's a risk of
>> that here, but you're welcome to add it if you'd like, of course.
>>
>>> Thank you for your feedback.
>> Thank you for working on this!
>>
>> Stephen
> In the attachement the new patch. I was not able to create one with both
> commits so I also added the first one.
> I think that documentation should be as complete as possible, but if you
> say that there is no risk in missing the update, then I don't see a need
> to add a line in the commitfest.
>
> Thank you also for the hint on top-posting. I was not aware of that.
> Have a good Sunday.
> Charles

I noticed that the position of the parameter "policy_name" in the 
description list of parameters was not at the (alphabetically) correct 
position. I changed that and the result is attached.

I think/hope that is now all correct.

Thank you and bye
Charles

--------------060509030003040905060609
Content-Type: application/softgrid-patch;
 name="correct_order_position_of_parameter.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="correct_order_position_of_parameter.patch"

Y29tbWl0IDUxZWY5MDVkM2Q4MWMxODYzNGM3YmM2ZDQwZjAyZTYwMmNjNWFm
M2MKQXV0aG9yOiBDaGFybGVzIENsYXZhZGV0c2NoZXIgPGNsYXZhZGV0c2No
ZXJAc3dpc3NwdWcub3JnPgpEYXRlOiAgIFN1biBTZXAgMTMgMTU6NTA6MzMg
MjAxNSArMDIwMAoKICAgIE1vdmUgb2YgcGFyYW1ldGVyIGRlc2NyaXB0aW9u
IGxpbmUgdG8gY29ycmVjdCBwb3NpdGlvbi4KCmRpZmYgLS1naXQgYS9kb2Mv
c3JjL3NnbWwvcmVmL2NvbW1lbnQuc2dtbCBiL2RvYy9zcmMvc2dtbC9yZWYv
Y29tbWVudC5zZ21sCmluZGV4IDE5N2Y3OGEuLjMzMjFkNGIgMTAwNjQ0Ci0t
LSBhL2RvYy9zcmMvc2dtbC9yZWYvY29tbWVudC5zZ21sCisrKyBiL2RvYy9z
cmMvc2dtbC9yZWYvY29tbWVudC5zZ21sCkBAIC0xMTQsOCArMTE0LDggQEAg
Q09NTUVOVCBPTgogICAgIDx0ZXJtPjxyZXBsYWNlYWJsZSBjbGFzcz0icGFy
YW1ldGVyIj5jb25zdHJhaW50X25hbWU8L3JlcGxhY2VhYmxlPjwvdGVybT4K
ICAgICA8dGVybT48cmVwbGFjZWFibGUgY2xhc3M9InBhcmFtZXRlciI+ZnVu
Y3Rpb25fbmFtZTwvcmVwbGFjZWFibGU+PC90ZXJtPgogICAgIDx0ZXJtPjxy
ZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVyIj5vcGVyYXRvcl9uYW1lPC9y
ZXBsYWNlYWJsZT48L3Rlcm0+Ci0gICAgPHRlcm0+PHJlcGxhY2VhYmxlIGNs
YXNzPSJwYXJhbWV0ZXIiPnJ1bGVfbmFtZTwvcmVwbGFjZWFibGU+PC90ZXJt
PgogICAgIDx0ZXJtPjxyZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVyIj5w
b2xpY3lfbmFtZTwvcmVwbGFjZWFibGU+PC90ZXJtPgorICAgIDx0ZXJtPjxy
ZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVyIj5ydWxlX25hbWU8L3JlcGxh
Y2VhYmxlPjwvdGVybT4KICAgICA8dGVybT48cmVwbGFjZWFibGUgY2xhc3M9
InBhcmFtZXRlciI+dHJpZ2dlcl9uYW1lPC9yZXBsYWNlYWJsZT48L3Rlcm0+
CiAgICAgPGxpc3RpdGVtPgogICAgICA8cGFyYT4K

--------------060509030003040905060609
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------060509030003040905060609--