Subject: Re: [DOCS] Missing COMMENT ON POLICY
To: Stephen Frost <sfrost@snowman.net>
References: <016a01d0ede6$1fc6af00$5f540d00$@swisspug.org>
 <016c01d0edec$81975df0$84c619d0$@swisspug.org>
 <20150913123038.GF3685@tamriel.snowman.net>
 <01e601d0ee21$aa4deef0$fee9ccd0$@swisspug.org>
 <20150913124934.GH3685@tamriel.snowman.net> <55F579A2.4080801@swisspug.org>
 <55F58771.7040001@swisspug.org> <20150913145605.GI3685@tamriel.snowman.net>
Cc: pgsql-hackers@postgresql.org
From: Charles Clavadetscher <clavadetscher@swisspug.org>
Message-ID: <55F5A5E5.8030004@swisspug.org>
Date: Sun, 13 Sep 2015 18:35:49 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20150913145605.GI3685@tamriel.snowman.net>
Content-Type: multipart/mixed; boundary="------------070606020503080404090206"
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

This is a multi-part message in MIME format.
--------------070606020503080404090206
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stephen

On 13/09/2015 16:56, Stephen Frost wrote:
> Charles,
>
> * Charles Clavadetscher (clavadetscher@swisspug.org) wrote:
>> I noticed that the position of the parameter "policy_name" in the
>> description list of parameters was not at the (alphabetically)
>> correct position. I changed that and the result is attached.
>
> Thanks!
>
>> I think/hope that is now all correct.
>
> We generally prefer one complete patch which represents the total set
> of changes to a lot of individual little patches which build on each
> other.
>
> If you're using git and have these patches on a branch as different
> commits, you can do an interactive rebase to squash them all together,
> like this:
>
> git rebase -i
>
> That will open an editor and then you can choose the action to take for
> each patch.  Generally, I'll make the first patch 'reword' and the
> rest 'squash'.  Saving and exiting the editor will then take you to
> another editor session where you'll have an opportunity to reword the
> commit message (to incorporate all of the changes).
>
> Once all of that's done, you can use 'git format-patch' to create a file
> which includes the commit message and the patch.  I generally run it
> like so:
>
> git format-patch @{u} --stdout > ~/patches/filename-for-patch.patch
>
> Hopefully that helps.

Yes, that helped a lot! In the attachment now a single patch file with 
all changes.

Thank you a lot. BTW, looking forward to the server programming workshop 
in Vienna.

Bye
Charles


--------------070606020503080404090206
Content-Type: application/softgrid-patch;
 name="update_comment_doc_with_policy.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="update_comment_doc_with_policy.patch"

RnJvbSBlNTEzMTgzYTdlZDUzOWNkMzQxYzYyNTUwYWMzYTZiYmFhNDcxYzVl
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDaGFybGVzIENsYXZh
ZGV0c2NoZXIgPGNsYXZhZGV0c2NoZXJAc3dpc3NwdWcub3JnPgpEYXRlOiBT
dW4sIDEzIFNlcCAyMDE1IDExOjAyOjI1ICswMjAwClN1YmplY3Q6IFtQQVRD
SF0gQWRkaXRpb24gb2YgUE9MSUNZIHRvIGxpc3Qgb2YgQ09NTUVOVCBvYmpl
Y3RzLCBwYXJhbWV0ZXIKIGxpc3RzIGFuZCBleGFtcGxlcy4KCkFkZGl0aW9u
IG9mIGRlZmludGlvbnMgYW5kIGFuIGV4YW1wbGUgZm9yIENPTU1FTlQgT04g
UE9MSUNZLgoKTW92ZSBvZiBwYXJhbWV0ZXIgZGVzY3JpcHRpb24gbGluZSB0
byBjb3JyZWN0IHBvc2l0aW9uLgotLS0KIGRvYy9zcmMvc2dtbC9yZWYvY29t
bWVudC5zZ21sIHwgOSArKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCA2IGlu
c2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9j
L3NyYy9zZ21sL3JlZi9jb21tZW50LnNnbWwgYi9kb2Mvc3JjL3NnbWwvcmVm
L2NvbW1lbnQuc2dtbAppbmRleCAxMDMwNzM4Li4zMzIxZDRiIDEwMDY0NAot
LS0gYS9kb2Mvc3JjL3NnbWwvcmVmL2NvbW1lbnQuc2dtbAorKysgYi9kb2Mv
c3JjL3NnbWwvcmVmL2NvbW1lbnQuc2dtbApAQCAtNDMsNiArNDMsNyBAQCBD
T01NRU5UIE9OCiAgIE9QRVJBVE9SIDxyZXBsYWNlYWJsZSBjbGFzcz0iUEFS
QU1FVEVSIj5vcGVyYXRvcl9uYW1lPC9yZXBsYWNlYWJsZT4gKDxyZXBsYWNl
YWJsZSBjbGFzcz0iUEFSQU1FVEVSIj5sZWZ0X3R5cGU8L3JlcGxhY2VhYmxl
PiwgPHJlcGxhY2VhYmxlIGNsYXNzPSJQQVJBTUVURVIiPnJpZ2h0X3R5cGU8
L3JlcGxhY2VhYmxlPikgfAogICBPUEVSQVRPUiBDTEFTUyA8cmVwbGFjZWFi
bGUgY2xhc3M9IlBBUkFNRVRFUiI+b2JqZWN0X25hbWU8L3JlcGxhY2VhYmxl
PiBVU0lORyA8cmVwbGFjZWFibGUgY2xhc3M9InBhcmFtZXRlciI+aW5kZXhf
bWV0aG9kPC9yZXBsYWNlYWJsZT4gfAogICBPUEVSQVRPUiBGQU1JTFkgPHJl
cGxhY2VhYmxlIGNsYXNzPSJQQVJBTUVURVIiPm9iamVjdF9uYW1lPC9yZXBs
YWNlYWJsZT4gVVNJTkcgPHJlcGxhY2VhYmxlIGNsYXNzPSJwYXJhbWV0ZXIi
PmluZGV4X21ldGhvZDwvcmVwbGFjZWFibGU+IHwKKyAgUE9MSUNZIDxyZXBs
YWNlYWJsZSBjbGFzcz0iUEFSQU1FVEVSIj5wb2xpY3lfbmFtZTwvcmVwbGFj
ZWFibGU+IE9OIDxyZXBsYWNlYWJsZSBjbGFzcz0iUEFSQU1FVEVSIj50YWJs
ZV9uYW1lPC9yZXBsYWNlYWJsZT4gfAogICBbIFBST0NFRFVSQUwgXSBMQU5H
VUFHRSA8cmVwbGFjZWFibGUgY2xhc3M9IlBBUkFNRVRFUiI+b2JqZWN0X25h
bWU8L3JlcGxhY2VhYmxlPiB8CiAgIFJPTEUgPHJlcGxhY2VhYmxlIGNsYXNz
PSJQQVJBTUVURVIiPm9iamVjdF9uYW1lPC9yZXBsYWNlYWJsZT4gfAogICBS
VUxFIDxyZXBsYWNlYWJsZSBjbGFzcz0iUEFSQU1FVEVSIj5ydWxlX25hbWU8
L3JlcGxhY2VhYmxlPiBPTiA8cmVwbGFjZWFibGUgY2xhc3M9IlBBUkFNRVRF
UiI+dGFibGVfbmFtZTwvcmVwbGFjZWFibGU+IHwKQEAgLTExMyw2ICsxMTQs
NyBAQCBDT01NRU5UIE9OCiAgICAgPHRlcm0+PHJlcGxhY2VhYmxlIGNsYXNz
PSJwYXJhbWV0ZXIiPmNvbnN0cmFpbnRfbmFtZTwvcmVwbGFjZWFibGU+PC90
ZXJtPgogICAgIDx0ZXJtPjxyZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVy
Ij5mdW5jdGlvbl9uYW1lPC9yZXBsYWNlYWJsZT48L3Rlcm0+CiAgICAgPHRl
cm0+PHJlcGxhY2VhYmxlIGNsYXNzPSJwYXJhbWV0ZXIiPm9wZXJhdG9yX25h
bWU8L3JlcGxhY2VhYmxlPjwvdGVybT4KKyAgICA8dGVybT48cmVwbGFjZWFi
bGUgY2xhc3M9InBhcmFtZXRlciI+cG9saWN5X25hbWU8L3JlcGxhY2VhYmxl
PjwvdGVybT4KICAgICA8dGVybT48cmVwbGFjZWFibGUgY2xhc3M9InBhcmFt
ZXRlciI+cnVsZV9uYW1lPC9yZXBsYWNlYWJsZT48L3Rlcm0+CiAgICAgPHRl
cm0+PHJlcGxhY2VhYmxlIGNsYXNzPSJwYXJhbWV0ZXIiPnRyaWdnZXJfbmFt
ZTwvcmVwbGFjZWFibGU+PC90ZXJtPgogICAgIDxsaXN0aXRlbT4KQEAgLTEz
Myw5ICsxMzUsOSBAQCBDT01NRU5UIE9OCiAgICAgPHRlcm0+PHJlcGxhY2Vh
YmxlIGNsYXNzPSJwYXJhbWV0ZXIiPmRvbWFpbl9uYW1lPC9yZXBsYWNlYWJs
ZT48L3Rlcm0+CiAgICAgPGxpc3RpdGVtPgogICAgICA8cGFyYT4KLSAgICAg
IFdoZW4gY3JlYXRpbmcgYSBjb21tZW50IG9uIGEgY29uc3RyYWludCBvbiBh
IHRhYmxlIG9yIGEgZG9tYWluLCB0aGVzZQotICAgICAgcGFyYW1ldGVycyBz
cGVjaWZ5IHRoZSBuYW1lIG9mIHRoZSB0YWJsZSBvciBkb21haW4gb24gd2hp
Y2ggdGhlCi0gICAgICBjb25zdHJhaW50IGlzIGRlZmluZWQuCisgICAgICBX
aGVuIGNyZWF0aW5nIGEgY29tbWVudCBvbiBhIGNvbnN0cmFpbnQsIGEgdGFi
bGUsIGEgZG9tYWluIG9yCisgICAgICBhIHBvbGljeSB0aGVzZSBwYXJhbWV0
ZXJzIHNwZWNpZnkgdGhlIG5hbWUgb2YgdGhlIHRhYmxlIG9yIGRvbWFpbiBv
bgorICAgICAgd2hpY2ggdGhlIGNvbnN0cmFpbnQgaXMgZGVmaW5lZC4KICAg
ICAgPC9wYXJhPgogICAgIDwvbGlzdGl0ZW0+CiAgICA8L3Zhcmxpc3RlbnRy
eT4KQEAgLTMxNSw2ICszMTcsNyBAQCBDT01NRU5UIE9OIE9QRVJBVE9SIF4g
KHRleHQsIHRleHQpIElTICdQZXJmb3JtcyBpbnRlcnNlY3Rpb24gb2YgdHdv
IHRleHRzJzsKIENPTU1FTlQgT04gT1BFUkFUT1IgLSAoTk9ORSwgaW50ZWdl
cikgSVMgJ1VuYXJ5IG1pbnVzJzsKIENPTU1FTlQgT04gT1BFUkFUT1IgQ0xB
U1MgaW50NG9wcyBVU0lORyBidHJlZSBJUyAnNCBieXRlIGludGVnZXIgb3Bl
cmF0b3JzIGZvciBidHJlZXMnOwogQ09NTUVOVCBPTiBPUEVSQVRPUiBGQU1J
TFkgaW50ZWdlcl9vcHMgVVNJTkcgYnRyZWUgSVMgJ2FsbCBpbnRlZ2VyIG9w
ZXJhdG9ycyBmb3IgYnRyZWVzJzsKK0NPTU1FTlQgT04gUE9MSUNZIG15X3Bv
bGljeSBPTiBteXRhYmxlIElTICdGaWx0ZXIgcm93cyBieSB1c2Vycyc7CiBD
T01NRU5UIE9OIFJPTEUgbXlfcm9sZSBJUyAnQWRtaW5pc3RyYXRpb24gZ3Jv
dXAgZm9yIGZpbmFuY2UgdGFibGVzJzsKIENPTU1FTlQgT04gUlVMRSBteV9y
dWxlIE9OIG15X3RhYmxlIElTICdMb2dzIHVwZGF0ZXMgb2YgZW1wbG95ZWUg
cmVjb3Jkcyc7CiBDT01NRU5UIE9OIFNDSEVNQSBteV9zY2hlbWEgSVMgJ0Rl
cGFydG1lbnRhbCBkYXRhJzsKLS0gCjEuOS4xCgo=

--------------070606020503080404090206
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------070606020503080404090206--