Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-docs-owner+M8437=pgsql+2Ddocs=arkaria.postgresql.org@postgresql.org>)
 id 1Zyckz-0002og-5j
 for pgsql-docs@arkaria.postgresql.org; Tue, 17 Nov 2015 09:40:57 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.84) (envelope-from
 <pgsql-docs-owner+M8437=pgsql+2Ddocs=arkaria.postgresql.org@postgresql.org>)
 id 1Zycky-0003ZN-J8
 for pgsql-docs@arkaria.postgresql.org; Tue, 17 Nov 2015 09:40:56 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
 by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
 (Exim 4.84) (envelope-from <a.lubennikova@postgrespro.ru>)
 id 1Zyckx-0003Yq-M7
 for pgsql-docs@postgresql.org; Tue, 17 Nov 2015 09:40:55 +0000
Received: from newmail.postgrespro.ru ([93.174.131.138]
 helo=mail.postgrespro.ru)
 by makus.postgresql.org with esmtp (Exim 4.84)
 (envelope-from <a.lubennikova@postgrespro.ru>) id 1Zycku-0002A9-OW
 for pgsql-docs@postgresql.org; Tue, 17 Nov 2015 09:40:54 +0000
Received: from [192.168.27.79] (unknown [192.168.27.1])
 by mail.postgrespro.ru (Postfix) with ESMTPSA id 724CF21C4408
 for <pgsql-docs@postgresql.org>; Tue, 17 Nov 2015 12:40:50 +0300 (MSK)
Subject: Re: Minor addition to index documentation
To: pgsql-docs@postgresql.org
References: <5649F73E.7090505@postgrespro.ru>
 <20151116185919.GA614468@alvherre.pgsql>
From: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Message-ID: <564AF622.2090200@postgrespro.ru>
Date: Tue, 17 Nov 2015 12:40:50 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151116185919.GA614468@alvherre.pgsql>
Content-Type: multipart/mixed; boundary="------------050404000001030004080609"
X-Pg-Spam-Score: -2.5 (--)
List-Archive: <http://archives.postgresql.org/pgsql-docs>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-docs.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@postgresql.org>
List-Post: <mailto:pgsql-docs@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-docs>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-docs>
X-Mailing-List: pgsql-docs
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

This is a multi-part message in MIME format.
--------------050404000001030004080609
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit



16.11.2015 21:59, Alvaro Herrera:
> Anastasia Lubennikova wrote:
>> Fix incomplete gist interface description.
> Hi, thanks for the patch.
>
> I think this sentence is a bit confusing:
>
>>     <para>
>> -   GiST indexes require seven support functions, with an optional eighth, as
>> +   GiST indexes require seven support functions, with two optional, as
>>      shown in <xref linkend="xindex-gist-support-table">.
> The new text seems to say that one of the seven support funcs is
> optional, which is wrong if I correctly understand that the "fetch"
> optional function was added.
>
> Maybe "GiST indexes require nine support functions, two of which are
> optional, as shown in XYZ".
Yes, thank you for advice. I think it'll be more clear.

> This is to be backpatched as far back as commit d04c8ed9044ec, right?
Yes.

-- 
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


--------------050404000001030004080609
Content-Type: text/x-patch;
 name="gist_fetch_docs_update_1.0.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="gist_fetch_docs_update_1.0.patch"

diff --git a/doc/src/sgml/xindex.sgml b/doc/src/sgml/xindex.sgml
index 4fac018..4a8eb1b 100644
--- a/doc/src/sgml/xindex.sgml
+++ b/doc/src/sgml/xindex.sgml
@@ -416,7 +416,7 @@
    </table>
 
   <para>
-   GiST indexes require seven support functions, with an optional eighth, as
+   GiST indexes require nine support functions, two of which are optional, as
    shown in <xref linkend="xindex-gist-support-table">.
    (For more information see <xref linkend="GiST">.)
   </para>
@@ -477,6 +477,11 @@
        <entry>determine distance from key to query value (optional)</entry>
        <entry>8</entry>
       </row>
+      <row>
+       <entry><function>fetch</></entry>
+       <entry>compute original representation of a compressed key for index-only scans (optional)</entry>
+       <entry>9</entry>
+      </row>
      </tbody>
     </tgroup>
    </table>

--------------050404000001030004080609
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

--------------050404000001030004080609--