Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qLn8C-000hGj-G9 for pgsql-docs@arkaria.postgresql.org; Tue, 18 Jul 2023 16:00:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qLn8A-00AmCG-Vb for pgsql-docs@arkaria.postgresql.org; Tue, 18 Jul 2023 16:00:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qLn8A-00AmC8-OG for pgsql-docs@lists.postgresql.org; Tue, 18 Jul 2023 16:00:54 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qLn87-000AhP-3U for pgsql-docs@lists.postgresql.org; Tue, 18 Jul 2023 16:00:54 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 36IG0nDj056764; Tue, 18 Jul 2023 12:00:49 -0400 From: Tom Lane To: "David G. Johnston" cc: Curt Kolovson , pgsql-docs@lists.postgresql.org Subject: Re: Bug in documentation: https://www.postgresql.org/docs/current/spi-examples.html In-reply-to: References: <4124246.1689647806@sss.pgh.pa.us> <9F566B71-42A3-4502-85CA-076BA8C5BDD5@gmail.com> Comments: In-reply-to "David G. Johnston" message dated "Mon, 17 Jul 2023 20:13:41 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <56762.1689696049.1@sss.pgh.pa.us> Content-Transfer-Encoding: 8bit Date: Tue, 18 Jul 2023 12:00:49 -0400 Message-ID: <56763.1689696049@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk "David G. Johnston" writes: > On Mon, Jul 17, 2023 at 7:45 PM Curt Kolovson wrote: >> I’d vote for showing both (with RETURNING and without), since without it >> the second argument to SPI_exec has no effect in this example, which may >> not be obvious. That seems to be one of the subtle points illustrated by >> this example. > I concur: Agreed. Done at 137b131d6. regards, tom lane