Subject: Re: pg_monitor role description
To: pgsql-docs@lists.postgresql.org
References: <162149110071.26171.15811576640435665698@wrigleys.postgresql.org>
 <YKYJDXxnQ4hcUVYd@paquier.xyz>
 <CAOBaU_Y3b1Vet2UPDwjyi-pVv1wxT8fH4Fe4UKEZbZi6C-SGWQ@mail.gmail.com>
 <7018bb3a-26f1-a9be-1659-3bdafd122669@postgrespro.ru>
 <3690478.1621526623@sss.pgh.pa.us>
From: Pavel Luzanov <p.luzanov@postgrespro.ru>
Message-ID: <5692728c-f0f3-c888-e5e9-19efd4051198@postgrespro.ru>
Date: Thu, 20 May 2021 20:27:48 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <3690478.1621526623@sss.pgh.pa.us>
Content-Type: multipart/alternative;
 boundary="------------A008498F8B15DE4016CF94F2"
Content-Language: en-US
Archived-At: 
 <https://www.postgresql.org/message-id/5692728c-f0f3-c888-e5e9-19efd4051198%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------A008498F8B15DE4016CF94F2
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

Hello,

On 20.05.2021 19:03, Tom Lane wrote:

> Pavel Luzanov <p.luzanov@postgrespro.ru> writes:
>> Let me try one more time.
>> What is correct from the English language point of view:
>> 1. Julien Rouhaud is a member of PostgreSQL Community.
>> or
>> 2. PostgreSQL Community is a member of Julien Rouhaud, Michael Paquier.
>> Or both forms are correct?
>> I think that 1 is correct.
> You're right about that ...

So, is it correct to change description of pg_monitor role from:

"Read/execute various monitoring views and functions. This role is a member of|pg_read_all_settings|,|pg_read_all_stats|  and|pg_stat_scan_tables|."

to

"Read/execute various monitoring views and functions. The roles pg_read_all_settings, pg_read_all_stats and pg_stat_scan_tables are members of this role."

I can prepare a simple patch.

>> And column header in a \du output must be something like 'members' instead of 'member of'.
> ... but this does not follow, because it's a poor analogy.  "Member of"
> means "these role(s) have been GRANT'ed to pg_monitor".

Yes, I understood this point and agree.


-- 
Pavel Luzanov
Postgres Professional: https://postgrespro.com
The Russian Postgres Company


--------------A008498F8B15DE4016CF94F2
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <pre>Hello,</pre>
    <div class="moz-cite-prefix">
      <pre>On 20.05.2021 19:03, Tom Lane wrote:</pre>
    </div>
    <blockquote type="cite" cite="mid:3690478.1621526623@sss.pgh.pa.us">
      <pre class="moz-quote-pre" wrap="">Pavel Luzanov <a class="moz-txt-link-rfc2396E" href="mailto:p.luzanov@postgrespro.ru">&lt;p.luzanov@postgrespro.ru&gt;</a> writes:
</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">Let me try one more time.
What is correct from the English language point of view:
1. Julien Rouhaud is a member of PostgreSQL Community.
or
2. PostgreSQL Community is a member of Julien Rouhaud, Michael Paquier.
Or both forms are correct?
I think that 1 is correct.
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
You're right about that ...</pre>
    </blockquote>
    <pre>
</pre>
    <pre>So, is it correct to change description of pg_monitor role from:</pre>
    <pre>"Read/execute various monitoring views and functions. This role is a member of <code class="literal">pg_read_all_settings</code>, <code class="literal">pg_read_all_stats</code> and <code class="literal">pg_stat_scan_tables</code>."</pre>
    <pre>to</pre>
    <pre>"Read/execute various monitoring views and functions. The roles pg_read_all_settings, pg_read_all_stats and pg_stat_scan_tables are members of this role."

I can prepare a simple patch.
</pre>
    <pre class="moz-quote-pre" wrap="">
</pre>
    <blockquote type="cite" cite="mid:3690478.1621526623@sss.pgh.pa.us">
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">And column header in a \du output must be something like 'members' instead of 'member of'.
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
... but this does not follow, because it's a poor analogy.  "Member of"
means "these role(s) have been GRANT'ed to pg_monitor".</pre>
    </blockquote>
    <pre>
Yes, I understood this point and agree.
</pre>
    <br>
    <pre class="moz-signature" cols="72">-- 
Pavel Luzanov
Postgres Professional: <a class="moz-txt-link-freetext" href="https://postgrespro.com">https://postgrespro.com</a>
The Russian Postgres Company</pre>
  </body>
</html>

--------------A008498F8B15DE4016CF94F2--