Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1XJQmG-0000aO-Tb for pgsql-docs@arkaria.postgresql.org; Mon, 18 Aug 2014 17:31:29 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1XJQmG-0005Fj-DI for pgsql-docs@arkaria.postgresql.org; Mon, 18 Aug 2014 17:31:28 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1XJQmF-0005Fc-EX for pgsql-docs@postgresql.org; Mon, 18 Aug 2014 17:31:27 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1XJQm7-0000fr-Ud for pgsql-docs@postgresql.org; Mon, 18 Aug 2014 17:31:25 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id s7IHVCD6005719; Mon, 18 Aug 2014 13:31:12 -0400 From: Tom Lane To: Josh Berkus cc: Magnus Hagander , Kevin Grittner , Peter Eisentraut , MauMau , "pgsql-docs@postgresql.org" Subject: Re: Sample archive_command is still problematic In-reply-to: <53F233E1.3030605@agliodbs.com> References: <53E5603B.5040102@agliodbs.com> <1407777686.41146.YahooMailNeo@web122306.mail.ne1.yahoo.com> <0F73426A2EA544878BCAC33BB989D671@maumau> <53EBCCEA.3090604@gmx.net> <1407965034.12878.YahooMailNeo@web122304.mail.ne1.yahoo.com> <53F233E1.3030605@agliodbs.com> Comments: In-reply-to Josh Berkus message dated "Mon, 18 Aug 2014 10:12:01 -0700" Date: Mon, 18 Aug 2014 13:31:12 -0400 Message-ID: <5718.1408383072@sss.pgh.pa.us> X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-docs Precedence: bulk Sender: pgsql-docs-owner@postgresql.org Josh Berkus writes: > 2) One reason users are using the "test -f" version of the archive > command is that we put it in the same postgresql.conf. I would suggest > that we don't put *any* archive command in the sample postgresql.conf, > since there is no command we can supply which isn't a potential foot-gun. If you want to remove the last line of this: #archive_command = '' # command to use to archive a logfile segment # placeholders: %p = path of file to archive # %f = file name only # e.g. 'test ! -f /mnt/server/archivedir/%f && cp %p /mnt/server/archivedir/%f' I'm okay with that. But if you want to remove the sample command from the SGML docs I'm going to push back a bit harder... regards, tom lane -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs