Subject: Re: Some minor error fixes
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
 "pgsql-docs@postgresql.org" <pgsql-docs@postgresql.org>
References: <571470D8.50907@gmail.com>
 <88f42cdc-48fe-aeb9-60e7-e27587621a55@2ndquadrant.com>
 <572A09ED.8050204@gmail.com>
 <e6d74d55-3c62-4782-9055-5767564a5220@2ndquadrant.com>
From: Alexander Law <exclusion@gmail.com>
Message-ID: <572A47DB.60304@gmail.com>
Date: Wed, 4 May 2016 22:04:59 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <e6d74d55-3c62-4782-9055-5767564a5220@2ndquadrant.com>
Content-Type: multipart/mixed;
 boundary="------------020706000507000009030101"
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

This is a multi-part message in MIME format.
--------------020706000507000009030101
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

Thank you!
I have some more errors written down, maybe they are worth fixing too.

Second patch is for consistency in [1].
(I think XMLValidate could be aligned with "IS VALID predicate")
Third patch is for language name teared down in [1].
It seems that root of this typo is as far as in SQL Standard (see M015 
description in [2]), but IMO it should be fixed anyway.

[1] 
http://www.postgresql.org/docs/9.5/static/unsupported-features-sql-standard.html
[2] 
http://jtc1sc32.org/doc/N1501-1550/32N1529T-text%20for%20FCD%209075-9.pdf


04.05.2016 21:11, Peter Eisentraut пишет:
> On 5/4/16 10:40 AM, Alexander Law wrote:
>> Please have a look at the some more errors.
>> Regarding second patch, I think, that inconsistency should be fixed by
>> omitting '_name', as this parameter could also include a password.
>
> fixed
>


--------------020706000507000009030101
Content-Type: text/x-patch;
 name="1-fix-gin-typo.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="1-fix-gin-typo.patch"

diff --git a/doc/src/sgml/gin.sgml b/doc/src/sgml/gin.sgml
index a392f94..b805af5 100644
--- a/doc/src/sgml/gin.sgml
+++ b/doc/src/sgml/gin.sgml
@@ -539,7 +539,7 @@
        <function>extractQuery</> to pass additional data to the
        <function>consistent</> and <function>comparePartial</> methods.
        To use it, <function>extractQuery</> must allocate
-       an array of <literal>*nkeys</> Pointers and store its address at
+       an array of <literal>*nkeys</> pointers and store its address at
        <literal>*extra_data</>, then store whatever it wants to into the
        individual pointers.  The variable is initialized to <symbol>NULL</symbol> before
        call, so this argument can simply be ignored by operator classes that

--------------020706000507000009030101
Content-Type: text/x-patch;
 name="2-sql-features-improve-consistency.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="2-sql-features-improve-consistency.patch"

diff --git a/src/backend/catalog/sql_features.txt b/src/backend/catalog/sql_features.txt
index fd9e78d..71c08af 100644
--- a/src/backend/catalog/sql_features.txt
+++ b/src/backend/catalog/sql_features.txt
@@ -656,10 +656,10 @@ X271	XMLValidate: data-driven case			NO
 X272	XMLValidate: ACCORDING TO clause			NO	
 X273	XMLValidate: ELEMENT clause			NO	
 X274	XMLValidate: schema location			NO	
-X281	XMLValidate: with DOCUMENT option			NO	
+X281	XMLValidate with DOCUMENT option			NO	
 X282	XMLValidate with CONTENT option			NO	
 X283	XMLValidate with SEQUENCE option			NO	
-X284	XMLValidate NAMESPACE without ELEMENT clause			NO	
+X284	XMLValidate: NAMESPACE without ELEMENT clause			NO	
 X286	XMLValidate: NO NAMESPACE with ELEMENT clause			NO	
 X300	XMLTable			NO	
 X301	XMLTable: derived column list option			NO	

--------------020706000507000009030101
Content-Type: text/x-patch;
 name="3-fix-m015-feature-description.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="3-fix-m015-feature-description.patch"

diff --git a/src/backend/catalog/sql_features.txt b/src/backend/catalog/sql_features.txt
index 71c08af..569a43f 100644
--- a/src/backend/catalog/sql_features.txt
+++ b/src/backend/catalog/sql_features.txt
@@ -520,7 +520,7 @@ M011	Datalinks via Ada			NO
 M012	Datalinks via C			NO	
 M013	Datalinks via COBOL			NO	
 M014	Datalinks via Fortran			NO	
-M015	Datalinks via M			NO	
+M015	Datalinks via MUMPS			NO	
 M016	Datalinks via Pascal			NO	
 M017	Datalinks via PL/I			NO	
 M018	Foreign data wrapper interface routines in Ada			NO	

--------------020706000507000009030101
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

--------------020706000507000009030101--