To: pgsql-docs@postgresql.org
Cc: andres@anarazel.de
From: Alexander Law <exclusion@gmail.com>
Subject: Invalid statement in ref/insert.sgml
Message-ID: <577FB72F.4040900@gmail.com>
Date: Fri, 8 Jul 2016 17:22:39 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------030203030905050004010100"
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

This is a multi-part message in MIME format.
--------------030203030905050004010100
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

Hello,

It seems, that the statement "INSERT ... ON CONFLICT DO UPDATE tab SET 
table_name.col = 1" is invalid in two ways. Patch attached.
Maybe it's worth to replace "UPDATE tab SET tab.col = 1" with "UPDATE 
table_name SET table_name.col = 1" in ref/update.sgml (for consistency) too.

Best regards,
Alexander


--------------030203030905050004010100
Content-Type: text/sgml;
 name="ref-insert-fix-example.sgml"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="ref-insert-fix-example.sgml"

diff --git a/doc/src/sgml/ref/insert.sgml b/doc/src/sgml/ref/insert.sgml
index e710cf4..0406a09 100644
--- a/doc/src/sgml/ref/insert.sgml
+++ b/doc/src/sgml/ref/insert.sgml
@@ -194,8 +194,8 @@ INSERT INTO <replaceable class="PARAMETER">table_name</replaceable> [ AS <replac
         column leaves the other fields null.)  When referencing a
         column with <literal>ON CONFLICT DO UPDATE</>, do not include
         the table's name in the specification of a target column.  For
-        example, <literal>INSERT ... ON CONFLICT DO UPDATE tab SET
-        table_name.col = 1</> is invalid (this follows the general
+        example, <literal>INSERT INTO table_name ... ON CONFLICT DO UPDATE
+        SET table_name.col = 1</> is invalid (this follows the general
         behavior for <command>UPDATE</>).
        </para>
       </listitem>

--------------030203030905050004010100
Content-Type: text/sgml;
 name="ref-update-better-example.sgml"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="ref-update-better-example.sgml"

diff --git a/doc/src/sgml/ref/update.sgml b/doc/src/sgml/ref/update.sgml
index 35b0699..c50434f 100644
--- a/doc/src/sgml/ref/update.sgml
+++ b/doc/src/sgml/ref/update.sgml
@@ -123,7 +123,7 @@ UPDATE [ ONLY ] <replaceable class="PARAMETER">table_name</replaceable> [ * ] [
       The column name can be qualified with a subfield name or array
       subscript, if needed.  Do not include the table's name in the
       specification of a target column &mdash; for example,
-      <literal>UPDATE tab SET tab.col = 1</> is invalid.
+      <literal>UPDATE table_name SET table_name.col = 1</> is invalid.
      </para>
     </listitem>
    </varlistentry>

--------------030203030905050004010100
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

--------------030203030905050004010100--