Message-ID: <57c6acf0d2936597184f6bc06f434c66eab07f49.camel@cybertec.at>
Subject: Re: small patch
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: rir <rirans@comcast.net>
Cc: pgsql-docs@lists.postgresql.org
Date: Fri, 08 Oct 2021 14:47:43 +0200
In-Reply-To: <20211007200612.rkxxgeorw6w4fpjp@localhost>
References: <20211001163938.ifg4ayrsjwd7r6zr@localhost>
	 <1c0eefa304434f67fd6a5a9d3f420d59ac74623a.camel@cybertec.at>
	 <20211007033905.pmsg5qnyqceepfva@localhost>
	 <9f703511c57d6bb0f44f9a968414869854ae50ea.camel@cybertec.at>
	 <20211007200612.rkxxgeorw6w4fpjp@localhost>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/57c6acf0d2936597184f6bc06f434c66eab07f49.camel%40cybertec.at>
Precedence: bulk

On Thu, 2021-10-07 at 16:06 -0400, rir wrote:
> > > > - we should retain "empty or one of", otherwise the following syntax
> > > >   would be undocumented:
> 
> For myself,
>    'FETCH [ <direction> [ FROM | IN ] ] <cursor_name>'
> clearly indicates that 'direction' is optional.

Yes, but since [ FROM | IN ] is inside the bracket, that
diagram would not account for "direction" being omitted
while retaining FROM.

So I suggest that you change the syntax diagram to

FETCH [ direction ] [ FROM | IN ] cursor_name

Then I agree that the "empty or" can be removed.
I think that would be a good idea, and it would add
clarity.

I remain of the opinion that the comments should be
retained, but we can leave that for somebody else to
decide.

Do you want to prepare a new patch and register it in
the commitfest?

Yours,
Laurenz Albe