Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1igw2T-0000sX-Mi for pgsql-docs@arkaria.postgresql.org; Mon, 16 Dec 2019 19:28:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1igw2R-00023n-Tu for pgsql-docs@arkaria.postgresql.org; Mon, 16 Dec 2019 19:28:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1igw2R-00023g-Lo for pgsql-docs@lists.postgresql.org; Mon, 16 Dec 2019 19:28:15 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1igw2K-0001N3-C4 for pgsql-docs@lists.postgresql.org; Mon, 16 Dec 2019 19:28:14 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id xBGJRwGb005878; Mon, 16 Dec 2019 14:27:59 -0500 From: Tom Lane To: Pavel Stehule cc: simon.dallaway@datacom.co.nz, pgsql-docs@lists.postgresql.org Subject: Re: Example 42.4. A PL/pgSQL Trigger Function for Auditing In-reply-to: References: <157644931740.18138.16968232991166819127@wrigleys.postgresql.org> Comments: In-reply-to Pavel Stehule message dated "Mon, 16 Dec 2019 12:25:34 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <5876.1576524478.1@sss.pgh.pa.us> Content-Transfer-Encoding: 8bit Date: Mon, 16 Dec 2019 14:27:58 -0500 Message-ID: <5877.1576524478@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Pavel Stehule writes: > po 16. 12. 2019 v 12:12 odesílatel PG Doc comments form < > noreply@postgresql.org> napsal: >> I'm wondering if it would be worthwhile to put a totally generic auditing >> function into the documentation e.g. >> [ snip ] > Just few points to this code I agree this code could have better style, but maybe that is just more evidence that a well-written example would be helpful? regards, tom lane