pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedsome re-formatting in xfunc.sgml
2+ messages / 2 participants
[nested] [flat]
* some re-formatting in xfunc.sgml
@ 2010-05-15 17:52 Erik Rijkers <er@xs4all.nl>
0 siblings, 1 reply; 2+ messages in thread
From: Erik Rijkers @ 2010-05-15 17:52 UTC (permalink / raw)
To: pgsql-docs
Attached some formatting improvements to xfunc.sgml
(1 typo; 2x wrap long code examples to make them readable in .pdf)
Erik Rijkers
Attachments:
xfunc.sgml.diff (text/x-patch, 1.6K) download
--- doc/src/sgml/xfunc.sgml.orig 2010-05-14 23:00:23.000000000 +0200
+++ doc/src/sgml/xfunc.sgml 2010-05-15 01:52:52.000000000 +0200
@@ -859,7 +859,8 @@
output parameters, like this:
<programlisting>
-CREATE FUNCTION sum_n_product_with_tab (x int, OUT sum int, OUT product int) RETURNS SETOF record AS $$
+CREATE FUNCTION sum_n_product_with_tab (x int, OUT sum int, OUT product int)
+RETURNS SETOF record AS $$
SELECT $1 + tab.y, $1 * tab.y FROM tab;
$$ LANGUAGE SQL;
</programlisting>
@@ -957,7 +958,8 @@
done this way:
<programlisting>
-CREATE FUNCTION sum_n_product_with_tab (x int) RETURNS TABLE(sum int, product int) AS $$
+CREATE FUNCTION sum_n_product_with_tab (x int)
+RETURNS TABLE(sum int, product int) AS $$
SELECT $1 + tab.y, $1 * tab.y FROM tab;
$$ LANGUAGE SQL;
</programlisting>
@@ -1026,7 +1028,8 @@
SELECT 1;
$$ LANGUAGE SQL;
ERROR: cannot determine result data type
-DETAIL: A function returning a polymorphic type must have at least one polymorphic argument.
+DETAIL: A function returning a polymorphic type must have
+ at least one polymorphic argument.
</screen>
</para>
@@ -2075,7 +2078,7 @@
<programlisting>
PG_FUNCTION_INFO_V1(funcname);
</programlisting>
- must appear in the same source file. (Conventionally. it's
+ must appear in the same source file. (Conventionally, it's
written just before the function itself.) This macro call is not
needed for <literal>internal</>-language functions, since
<productname>PostgreSQL</> assumes that all internal functions
* Re: some re-formatting in xfunc.sgml
@ 2010-05-16 04:37 Robert Haas <robertmhaas@gmail.com>
parent: Erik Rijkers <er@xs4all.nl>
0 siblings, 0 replies; 2+ messages in thread
From: Robert Haas @ 2010-05-16 04:37 UTC (permalink / raw)
To: Erik Rijkers <er@xs4all.nl>; +Cc: pgsql-docs
On Sat, May 15, 2010 at 1:52 PM, Erik Rijkers <er@xs4all.nl> wrote:
> Attached some formatting improvements to xfunc.sgml
>
> (1 typo; 2x wrap long code examples to make them readable in .pdf)
I applied this typo fix all the way back to 7.4, and the two changes
to the CREATE OR REPLACE function formatting to HEAD. I don't want to
break the error message, though, because (1) it breaks grepability for
that error message and (2) it'll look wrong in the HTML version of the
documentation. The formatting of CREATE OR REPLACE is somewhat
arbitrary and we have similar examples to your proposed formatting
elsewhere in the documentation, but the error message is what it is.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2010-05-16 04:37 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2010-05-15 17:52 some re-formatting in xfunc.sgml Erik Rijkers <er@xs4all.nl>
2010-05-16 04:37 ` Re: some re-formatting in xfunc.sgml Robert Haas <robertmhaas@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox