Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1jbUmR-0001C3-7e
	for pgsql-docs@arkaria.postgresql.org; Wed, 20 May 2020 19:53:31 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1jbUmO-0006AE-Nl
	for pgsql-docs@arkaria.postgresql.org; Wed, 20 May 2020 19:53:28 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jbUmO-0006A6-I0
	for pgsql-docs@lists.postgresql.org; Wed, 20 May 2020 19:53:28 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jbUmM-0000Mw-4F
	for pgsql-docs@lists.postgresql.org; Wed, 20 May 2020 19:53:28 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 04KJrNKr005998;
	Wed, 20 May 2020 15:53:23 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
cc: pgsql-docs@lists.postgresql.org
Subject: Re: descriptions of pg_stat_user_functions and pg_stat_slru
In-reply-to: <bd73f8fe-7a9f-d903-b84f-8410ba3e1d5f@oss.nttdata.com>
References: <6f8a482c-b3fa-4ed9-21c3-6d222a2cb87d@oss.nttdata.com>
 <23668.1589940341@sss.pgh.pa.us>
 <f31875d6-2300-87af-1479-c9d9abc013be@oss.nttdata.com>
 <19926.1589981558@sss.pgh.pa.us>
 <bd73f8fe-7a9f-d903-b84f-8410ba3e1d5f@oss.nttdata.com>
Comments: In-reply-to Fujii Masao <masao.fujii@oss.nttdata.com>
	message dated "Thu, 21 May 2020 03:26:27 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5995.1590004403.1@sss.pgh.pa.us>
Date: Wed, 20 May 2020 15:53:23 -0400
Message-ID: <5996.1590004403@sss.pgh.pa.us>
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Precedence: bulk

Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> On 2020/05/20 22:32, Tom Lane wrote:
>> OK by me --- that, too, would be more like the existing catalogs
>> chapter.

> Yeah, so I'd like to propose the attached patch.

Hmmm ... I'm not exactly convinced about sticking xreflabels onto
the <sect2>s as you've done here.  Presumably that would make <xref>s
render like "pg_stat_slru" not "Section 27.2.3", which I think is
not consistent with our practice elsewhere.  I'd be inclined to
leave the id attributes on the <table>s, and add xreflabels there
if we want them.

I see that catalogs.sgml doesn't really match either of those approaches,
though.  Not sure if we want to change it.  It looks like people have
tended to use <link> to substitute text for xref's to the catalog
sections, so maybe it would be better to add xreflabels there too
and simplify the references.

Other than that markup quibble, this looks fine to me.

> - 6644 | LWLock          | ProcArrayLock
> + 6644 | LWLock          | ProcArray

> I found "ProcArrayLock" is still used in monitoring.sgml though
> it was renamed to ProcArray. So the patch also includes the above change.

Ooops, my oversight.

			regards, tom lane