From: Daniel Gustafsson <daniel@yesql.se>
Message-Id: <5ABDB96A-B369-4954-AAE0-1354CBBB305F@yesql.se>
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_AF6C71AE-DAEE-4599-9D0E-F2DFCD6A8E91"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Subject: Re: Change pg_attribute textual link to an actual link
Date: Mon, 22 Oct 2018 12:09:41 +0200
In-Reply-To: <80062.1540164441@sss.pgh.pa.us>
Cc: pgsql-docs@lists.postgresql.org
To: Tom Lane <tgl@sss.pgh.pa.us>
References: <0E8748E3-8B7D-445E-9ABA-09DA5C7345CC@yesql.se>
 <80062.1540164441@sss.pgh.pa.us>
Precedence: bulk


--Apple-Mail=_AF6C71AE-DAEE-4599-9D0E-F2DFCD6A8E91
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

> On 22 Oct 2018, at 01:27, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> Daniel Gustafsson <daniel@yesql.se> writes:
>> In the System catalog/pg_attrdef documentation, there is a reference =
to
>> pg_attribute with the text "see below".  That makes sense in the PDF =
version
>> (and similar renderings), but in the web version it seems a bit odd =
as
>> pg_attribute is on the next page, not below.
>=20
>> The attached patch changes it to an actual link instead, but simply =
removing
>> the "see below" bit is another approach which isn't out of line with =
other
>> parts of the documentation (I opted for link since I personally =
prefer that).
>=20
> I agree with your change, but I wonder if the sentence after this one
> doesn't need some work too.  It seems to predate ALTER COLUMN SET =
DEFAULT.
> We could add a mention of that, or just stop trying to describe the
> preconditions, and say something like "only columns for which a =
default
> value has been explicitly set will have an entry here=E2=80=9D.

I think your latter suggestion pretty much covers all we need, so =
updated the
patch with that too.

cheers ./daniel


--Apple-Mail=_AF6C71AE-DAEE-4599-9D0E-F2DFCD6A8E91
Content-Disposition: attachment;
	filename=pg_attrdef_link-v2.patch
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="pg_attrdef_link-v2.patch"
Content-Transfer-Encoding: quoted-printable

=46rom=20984059ddae5f6009dcc3ff83a35843bf83a2091a=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20Daniel=20Gustafsson=20<daniel@yesql.se>=0A=
Date:=20Sun,=2021=20Oct=202018=2022:12:26=20+0200=0ASubject:=20[PATCH]=20=
Turn=20a=20textual=20reference=20into=20an=20actual=20link=0A=0AThe=20=
"see=20below"=20reference=20to=20pg_attribute=20in=20the=20pg_attrdef=20=
docs=20is=0Aa=20bit=20misleading=20in=20a=20web=20rendering,=20as=20=
there=20is=20no=20content=20below=20but=0Ainstead=20on=20another=20page.=20=
This=20changes=20the=20textual=20link=20into=20an=20actual=0Alink=20to=20=
it=20clearer.=20Also=20reword=20sentence=20describing=20which=20columns=20=
are=0Arepresented=20in=20the=20catalog.=0A---=0A=20=
doc/src/sgml/catalogs.sgml=20|=207=20+++----=0A=201=20file=20changed,=20=
3=20insertions(+),=204=20deletions(-)=0A=0Adiff=20--git=20=
a/doc/src/sgml/catalogs.sgml=20b/doc/src/sgml/catalogs.sgml=0Aindex=20=
6d6fbecd12..b02494be8a=20100644=0A---=20a/doc/src/sgml/catalogs.sgml=0A=
+++=20b/doc/src/sgml/catalogs.sgml=0A@@=20-902,10=20+902,9=20@@=0A=20=0A=20=
=20=20<para>=0A=20=20=20=20The=20catalog=20=
<structname>pg_attrdef</structname>=20stores=20column=20default=20=
values.=20=20The=20main=20information=0A-=20=20=20about=20columns=20is=20=
stored=20in=20<structname>pg_attribute</structname>=0A-=20=20=20(see=20=
below).=20=20Only=20columns=20that=20explicitly=20specify=20a=20default=20=
value=0A-=20=20=20(when=20the=20table=20is=20created=20or=20the=20column=20=
is=20added)=20will=20have=20an=0A-=20=20=20entry=20here.=0A+=20=20=20=
about=20columns=20is=20stored=20in=20<link=20=
linkend=3D"catalog-pg-attribute"><structname>pg_attribute</structname></li=
nk>.=0A+=20=20=20Only=20columns=20for=20which=20a=20default=20value=20=
has=20been=20explicitly=20set=20will=20have=0A+=20=20=20an=20entry=20=
here.=0A=20=20=20</para>=0A=20=0A=20=20=20<table>=0A--=20=0A=
2.14.1.145.gb3622a4ee=0A=0A=

--Apple-Mail=_AF6C71AE-DAEE-4599-9D0E-F2DFCD6A8E91--