Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gD4ZB-00059u-S2 for pgsql-docs@arkaria.postgresql.org; Thu, 18 Oct 2018 09:26:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gD4Z7-0004ph-Ql for pgsql-docs@arkaria.postgresql.org; Thu, 18 Oct 2018 09:26:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gD4Z7-0004pa-Kt for pgsql-docs@lists.postgresql.org; Thu, 18 Oct 2018 09:26:01 +0000 Received: from smtp.outgoing.loopia.se ([194.9.95.112]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gD4Z5-0002iT-Gz for pgsql-docs@lists.postgresql.org; Thu, 18 Oct 2018 09:26:01 +0000 Received: from s554.loopia.se (localhost [127.0.0.1]) by s554.loopia.se (Postfix) with ESMTP id DCD361F166AF for ; Thu, 18 Oct 2018 11:25:57 +0200 (CEST) Received: from s500.loopia.se (unknown [172.21.200.98]) by s554.loopia.se (Postfix) with ESMTP id BE5D5795463 for ; Thu, 18 Oct 2018 11:25:57 +0200 (CEST) Received: from s405.loopia.se (unknown [172.21.200.105]) by s500.loopia.se (Postfix) with ESMTP id BB92DCE67DA for ; Thu, 18 Oct 2018 11:25:57 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s498.loopia.se ([172.21.200.105]) by s405.loopia.se (s405.loopia.se [172.21.200.135]) (amavisd-new, port 10024) with LMTP id N0X1geQQgY9T for ; Thu, 18 Oct 2018 11:25:57 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 85.228.38.16 Received: from [192.168.1.73] (c-1026e455.027-294-73746f71.bbcust.telenor.se [85.228.38.16]) (Authenticated sender: daniel@yesql.se) by s498.loopia.se (Postfix) with ESMTPSA id 50CFD44E455 for ; Thu, 18 Oct 2018 11:25:57 +0200 (CEST) From: Daniel Gustafsson Content-Type: multipart/mixed; boundary="Apple-Mail=_4759A4F2-D84B-4C32-A9D7-15AB64DB8F67" Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Improve wording for FDW header file reference Message-Id: <5E9F20B9-5F76-4B26-B5B6-D4B8B89BD503@yesql.se> Date: Thu, 18 Oct 2018 11:25:56 +0200 To: pgsql-docs@lists.postgresql.org X-Mailer: Apple Mail (2.3445.9.1) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --Apple-Mail=_4759A4F2-D84B-4C32-A9D7-15AB64DB8F67 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 The "Foreign Data Wrapper Callback Routines=E2=80=9D section contains an = odd wording in the reference to the relevant headerfile: "The FdwRoutine struct type is declared in src/include/foreign/fdwapi.h, which see for additional = details.=E2=80=9D The attached patch is an attempt at improving this. cheers ./daniel --Apple-Mail=_4759A4F2-D84B-4C32-A9D7-15AB64DB8F67 Content-Disposition: attachment; filename=fdwapi_wording.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="fdwapi_wording.patch" Content-Transfer-Encoding: quoted-printable =46rom=20fce56285540ee3b0565b84d6ce93b36c894ddfd5=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Daniel=20Gustafsson=20=0A= Date:=20Thu,=2018=20Oct=202018=2010:51:20=20+0200=0ASubject:=20[PATCH]=20= docs:=20Improve=20wording=20for=20referring=20to=20header=20file=0A=0A= Commit=2021734d2fb896e0ecdddd3251caa72a3576e2d415=20introduced=20an=20= odd=0Awording=20for=20referring=20to=20the=20header=20file=20for=20= further=20details.=0A---=0A=20doc/src/sgml/fdwhandler.sgml=20|=204=20= ++--=0A=201=20file=20changed,=202=20insertions(+),=202=20deletions(-)=0A=0A= diff=20--git=20a/doc/src/sgml/fdwhandler.sgml=20= b/doc/src/sgml/fdwhandler.sgml=0Aindex=204ce88dd77c..34fa2b3089=20100644=0A= ---=20a/doc/src/sgml/fdwhandler.sgml=0A+++=20= b/doc/src/sgml/fdwhandler.sgml=0A@@=20-91,8=20+91,8=20@@=0A=20=0A=20=20=20= =20=20=0A=20=20=20=20=20=20The=20= FdwRoutine=20struct=20type=20is=20declared=20in=0A= -=20=20=20=20=20src/include/foreign/fdwapi.h,=20= which=20see=20for=20additional=0A-=20=20=20=20=20details.=0A+=20=20=20=20= =20src/include/foreign/fdwapi.h,=20which=20contains=0A= +=20=20=20=20=20additional=20details=20on=20the=20struct=20members.=0A=20= =20=20=20=20=0A=20=0A=20=20=20=20=0A--=20=0A2.14.1.145.gb3622a4ee=0A=0A= --Apple-Mail=_4759A4F2-D84B-4C32-A9D7-15AB64DB8F67--