From: Daniel Gustafsson <daniel@yesql.se>
Content-Type: multipart/mixed;
 boundary="Apple-Mail=_F37D263A-6E5A-45AA-AB93-F0EBF3CCC698"
Subject: Documentation on Streaming Replication interface for Logical Decoding
Message-Id: <5F0285CB-3926-4DF7-9DE0-CEEBC1DE3AEB@yesql.se>
Date: Mon, 9 Nov 2015 23:40:27 +0100
To: pgsql-docs@postgresql.org
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\))
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org


--Apple-Mail=_F37D263A-6E5A-45AA-AB93-F0EBF3CCC698
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

In section 46.3 (Streaming Replication Protocol Interface) the create comma=
nd
for logical slots, CREATE_REPLICATION_SLOT, is defined as taking =E2=80=9Co=
ptions=E2=80=9D
after the LOGICAL keyword when it in fact requires the plugin name.  The st=
art
command is correctly listing the options but isn=E2=80=99t listing the requ=
ired start
position.

The attached patch synchronizes these command signatures with the more deta=
iled
descriptions in section 50.3* (Streaming Replication Protocol).

	cheers ./daniel

(*) Section number from the 9.5beta1 manual


--Apple-Mail=_F37D263A-6E5A-45AA-AB93-F0EBF3CCC698
Content-Disposition: attachment;
	filename=log_dec_doc.diff
Content-Type: application/octet-stream; x-unix-mode=0644;
 name="log_dec_doc.diff"
Content-Transfer-Encoding: 7bit

diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml
index 02794cc..01626aa 100644
--- a/doc/src/sgml/logicaldecoding.sgml
+++ b/doc/src/sgml/logicaldecoding.sgml
@@ -280,7 +280,7 @@ $ pg_recvlogical -d postgres --slot test --drop-slot
     The commands
     <itemizedlist>
      <listitem>
-      <para><literal>CREATE_REPLICATION_SLOT <replaceable>slot_name</replaceable> LOGICAL <replaceable>options</replaceable></literal></para>
+      <para><literal>CREATE_REPLICATION_SLOT <replaceable>slot_name</replaceable> LOGICAL <replaceable>output_plugin</replaceable></literal></para>
      </listitem>
 
      <listitem>
@@ -288,7 +288,7 @@ $ pg_recvlogical -d postgres --slot test --drop-slot
      </listitem>
 
      <listitem>
-      <para><literal>START_REPLICATION SLOT <replaceable>slot_name</replaceable> LOGICAL <replaceable>options</replaceable></literal></para>
+      <para><literal>START_REPLICATION SLOT <replaceable>slot_name</replaceable> LOGICAL <replaceable>XXX/XXX</replaceable> <replaceable>[ plugin_options ]</replaceable></literal></para>
      </listitem>
     </itemizedlist>
     are used to create, drop, and stream changes from a replication

--Apple-Mail=_F37D263A-6E5A-45AA-AB93-F0EBF3CCC698
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

--Apple-Mail=_F37D263A-6E5A-45AA-AB93-F0EBF3CCC698--