Date: Mon, 10 Nov 2025 04:40:25 +0100
From: Erik Wienhold <ewie@ewie.name>
To: jian he <jian.universality@gmail.com>
Cc: David Rowley <dgrowleyml@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Bruce Momjian <bruce@momjian.us>, Nathan Bossart <nathandbossart@gmail.com>,
	Euler Taveira <euler@eulerto.com>, pgsql-docs@lists.postgresql.org
Subject: Re: Use uppercase keywords in foreign key tutorial
Message-ID: <5b870856-1ff9-4776-97ba-f568eb5cbd2f@ewie.name>
References: 
 <CAApHDvqR+_EU0mxrmS-AieE_8ovqtmnsJSOk-oq-Rdk3JzNWOg@mail.gmail.com>
 <0a68a965-4599-4af1-a1eb-bd8e1be75788@ewie.name>
 <CAApHDvoqh_K2KTocwWYrGw5vLubnPnTzd1SvYTTonQ=vUXP7Ug@mail.gmail.com>
 <32882add-b671-42db-a041-e2c2c5b7c315@ewie.name>
 <CAApHDvraaZLdTm4XTLkgGhUwecpmNm1dOJMcEToak-Bh5742hQ@mail.gmail.com>
 <4487a138-c4d2-4b06-80b3-5afe7f8e5d82@ewie.name>
 <CAApHDvqSiqmZbdDpZ_JhL5TbXNvKCLt1-Wk5j=4uRPoV0hd9hQ@mail.gmail.com>
 <971a5a3d-c200-4700-824b-f71a6e831994@ewie.name>
 <CAApHDvokYxXGORORfF_uP2PbaF-UagV-m3yySOfjzuqrVmWkCg@mail.gmail.com>
 <CACJufxG5UaQtoYFQKdMCYjpz_5Kggvdgm1gVEW4sNEa_W__FKA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="qpmbew54ltvavodr"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CACJufxG5UaQtoYFQKdMCYjpz_5Kggvdgm1gVEW4sNEa_W__FKA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/5b870856-1ff9-4776-97ba-f568eb5cbd2f%40ewie.name>
Precedence: bulk


--qpmbew54ltvavodr
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On 2025-11-10 04:15 +0100, jian he wrote:
> On Thu, Nov 6, 2025 at 11:06 AM David Rowley <dgrowleyml@gmail.com> wrote:
> >
> > I reviewed this and double checked you left "uPDaTE" in [1]. Found no
> > issues, so pushed.
> >
> 
> in doc/src/sgml/func/func-matching.sgml
> 
> <synopsis>
> substring(<replaceable>string</replaceable> similar
> <replaceable>pattern</replaceable> escape
> <replaceable>escape-character</replaceable>)
> </synopsis>
>     or using the now obsolete SQL:1999 syntax:
> <synopsis>
> substring(<replaceable>string</replaceable> from
> <replaceable>pattern</replaceable> for
> <replaceable>escape-character</replaceable>)
> </synopsis>
>     or as a plain three-argument function:
> <synopsis>
> substring(<replaceable>string</replaceable>,
> <replaceable>pattern</replaceable>,
> <replaceable>escape-character</replaceable>)
> </synopsis>
> 
> key word: "similar", "escape", "from", "for" within the above synopsis
> section need uppercase too?

Thanks, good catch.  Not surprised that I've missed those because it
already took me a couple of rounds to find everything that's in the
previous patch.  Here's another patch.

-- 
Erik Wienhold

--qpmbew54ltvavodr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="upcase-keywords-in-func-matching.patch"

diff --git a/doc/src/sgml/func/func-matching.sgml b/doc/src/sgml/func/func-matching.sgml
index 91a0b7ca0de..f466860ddb0 100644
--- a/doc/src/sgml/func/func-matching.sgml
+++ b/doc/src/sgml/func/func-matching.sgml
@@ -369,11 +369,11 @@
     regular expression pattern.  The function can be written according
     to standard SQL syntax:
 <synopsis>
-substring(<replaceable>string</replaceable> similar <replaceable>pattern</replaceable> escape <replaceable>escape-character</replaceable>)
+substring(<replaceable>string</replaceable> SIMILAR <replaceable>pattern</replaceable> ESCAPE <replaceable>escape-character</replaceable>)
 </synopsis>
     or using the now obsolete SQL:1999 syntax:
 <synopsis>
-substring(<replaceable>string</replaceable> from <replaceable>pattern</replaceable> for <replaceable>escape-character</replaceable>)
+substring(<replaceable>string</replaceable> FROM <replaceable>pattern</replaceable> FOR <replaceable>escape-character</replaceable>)
 </synopsis>
     or as a plain three-argument function:
 <synopsis>

--qpmbew54ltvavodr--