Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xEShH-0000000179J-3eCs for pgsql-docs@arkaria.postgresql.org; Wed, 07 Oct 2026 14:32:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xEShF-00000006zlH-2ou9 for pgsql-docs@arkaria.postgresql.org; Wed, 07 Oct 2026 14:32:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xEShF-00000006zl9-1hls for pgsql-docs@lists.postgresql.org; Wed, 07 Oct 2026 14:32:41 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1xEShC-00000000tsB-3sIE for pgsql-docs@lists.postgresql.org; Wed, 07 Oct 2026 14:32:40 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-4a01933b584so17398525e9.0 for ; Wed, 07 Oct 2026 07:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec.at; s=google; t=1791383556; x=1791988356; darn=lists.postgresql.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:to:from:subject:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=al844VOjuggVQMt9RHhDzZmvkCSgzsEBjicoWUH44bY=; b=XHXTsKNHIVDrJ/BSJi3wXFMEgveJC+4DydjSqCNVXK4IRwKiZPq04Vxk3R9qZB84SO EyGYxBu8qOc5cIWfREOi79FLkB+lnul0yYCcyeAo34EUzb/tkwT4YUCTrOC0aHlpnQf6 NkmurvS8xW3hCSwStm5vnXOP+pm+2aD+/66DmpJ15/lyJjPc+Kdh7RLOpav809f31zn7 U2t1MBkdOe4ss+lO7wdlTu3Z20p47UFl1EcNxS0s82JmbVWngZSLQyV4BDc1x7WrD9I0 E2MlBT+c2Rx845doNIddEA4C3cFGYxSy2q0wJt3eZmtepl1hMfuzDBqGQwlaK8zJY1Qm iv1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791383556; x=1791988356; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=al844VOjuggVQMt9RHhDzZmvkCSgzsEBjicoWUH44bY=; b=lShfUp+yhJtHXgbTZfrSWWvoagvVca4MMa7UOmp8YRKuYNXsl88Sb32VSYwJd+L2uF boSWPPsnc/cDSHsVnCwTNPzki4k1rhgDP+5WMiBLiboPgUpvnrq7oxDx6y9WHdNkhMEa JRW36wR9NMeE9qm3/YbYgWiHuACaXm1A6LZHf8xClxItUXow9g4kUYY1octPXWEnXNqZ VMXCrHluNilJv2X+Q5R/vi9Zkg4ohh265gEe8Fq+ixRBdnCLlgNsbgpgylHYfmTPmGbZ AXUahvr7vKWrwz61TL6KXLs4X0FIcR61soFM2F1t5D3H62sXk5YcED5+5oycnlL/klgT g06A== X-Forwarded-Encrypted: i=1; AKwUvBwxvaJvpVBxlv1suR0azi4cYdCHq0IAp3w0qKdzDBN/WpHD01w+w2OvTvDJ97BWCROLpaOAFn5NHwox@lists.postgresql.org X-Gm-Message-State: AFuF++l0bvt5YE473SesMr+vFEoqBtkp2yfmZ6AtK4K59m6anMuVVQgj HqknwWhSLsGpDdOadAEc9ZVwEKzlfDmgCrKq9c1KGTf0tZLg1Z2AVcQGdCSNzIGb1jE= X-Gm-Gg: AYBFou3aNICDmG248wbqj51iwKXieg2ILR6GNmsNozYGOJ0AUMfJF4piaXZVn+uMKLZ 9UuG3pC21GgDsrIso7rlThJRMZC+tmrkCh5BBLZWHkDh5Kx6Iru30rwBVY4HSHLq/gUn6AJ8jZm ZjxdUwfuf7oo5VO4D3F5GHkyCrj0cOy9UhBu5GM0kbht0OnHHVZiklqHN7+MvODwd9TkuVVQ4ky SMSPiIGuRs1NOPbC9QjvHaZ9mi6Wqt0WUoKvETVFHq9QYZxZA+RPln0ll32FjLBUJ8uRkBskjWz 1edoqOAhS+zuclwgZsjFUZEwTR4KEz6wNixVf333c6ysCUltFfur5pjj323xsXzGoqBTlHb/ytC At7Lkcy4CNVIBEs9s5o5e/3IwtZRqiFUY5a7ARHp1hU9CpkuagWbbwSlNlLGRfZadr/UsbOoc76 jqstngpkBakTpnheyjJCL7fktl+f8eIxCwmRoWwgB0+LW4jHkXwbIB/SC9OwIA2fpXUCqUPR5lg loBGFTmykC41uX7mFTBpZ1t3qyI X-Received: by 2002:a05:600c:3f12:b0:4a1:698d:3042 with SMTP id 5b1f17b1804b1-4a1803113d3mr38681385e9.6.1791383555913; Wed, 07 Oct 2026 07:32:35 -0700 (PDT) Received: from laurenz.albe-K4N0CV00F97414D ([2001:871:70:8908:76b2:26ac:3777:7531]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a17f557bcbsm110638075e9.9.2026.10.07.07.32.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2026 07:32:35 -0700 (PDT) Message-ID: <5e6ffc6412da6fb68718a4c123e875f8d423dcad.camel@cybertec.at> Subject: Re: Fixes for create subscription page From: Laurenz Albe To: Thom Brown , pgsql-docs@lists.postgresql.org Date: Wed, 07 Oct 2026 16:32:34 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-2.fc44) MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, 2026-10-07 at 11:58 +0100, Thom Brown wrote: > I was looking through the new options for create subscription, and > found issues with some of the text, so I reviewed the whole page. > Attached are my proposed changes. Thanks! I agree with most of your changes, but have doubts about a few: > --- a/doc/src/sgml/ref/create_subscription.sgml > +++ b/doc/src/sgml/ref/create_subscription.sgml > > Since no connection is made when this option is > - false, no tables and sequences are subscrib= ed. To > + false, no tables or sequences are subscribe= d. To Hm. I think "and" would be the better conjunction here (although "or" is not really wrong). > send and receive functions will be transferred in binary. Note= that > the initial synchronization requires all data types to have bi= nary > - send and receive functions, otherwise the synchronization will= fail > + send and receive functions, otherwise synchronization will fai= l > (see for more about send/re= ceive > functions). This parameter has no effect for sequences. My feeling is that the article is correct here (disclaimer: I am not a native speaker). > - overall system performance. This option provides minimal perf= ormance > + overall system performance. This option incurs minimal perfor= mance > overhead when applied appropriately. The following scenarios = illustrate I see your point, although you could argue that "minimal performance overhe= ad" is a feature, and you provide a feature rather than incur it. How about "provides reduced performance overhead"? > c. Read-Only Subscribers: > In configurations involving single or multiple publisher node= s > performing concurrent write operations, read-only subscriber = nodes may > - replicate changes without seeing a performance impact if it d= oes index > - scan. However, if the subscriber is impacted due to replicati= on lag or > - scan performance (say due to sequential scans), it needs to f= ollow one > + replicate changes without performance degradation if performi= ng index > + scans. However, if the subscriber is affected due to replicat= ion lag or > + scan performance (e.g. due to sequential scans), it needs to = follow one > of the two previous strategies to distribute the workload on = the > subscriber. Your change clearly is an improvement (the original was grammatically wrong= ). But "subscriber nodes may replicate changes without performance degradation if performing index scans" still feels less than perfect. Shouldn't it be "when performing index scans" or "when they perform index scans" or - even better - "during index scans"? > See for details on > how to configure access control between the subscription and the > - publication instance. > + publisher instance. I think you should be consistent: "between the subscriber and the publisher instance". But perhaps it would be best to retain the original, because "publication" and "subscription" are the names of the PostgreSQL objects involved. How about "between the database with the subscription and the database with the publication"? =20 Yours, Laurenz Albe