Subject: Re: MacPorts xsltproc is very slow?
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: pgsql-docs@postgresql.org
References: 
 <CAEepm=2HZ+LkTSMtihu61wd63vpLwYE-cE41syf=1FHsO6gybg@mail.gmail.com>
 <6c7f286d-8803-3884-0638-10f513498464@gmail.com>
 <CAEepm=082retOdZbr5hbSs19oYyjMkAtM6Ez=KHa5JgG2Wm=sA@mail.gmail.com>
 <da76a68a-276d-0bdc-b4b9-32b0a3405c09@gmail.com>
 <CAEepm=35=a69q8wQk+KMzHtcY_1wd==stCcPjQKxdRGHDOGPdw@mail.gmail.com>
From: Alexander Lakhin <exclusion@gmail.com>
Message-ID: <5fab84ca-f57b-5f2c-0a6c-3e8c6ed938ff@gmail.com>
Date: Sat, 25 Nov 2017 11:21:23 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: 
 <CAEepm=35=a69q8wQk+KMzHtcY_1wd==stCcPjQKxdRGHDOGPdw@mail.gmail.com>
Content-Type: multipart/alternative;
 boundary="------------1503E21F605FB21FA1E73404"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------1503E21F605FB21FA1E73404
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit


25.11.2017 11:03, Thomas Munro wrote:
>
> Hmm.  Well, this is all new to me but I'd have expected the numbers in
> the "Calls" column to be entirely deterministic.
I think, calls are depending on the XSL templates and it seems we have 
different templates.
(I couldn't find 'd:appendix' in my docbook-xsl installation, that's why 
I asked about version number.)
Maybe it's another case then, your version is new.
Now I see 'd:appendix' appeared in
https://github.com/docbook/xslt10-stylesheets/blob/master/xsl/html/chunktoc.xsl

>    Perhaps that
> business about conditional use of UnwrapLinks and other things like it
> change the numbers.  It's interesting that "gentext.template" is in
> the same ballpark on our two systems in terms of calls and CPU time,
> but the top templates are massive outliers on my system.  I have no
> idea what I'm even looking at really but I couldn't help noticing that
> templates with match="chapter" and match="appendix" appear in our tree
> in sgml/stylesheet-speedup-common.xsl with a comment
> "Performance-optimized versions of some upstream templates from
> common/ directory".  Could it be that whatever performance-enhancing
> trick they perform doesn't work on 1.1.32, or alternatively they are
> not being reached so we're falling back to non-optimised versions
> instead of these?
>
>> I wonder, what version of docbook-xsl are you using?
>> (I have 1.79.1+dfsg-1).
>> Can you check with 1.79+ (if yours is older)?
> docbook-xsl version 1.79.2_1.
I'll try to install 1.79.2 version and check the performance on my side.

------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

--------------1503E21F605FB21FA1E73404
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <div class="moz-cite-prefix"><br>
      25.11.2017 11:03, Thomas Munro wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAEepm=35=a69q8wQk+KMzHtcY_1wd==stCcPjQKxdRGHDOGPdw@mail.gmail.com"><br>
      <pre wrap="">Hmm.  Well, this is all new to me but I'd have expected the numbers in
the "Calls" column to be entirely deterministic.</pre>
    </blockquote>
    I think, calls are depending on the XSL templates and it seems we
    have different templates.<br>
    (I couldn't find 'd:appendix' in my docbook-xsl installation, that's
    why I asked about version number.)<br>
    Maybe it's another case then, your version is new.<br>
    Now I see 'd:appendix' appeared in <br>
<a class="moz-txt-link-freetext" href="https://github.com/docbook/xslt10-stylesheets/blob/master/xsl/html/chunktoc.xsl">https://github.com/docbook/xslt10-stylesheets/blob/master/xsl/html/chunktoc.xsl</a><br>
    <br>
    <blockquote type="cite"
cite="mid:CAEepm=35=a69q8wQk+KMzHtcY_1wd==stCcPjQKxdRGHDOGPdw@mail.gmail.com">
      <pre wrap="">  Perhaps that
business about conditional use of UnwrapLinks and other things like it
change the numbers.  It's interesting that "gentext.template" is in
the same ballpark on our two systems in terms of calls and CPU time,
but the top templates are massive outliers on my system.  I have no
idea what I'm even looking at really but I couldn't help noticing that
templates with match="chapter" and match="appendix" appear in our tree
in sgml/stylesheet-speedup-common.xsl with a comment
"Performance-optimized versions of some upstream templates from
common/ directory".  Could it be that whatever performance-enhancing
trick they perform doesn't work on 1.1.32, or alternatively they are
not being reached so we're falling back to non-optimised versions
instead of these?

</pre>
      <blockquote type="cite">
        <pre wrap="">I wonder, what version of docbook-xsl are you using?
(I have 1.79.1+dfsg-1).
Can you check with 1.79+ (if yours is older)?
</pre>
      </blockquote>
      <pre wrap="">
docbook-xsl version 1.79.2_1.</pre>
    </blockquote>
    I'll try to install 1.79.2 version and check the performance on my
    side.<br>
    <br>
    <span><span><span>------<br>
          Alexander Lakhin<br>
          Postgres Professional: <a
class="m_-2943158502937334873m_7429097869847557916m_-2555318782090264170m_-2325832898607392541m_-6343938178230075984m_7799257996105097238m_-7296272573595711846moz-txt-link-freetext"
            href="http://www.postgrespro.com" target="_blank">http://www.postgrespro.com</a><br>
          The Russian Postgres Company<br>
        </span></span></span>
  </body>
</html>

--------------1503E21F605FB21FA1E73404--