Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rweUC-003Cym-FT for pgsql-docs@arkaria.postgresql.org; Tue, 16 Apr 2024 08:48:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rweUA-002JSe-Vu for pgsql-docs@arkaria.postgresql.org; Tue, 16 Apr 2024 08:48:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rweUA-002JSW-K5 for pgsql-docs@lists.postgresql.org; Tue, 16 Apr 2024 08:48:14 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rweU5-001Eck-Oa for pgsql-docs@lists.postgresql.org; Tue, 16 Apr 2024 08:48:14 +0000 Received: from [172.30.8.246] (unknown [172.30.8.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: a.voloshin@postgrespro.ru) by mail.postgrespro.ru (Postfix/587) with ESMTPSA id 3E72CE20E8F; Tue, 16 Apr 2024 11:48:08 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1713257288; bh=PnOmUHUyWhkUWJlovAvGq9T2cwQYyb87PHrNj/HsZVE=; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From: In-Reply-To:From; b=BPz+GNRphZg1yPAudsd+IE1MKutC+gDW1Io/BhNfsU5u9EHSroSAOSsRKuuStPR6P W1F8HL6Jz8TGoMSsVl7cHNkFJlS4wb4i8lZry2THzoSnbwOtYXma9PUweSFKQpMU8M vV69re/X/4NXGoOiuDZTDQwXnyaTVtKYsyYu64y0s/AoC7YyDTPHDSJkm/Z1as1t8x e0D7sR4On47RvQFVPNbnLYokwVD/mbJ4gqhFL6lwnw67jZFKzE1Tac2Dq5prjQ77pb b8Zg49jGbG828pfIpRaGt3k+sojME3tLRF1ZZwMJnkgZ0ywKWNGMaLUBSGnwP5xi4S pQs6f0d8mUUdA== Content-Type: multipart/mixed; boundary="------------K1pmOuxlOhciBz1DaYGuQh4X" Message-ID: <5fcda2fa-fb49-41f2-a5e5-c3100937b0a4@postgrespro.ru> Date: Tue, 16 Apr 2024 11:48:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: three small improvements for "Composite Types" page To: "David G. Johnston" Cc: pgsql-docs References: <38aa8e65-32e2-4578-bfc8-0d9f59efe049@postgrespro.ru> Content-Language: en-US From: Anton Voloshin In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------K1pmOuxlOhciBz1DaYGuQh4X Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/04/2024 23:44, David G. Johnston wrote: > I'd much prefer to leave "different kind" alone and turn the immediately > following, first-on-the-page, instance of CREATE TYPE into a link. Good, I'm fine with that too. >  2. make first mention of CREATE TABLE a link > [...] > I'm not all that convinced of that particular usefulness but also don't > see it hurting either. Thanks. I do think it's useful when one reads this page separately (not as a part of sequential read-through). > 3. Simplify CREATE TABLE example to make it self-sufficient > [...] > Agreed. Thanks. I've updated the patches correspondingly. -- Anton Voloshin Postgres Professional, The Russian Postgres Company https://postgrespro.ru --------------K1pmOuxlOhciBz1DaYGuQh4X Content-Type: text/x-patch; charset=UTF-8; name="0001-Composite-Types-clarify-different-kind-by-linking-to.patch" Content-Disposition: attachment; filename*0="0001-Composite-Types-clarify-different-kind-by-linking-to.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBkZGRmN2VlNGE5YTIyNTE1YzMyNzQzNGI3ZGIyYzAyOTMzMDFiMjU3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbiBWb2xvc2hpbiA8YS52b2xvc2hpbkBwb3N0 Z3Jlc3Byby5ydT4KRGF0ZTogRnJpLCAxMiBBcHIgMjAyNCAyMjo0OToxNyArMDMwMApTdWJq ZWN0OiBbUEFUQ0ggMS8zXSBDb21wb3NpdGUgVHlwZXM6IGNsYXJpZnkgImRpZmZlcmVudCBr aW5kIiBieSBsaW5raW5nIHRvIGEKICJjcmVhdGUgdHlwZSIgcGFnZQoKLS0tCiBkb2Mvc3Jj L3NnbWwvcm93dHlwZXMuc2dtbCB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlv bigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yb3d0eXBl cy5zZ21sIGIvZG9jL3NyYy9zZ21sL3Jvd3R5cGVzLnNnbWwKaW5kZXggYmJlYWM4NGQ0NmEu LjA0OWU5MGU5YzY4IDEwMDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwvcm93dHlwZXMuc2dtbAor KysgYi9kb2Mvc3JjL3NnbWwvcm93dHlwZXMuc2dtbApAQCAtNDAsNyArNDAsNyBAQCBDUkVB VEUgVFlQRSBpbnZlbnRvcnlfaXRlbSBBUyAoCiAgIGZpZWxkIG5hbWVzIGFuZCB0eXBlcyBj YW4gYmUgc3BlY2lmaWVkOyBubyBjb25zdHJhaW50cyAoc3VjaCBhcyA8bGl0ZXJhbD5OT1QK ICAgTlVMTDwvbGl0ZXJhbD4pIGNhbiBwcmVzZW50bHkgYmUgaW5jbHVkZWQuICBOb3RlIHRo YXQgdGhlIDxsaXRlcmFsPkFTPC9saXRlcmFsPiBrZXl3b3JkCiAgIGlzIGVzc2VudGlhbDsg d2l0aG91dCBpdCwgdGhlIHN5c3RlbSB3aWxsIHRoaW5rIGEgZGlmZmVyZW50IGtpbmQKLSAg b2YgPGNvbW1hbmQ+Q1JFQVRFIFRZUEU8L2NvbW1hbmQ+IGNvbW1hbmQgaXMgbWVhbnQsIGFu ZCB5b3Ugd2lsbCBnZXQgb2RkIHN5bnRheAorICBvZiA8eHJlZiBsaW5rZW5kPSJzcWwtY3Jl YXRldHlwZSIvPiBjb21tYW5kIGlzIG1lYW50LCBhbmQgeW91IHdpbGwgZ2V0IG9kZCBzeW50 YXgKICAgZXJyb3JzLgogIDwvcGFyYT4KIAotLSAKMi40My4yCgo= --------------K1pmOuxlOhciBz1DaYGuQh4X Content-Type: text/x-patch; charset=UTF-8; name="0002-Composite-Types-make-first-mention-of-CREATE-TABLE-a.patch" Content-Disposition: attachment; filename*0="0002-Composite-Types-make-first-mention-of-CREATE-TABLE-a.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBkZWYzZjdjY2I1NWI0NGU2M2IyYTlmZmZhODhiYTRkM2M1NDVlNTUzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbiBWb2xvc2hpbiA8YS52b2xvc2hpbkBwb3N0 Z3Jlc3Byby5ydT4KRGF0ZTogRnJpLCAxMiBBcHIgMjAyNCAyMjo1NjoxOCArMDMwMApTdWJq ZWN0OiBbUEFUQ0ggMi8zXSBDb21wb3NpdGUgVHlwZXM6IG1ha2UgZmlyc3QgbWVudGlvbiBv ZiBDUkVBVEUgVEFCTEUgYQogbGluawoKLS0tCiBkb2Mvc3JjL3NnbWwvcm93dHlwZXMuc2dt bCB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigt KQoKZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yb3d0eXBlcy5zZ21sIGIvZG9jL3NyYy9z Z21sL3Jvd3R5cGVzLnNnbWwKaW5kZXggMDQ5ZTkwZTljNjguLmE0MDliMjkyNzk1IDEwMDY0 NAotLS0gYS9kb2Mvc3JjL3NnbWwvcm93dHlwZXMuc2dtbAorKysgYi9kb2Mvc3JjL3NnbWwv cm93dHlwZXMuc2dtbApAQCAtMzYsNyArMzYsNyBAQCBDUkVBVEUgVFlQRSBpbnZlbnRvcnlf aXRlbSBBUyAoCiAgICAgcHJpY2UgICAgICAgICAgIG51bWVyaWMKICk7CiA8L3Byb2dyYW1s aXN0aW5nPgotICBUaGUgc3ludGF4IGlzIGNvbXBhcmFibGUgdG8gPGNvbW1hbmQ+Q1JFQVRF IFRBQkxFPC9jb21tYW5kPiwgZXhjZXB0IHRoYXQgb25seQorICBUaGUgc3ludGF4IGlzIGNv bXBhcmFibGUgdG8gPHhyZWYgbGlua2VuZD0ic3FsLWNyZWF0ZXRhYmxlIi8+LCBleGNlcHQg dGhhdCBvbmx5CiAgIGZpZWxkIG5hbWVzIGFuZCB0eXBlcyBjYW4gYmUgc3BlY2lmaWVkOyBu byBjb25zdHJhaW50cyAoc3VjaCBhcyA8bGl0ZXJhbD5OT1QKICAgTlVMTDwvbGl0ZXJhbD4p IGNhbiBwcmVzZW50bHkgYmUgaW5jbHVkZWQuICBOb3RlIHRoYXQgdGhlIDxsaXRlcmFsPkFT PC9saXRlcmFsPiBrZXl3b3JkCiAgIGlzIGVzc2VudGlhbDsgd2l0aG91dCBpdCwgdGhlIHN5 c3RlbSB3aWxsIHRoaW5rIGEgZGlmZmVyZW50IGtpbmQKLS0gCjIuNDMuMgoK --------------K1pmOuxlOhciBz1DaYGuQh4X Content-Type: text/x-patch; charset=UTF-8; name="0003-Composite-Types-simplify-CREATE-TABLE-example-to-mak.patch" Content-Disposition: attachment; filename*0="0003-Composite-Types-simplify-CREATE-TABLE-example-to-mak.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBiYmRhNmEyMGEzODdjZDZiMTM3OWI3NjBkZTBlMjE1ODUxZTYzOGE5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbiBWb2xvc2hpbiA8YS52b2xvc2hpbkBwb3N0 Z3Jlc3Byby5ydT4KRGF0ZTogRnJpLCAxMiBBcHIgMjAyNCAyMjo1ODo0NSArMDMwMApTdWJq ZWN0OiBbUEFUQ0ggMy8zXSBDb21wb3NpdGUgVHlwZXM6IHNpbXBsaWZ5IENSRUFURSBUQUJM RSBleGFtcGxlIHRvIG1ha2UgaXQKIHNlbGYtc3VmZmljaWVudAoKLS0tCiBkb2Mvc3JjL3Nn bWwvcm93dHlwZXMuc2dtbCB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yb3d0eXBlcy5z Z21sIGIvZG9jL3NyYy9zZ21sL3Jvd3R5cGVzLnNnbWwKaW5kZXggYTQwOWIyOTI3OTUuLmI2 MDYzYjMwYzMxIDEwMDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwvcm93dHlwZXMuc2dtbAorKysg Yi9kb2Mvc3JjL3NnbWwvcm93dHlwZXMuc2dtbApAQCAtNzQsNyArNzQsNyBAQCBTRUxFQ1Qg cHJpY2VfZXh0ZW5zaW9uKGl0ZW0sIDEwKSBGUk9NIG9uX2hhbmQ7CiA8cHJvZ3JhbWxpc3Rp bmc+CiBDUkVBVEUgVEFCTEUgaW52ZW50b3J5X2l0ZW0gKAogICAgIG5hbWUgICAgICAgICAg ICB0ZXh0LAotICAgIHN1cHBsaWVyX2lkICAgICBpbnRlZ2VyIFJFRkVSRU5DRVMgc3VwcGxp ZXJzLAorICAgIHN1cHBsaWVyX2lkICAgICBpbnRlZ2VyLAogICAgIHByaWNlICAgICAgICAg ICBudW1lcmljIENIRUNLIChwcmljZSAmZ3Q7IDApCiApOwogPC9wcm9ncmFtbGlzdGluZz4K LS0gCjIuNDMuMgoK --------------K1pmOuxlOhciBz1DaYGuQh4X--