Received: from localhost (unknown [200.46.204.183])
	by mail.postgresql.org (Postfix) with ESMTP id 9499163234C
	for <pgsql-bugs-postgresql.org@mail.postgresql.org>;
	Thu, 15 Jan 2009 12:15:56 -0400 (AST)
Received: from mail.postgresql.org ([200.46.204.86])
	by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024)
	with ESMTP id 36865-02 for
	<pgsql-bugs-postgresql.org@mail.postgresql.org>;
	Thu, 15 Jan 2009 12:15:51 -0400 (AST)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130])
	by mail.postgresql.org (Postfix) with ESMTP id 7D9BC632353
	for <pgsql-bugs@postgresql.org>; Thu, 15 Jan 2009 12:15:51 -0400 (AST)
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id n0FGFfVT006719;
	Thu, 15 Jan 2009 11:15:41 -0500 (EST)
To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
cc: Fujii Masao <masao.fujii@gmail.com>, Bruce Momjian <bruce@momjian.us>,
	Randy Isbell <jisbell@cisco.com>, pgsql-bugs@postgresql.org
Subject: Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION 
In-reply-to: <496F5502.4020907@enterprisedb.com> 
References: <200901150150.n0F1oV113850@momjian.us>
	<496F2795.70105@enterprisedb.com>
	<3f0b79eb0901150615g133f845erc39faf19793d5977@mail.gmail.com>
	<496F5502.4020907@enterprisedb.com>
Comments: In-reply-to Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
	message dated "Thu, 15 Jan 2009 17:23:46 +0200"
Date: Thu, 15 Jan 2009 11:15:41 -0500
Message-ID: <6718.1232036141@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none
X-Spam-Level: 
X-Archive-Number: 200901/96
X-Sequence-Number: 22078

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> Fujii Masao wrote:
>> Only a part of backup
>> history file (the file name including stop wal location) is changed.
>> Currently, the file name is wrong if stop wal location indicates a boundary
>> byte. This would confuse the user, I think.

> Should we change it in HEAD? I'm leaning towards no, on the grounds that 
> tools/people would then have to know the version it's dealing with to 
> interpret the value correctly, and because pg_stop_backup() now waits 
> for the last xlog file to be archived before returning, there's little 
> need to look at that file.

I agree.  It might have been better to define it the other way
originally, but the risks of changing it now outweigh any likely
benefit.

			regards, tom lane