Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: Curt Kolovson <ckolovson@gmail.com>
Mime-Version: 1.0 (1.0)
Subject: Re: Bug in documentation:
 https://www.postgresql.org/docs/current/spi-examples.html
Date: Mon, 17 Jul 2023 18:52:34 -0700
Message-Id: <672A5662-FB6C-454B-AD82-BDC30474E47C@gmail.com>
References: <4114624.1689643322@sss.pgh.pa.us>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
 pgsql-docs@lists.postgresql.org
In-Reply-To: <4114624.1689643322@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/672A5662-FB6C-454B-AD82-BDC30474E47C%40gmail.com>
Precedence: bulk

Tom is correct. It appears that nobody tested this example, which by the way=
 seems unnecessarily complicated.=20

Sent from my iPhone

> On Jul 17, 2023, at 6:22 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> =EF=BB=BF"David G. Johnston" <david.g.johnston@gmail.com> writes:
>>> On Mon, Jul 17, 2023 at 4:53=E2=80=AFPM Curt Kolovson <ckolovson@gmail.c=
om> wrote:
>>> The actual results (shown below) are different than shown on this doc
>>> page.
>=20
>> SPI_exec sees "INSERT 0 2" as the command tag from the SQL command you
>> passed and so 2 is the output of the execq function call.
>> No INFO messages appear because you did not include a returning clause.
>> The 1 you passed to the call is immaterial if the query you supply doesn'=
t
>> produce a result set.
>=20
> I think his point is that this example does not behave as the
> documentation claims.  Which it does not, according to my
> tests here.  I find this a bit disturbing --- did we intentionally
> change the behavior of SPI_exec somewhere along the line?
>=20
>            regards, tom lane