From: Daniel Gustafsson <daniel@yesql.se>
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_BDBB21ED-B6AC-4C55-A6B8-588206CF56FB"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: Missing File weather.txt
Date: Tue, 28 Jan 2020 11:18:02 +0100
References: <158017814191.19852.15019251381150731439@wrigleys.postgresql.org>
To: davidhowes@gmail.com,
 pgsql-docs@lists.postgresql.org
In-Reply-To: <158017814191.19852.15019251381150731439@wrigleys.postgresql.org>
Message-Id: <68FE7D96-3F05-40E3-B3A2-04CE267CF28A@yesql.se>
Precedence: bulk


--Apple-Mail=_BDBB21ED-B6AC-4C55-A6B8-588206CF56FB
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

> On 28 Jan 2020, at 03:22, PG Doc comments form =
<noreply@postgresql.org> wrote:
>=20
> The following documentation comment has been logged on the website:
>=20
> Page: https://www.postgresql.org/docs/12/tutorial-populate.html
> Description:
>=20
> On this page https://www.postgresql.org/docs/12/tutorial-populate.html =
you
> have this command:
>=20
> COPY weather FROM '/home/user/weather.txt';
>=20
> I've searched all over for weather.txt and can't find it. Please could =
you
> make this and any other files required for the tutorial available and
> provide clear instructions for accessing them at the beginning of the
> tutorial.

This is only mentioned as an example of another input method, with a =
link to
the COPY page for more information.  That being said, it's a good thing =
for a
tutorial to be self-contained, and going from a basic tutorial to the =
COPY
reference page is a fairly large step.  I propose that we add a small =
example
on what weather.txt could look like as per the attached diff.

cheers ./daniel


--Apple-Mail=_BDBB21ED-B6AC-4C55-A6B8-588206CF56FB
Content-Disposition: attachment;
	filename=tutorial_weather.diff
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="tutorial_weather.diff"
Content-Transfer-Encoding: 7bit

diff --git a/doc/src/sgml/query.sgml b/doc/src/sgml/query.sgml
index c0889743c4..9608541915 100644
--- a/doc/src/sgml/query.sgml
+++ b/doc/src/sgml/query.sgml
@@ -266,8 +266,16 @@ COPY weather FROM '/home/user/weather.txt';
 
     where the file name for the source file must be available on the
     machine running the backend process, not the client, since the backend process
-    reads the file directly.  You can read more about the
-    <command>COPY</command> command in <xref linkend="sql-copy"/>.
+    reads the file directly.  An example input file is shown below, note that
+    the white space on each line is actually a tab character.
+
+<programlisting>
+San Francisco    46    50    0.25    1994-11-27
+Hayward    37    54    0.0    1994-11-29
+</programlisting>
+
+    You can read more about the <command>COPY</command> command in
+    <xref linkend="sql-copy"/>.
    </para>
   </sect1>
 

--Apple-Mail=_BDBB21ED-B6AC-4C55-A6B8-588206CF56FB--