Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\))
Subject: Re: Broken link
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <202402061046.xemsplfjzblt@alvherre.pgsql>
Date: Tue, 6 Feb 2024 11:56:34 +0100
Cc: codyrank@gmail.com,
 pgsql-docs <pgsql-docs@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <6B2D6249-1395-4529-BD89-0BCDDA9A2DCF@yesql.se>
References: <202402061046.xemsplfjzblt@alvherre.pgsql>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Archived-At: 
 <https://www.postgresql.org/message-id/6B2D6249-1395-4529-BD89-0BCDDA9A2DCF%40yesql.se>
Precedence: bulk

> On 6 Feb 2024, at 11:46, Alvaro Herrera <alvherre@alvh.no-ip.org> =
wrote:
>=20
> On 2024-Feb-06, Daniel Gustafsson wrote:
>=20
>>> On 5 Feb 2024, at 22:23, PG Doc comments form =
<noreply@postgresql.org> wrote:
>>=20
>>> This page has a link that says "See the release notes for PostgreSQL =
12 for
>>> details on this change."
>>> https://www.postgresql.org/docs/current/recovery-config.html
>>>=20
>>> The link does not go to the release notes though.
>>=20
>> While not directly to the v12 release notes, it leads to a page where =
the
>> release notes are linked from which seems good enough here.  This is =
a note on
>> a change that happened in the oldest still supported version, with =
the previous
>> behavior EOL.
>=20
> The release notes for 12.0 [1] say less than the recovery-config.html
> page says about the matter.  I think a good fix for this complaint is =
to
> remove the whole phrase "See ... for details on this change".
>=20
> [1] https://www.postgresql.org/docs/release/12.0/

I'm guessing it's the below entry which is referred to, which I agree =
isn't
likely to be all that helpful to any reader, more reading is required.

* Move recovery.conf settings into postgresql.conf (Masao Fujii, Simon =
Riggs,
Abhijit Menon-Sen, Sergei Kornilov)

recovery.conf is no longer used, and the server will not start if that =
file
exists.  recovery.signal and standby.signal files are now used to switch =
into
non-primary mode.  The trigger_file setting has been renamed to
promote_trigger_file.  The standby_mode setting has been removed.

That being said, all the obsolote appendix pages share that very link
structure, so I'm not sure if removing one of them is helpful.  Maybe =
removing
all of them and instead expanding appendix-obsolete.sgml with an =
explanation of
where to find more information is better?

--
Daniel Gustafsson