Subject: Re: The order of columns about WAL activity in pg_stat_statements
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-docs@postgresql.org
References: <a6e68c83-0923-afe7-c1f2-5c5843a21687@oss.nttdata.com>
 <2961.1589384501@sss.pgh.pa.us>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <6a2cca46-d3c0-265a-9c63-7814e4b3549b@oss.nttdata.com>
Date: Thu, 14 May 2020 01:12:21 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <2961.1589384501@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2020/05/14 0:41, Tom Lane wrote:
> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>> In pg_stat_statements docs, the columns about WAL activity are put
>> in the table in the order of wal_bytes, wal_records and wal_fpi. But
>> in the definition of pg_stat_statements view, wal_bytes is put last.
>> So I think that it's better to reorder those columns in a consistent
>> with the view definition. Patch attached. Thought?
> 
> I already fixed this in my pending patch to restructure the catalog
> docs [1].

Sounds nice. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION