Message-ID: <6c993738c0054bedb9622da0d6789a8d12955cb2.camel@cybertec.at>
Subject: Re: Role membership and DROP
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org, pgsql-docs@lists.postgresql.org
Date: Mon, 18 Nov 2019 15:40:51 +0100
In-Reply-To: <10546.1573843266@sss.pgh.pa.us>
References: <504497aca66bf34bdcdd90bd0bcebdc3a33f577b.camel@cybertec.at>
	 <6808.1573683426@sss.pgh.pa.us>
	 <c1b3ed843b5002d56c04885b7ce7d0eea08c22c9.camel@cybertec.at>
	 <10546.1573843266@sss.pgh.pa.us>
Content-Type: multipart/mixed; boundary="=-1dpqbDLyMxPVRXu7KT+0"
User-Agent: Evolution 3.32.4 (3.32.4-1.fc30) 
MIME-Version: 1.0
Precedence: bulk


--=-1dpqbDLyMxPVRXu7KT+0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On Fri, 2019-11-15 at 13:41 -0500, Tom Lane wrote:
> Laurenz Albe <laurenz.albe@cybertec.at> writes:
> > On Wed, 2019-11-13 at 17:17 -0500, Tom Lane wrote:
> > > It might be worth clarifying this point in section 5.7,
> > > https://www.postgresql.org/docs/devel/ddl-priv.html
> > > but let's not duplicate that in every ref/ page.
> > I have attached a proposed patch.
> 
>    <para>
>     The right to modify or destroy an object is always the privilege of
> -   the owner only.
> +   the owner.  Like all privileges, that right can be inherited by members of
> +   the owning role.
>    </para>
> 
> Hm.  This is more or less contradicting the original meaning of the
> existing sentence, so maybe we need to rewrite a bit more.  What do
> you think of
> 
>     The right to modify or destroy an object is inherent in being the
>     object's owner.  Like all privileges, that right can be inherited by
>     members of the owning role; but there is no way to grant or revoke
>     it more selectively.
> 
> A larger problem (pre-existing, since there's a reference to being a
> member of the owning role just a bit further down) is that I don't think
> we've defined role membership at this point, so the reader is quite
> entitled to come away more confused than they were before.  It might not
> be advisable to try to cover role membership here, but we should at
> least add a cross-reference to where it's explained.

I think you are right about the potential confusion; I have added a
cross-reference.  That cross-reference is hopefully still in short-term
memory when the reader proceeds to the second reference to role membership
a few sentences later.

I like your second sentence, but I think that "the right ... is inherent
in being the ... owner" is unnecessarily complicated.
Removing the "always" and "only" makes the apparent contradiction between
the sentences less jarring to me.

I won't fight about words though.  Attached is my second attempt.

Yours,
Laurenz Albe

--=-1dpqbDLyMxPVRXu7KT+0
Content-Disposition: attachment;
	filename*0=0001-Document-that-the-right-to-ALTER-or-DROP-is-hereditary.V;
	filename*1=2.patch
Content-Transfer-Encoding: base64
Content-Type: text/x-patch;
	name*0=0001-Document-that-the-right-to-ALTER-or-DROP-is-hereditary.V2.pa;
	name*1=tch; charset="UTF-8"

RnJvbSAyZTNhYmFhYTNiMGE1ZGViMDA2ZDIyMTBjM2U2NmY1YjM1NzFiZmQyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h
dD4KRGF0ZTogTW9uLCAxOCBOb3YgMjAxOSAxNToyMzoxMCArMDEwMApTdWJqZWN0OiBbUEFUQ0hd
IERvY3VtZW50IHRoYXQgdGhlIHJpZ2h0IHRvIEFMVEVSIG9yIERST1AgaXMgaGVyZWRpdGFyeQoK
RGlzY3Vzc2lvbjogaHR0cHM6Ly9wb3N0Z3IuZXMvbS81MDQ0OTdhY2E2NmJmMzRiZGNkZDkwYmQw
YmNlYmRjM2EzM2Y1NzdiLmNhbWVsQGN5YmVydGVjLmF0Ci0tLQogZG9jL3NyYy9zZ21sL2RkbC5z
Z21sIHwgNiArKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDIgZGVsZXRp
b25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL2RkbC5zZ21sIGIvZG9jL3NyYy9zZ21s
L2RkbC5zZ21sCmluZGV4IDlkNmVjMmM3MzguLjAzMGM4OTZmODIgMTAwNjQ0Ci0tLSBhL2RvYy9z
cmMvc2dtbC9kZGwuc2dtbAorKysgYi9kb2Mvc3JjL3NnbWwvZGRsLnNnbWwKQEAgLTE1NzgsOCAr
MTU3OCwxMCBAQCBBTFRFUiBUQUJMRSBwcm9kdWN0cyBSRU5BTUUgVE8gaXRlbXM7CiAgIDwvcGFy
YT4KIAogICA8cGFyYT4KLSAgIFRoZSByaWdodCB0byBtb2RpZnkgb3IgZGVzdHJveSBhbiBvYmpl
Y3QgaXMgYWx3YXlzIHRoZSBwcml2aWxlZ2Ugb2YKLSAgIHRoZSBvd25lciBvbmx5LgorICAgVGhl
IHJpZ2h0IHRvIG1vZGlmeSBvciBkZXN0cm95IGFuIG9iamVjdCBpcyB0aGUgcHJpdmlsZWdlIG9m
IHRoZSBvd25lci4KKyAgIExpa2UgYWxsIHByaXZpbGVnZXMsIHRoYXQgcmlnaHQgY2FuIGJlIGlu
aGVyaXRlZCBieSBtZW1iZXJzIG9mIHRoZSBvd25pbmcgcm9sZSwKKyAgIGJ1dCB0aGVyZSBpcyBu
byB3YXkgdG8gZ3JhbnQgb3IgcmV2b2tlIGl0IG1vcmUgc2VsZWN0aXZlbHkuCisgICBTZWUgPHhy
ZWYgbGlua2VuZD0icm9sZS1tZW1iZXJzaGlwIi8+IGZvciBtb3JlIGFib3V0IHJvbGUgbWVtYmVy
c2hpcC4KICAgPC9wYXJhPgogCiAgIDxwYXJhPgotLSAKMi4yMS4wCgo=


--=-1dpqbDLyMxPVRXu7KT+0--