Feedback-ID: ie0a040ee:Fastmail
Message-ID: <6de77026-b34f-4f32-a0f3-2dc345c4b1bf@eisentraut.org>
Date: Thu, 30 Oct 2025 11:15:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Documentation improvement patch
To: Oleg <o.sibiryakov@postgrespro.ru>, Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-docs@lists.postgresql.org
References: <e62bedb5-c26f-4d37-b4ed-ce9b55f1e980@postgrespro.ru>
 <3881A97B-0146-4389-9C39-3C596536750B@yesql.se>
 <b9ff5247-04a0-4fe5-9e2f-454b0c7bde7f@postgrespro.ru>
 <84E4E3E6-D702-4604-AE0B-AF92B80B3833@yesql.se>
 <284a26c6-0a38-47ab-bd73-e28943029046@postgrespro.ru>
Content-Language: de-DE, en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <284a26c6-0a38-47ab-bd73-e28943029046@postgrespro.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/6de77026-b34f-4f32-a0f3-2dc345c4b1bf%40eisentraut.org>
Precedence: bulk

On 25.10.25 21:01, Oleg wrote:
> Dear Daniel,
> 
> Thank you for your prompt feedback.
> 
> Attached, please find the updated documentation patch, which 
> incorporates your suggestions from both the first and second rounds of 
> review.

       <term><literal>ALTER_REPLICATION_SLOT</literal> <replaceable 
class="parameter">slot_name</replaceable> ( <replaceable 
class="parameter">option</replaceable> [, ...] )
        <indexterm><primary>ALTER_REPLICATION_SLOT</primary></indexterm>
       </term>
       <listitem>
        <para>
-       Change the definition of a replication slot.
+       Changes the definition of a replication slot.

I think these are intentionally written in imperative style.  Compare 
the synopses of the main SQL commands: "change the definition of a 
domain" etc.

-     First, define a <literal>PgStat_KindInfo</literal> that includes all
+     First, define <literal>PgStat_KindInfo</literal> that includes all

I think this change is incorrect.  You are being asked to define an 
instance of PgStat_KindInfo, not PgStat_KindInfo itself (which already 
exists).

The remaining changes look ok to me.