MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="=_35fd66266b707da3f9ab4c9e65b7f8d4"
Content-Transfer-Encoding: 8bit
Date: Wed, 13 May 2020 17:17:43 +0300
From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: daniel@yesql.se
Cc: a.lakhin@postgrespro.ru, pgsql-docs@postgresql.org
Subject: Re: Missing comma?
In-Reply-To: <5B3957FE-D31E-4838-B35C-C2F0EEC3E557@yesql.se>
References: <ad1a0badc32658b1bbb07aa312346a1d@postgrespro.ru>
 <5B3957FE-D31E-4838-B35C-C2F0EEC3E557@yesql.se>
User-Agent: Roundcube Webmail/1.4.0
Message-ID: <6fa8ba75057b16f88010c2b945f720c0@postgrespro.ru>
Organization: Postgres Professional
Precedence: bulk

--=_35fd66266b707da3f9ab4c9e65b7f8d4
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=UTF-8;
 format=flowed

Thanks!

P.S. Looking at the final sentence:

"Columns used to form “replica identity” for rows: d = default (primary 
key, if any), n = nothing, f = all columns, i = index with 
indisreplident set, or default"

in my opinion it's a little unclear what "or default" means at the end, 
because the comma is used to separate enumeration elements ("d = default 
<...>, n = nothing, f = all columns, i = index <...>") and inside the 
element description ("i = index with indisreplident set, or default"). 
Therefore here is an additional patch from me to clarify this place, 
thanks to Alexander Lakhin for help.

On 2020-05-13 16:23, Daniel Gustafsson wrote:
>> On 13 May 2020, at 12:20, Marina Polyakova 
>> <m.polyakova@postgrespro.ru> wrote:
> 
>> https://www.postgresql.org/docs/current/catalog-pg-class.html says 
>> "Columns used to form “replica identity” for rows: d = default 
>> (primary key, if any), n = nothing, f = all columns i = index with 
>> indisreplident set, or default". Am I wrong, or is there a missing 
>> comma (or other punctuation mark) before "i = index"?..
> 
> I agree with this, there should be a comma between "f = all columns" 
> and "i =
> index with.." per the below:
> 
> diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
> index ce33df9e58..cbd76e1bf5 100644
> --- a/doc/src/sgml/catalogs.sgml
> +++ b/doc/src/sgml/catalogs.sgml
> @@ -1935,7 +1935,7 @@ SCRAM-SHA-256$<replaceable>&lt;iteration
> count&gt;</replaceable>:<replaceable>&l
>         Columns used to form <quote>replica identity</quote> for rows:
>         <literal>d</literal> = default (primary key, if any),
>         <literal>n</literal> = nothing,
> -       <literal>f</literal> = all columns
> +       <literal>f</literal> = all columns,
>         <literal>i</literal> = index with
> <structfield>indisreplident</structfield> set, or default
>        </entry>
>       </row>
> 
> cheers ./daniel

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--=_35fd66266b707da3f9ab4c9e65b7f8d4
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=diff_relreplident_index_desc.patch
Content-Disposition: attachment;
 filename=diff_relreplident_index_desc.patch;
 size=708

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9jYXRhbG9ncy5zZ21sIGIvZG9jL3NyYy9zZ21sL2Nh
dGFsb2dzLnNnbWwKaW5kZXggMDJkZGViYWU5OWQ5ODExMGE4ZGQyOTBkZDRjYjBjOTgwYWRmNzk4
NC4uMDM0YTA4ZjgwZWE0MjY5ZjEzMWU3ZTEzODNiYTQ4MmZkNzZkOTM0NCAxMDA2NDQKLS0tIGEv
ZG9jL3NyYy9zZ21sL2NhdGFsb2dzLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL2NhdGFsb2dzLnNn
bWwKQEAgLTE5MzYsNyArMTkzNiw3IEBAIFNDUkFNLVNIQS0yNTYkPHJlcGxhY2VhYmxlPiZsdDtp
dGVyYXRpb24gY291bnQmZ3Q7PC9yZXBsYWNlYWJsZT46PHJlcGxhY2VhYmxlPiZsCiAgICAgICAg
PGxpdGVyYWw+ZDwvbGl0ZXJhbD4gPSBkZWZhdWx0IChwcmltYXJ5IGtleSwgaWYgYW55KSwKICAg
ICAgICA8bGl0ZXJhbD5uPC9saXRlcmFsPiA9IG5vdGhpbmcsCiAgICAgICAgPGxpdGVyYWw+Zjwv
bGl0ZXJhbD4gPSBhbGwgY29sdW1ucywKLSAgICAgICA8bGl0ZXJhbD5pPC9saXRlcmFsPiA9IGlu
ZGV4IHdpdGggPHN0cnVjdGZpZWxkPmluZGlzcmVwbGlkZW50PC9zdHJ1Y3RmaWVsZD4gc2V0LCBv
ciBkZWZhdWx0CisgICAgICAgPGxpdGVyYWw+aTwvbGl0ZXJhbD4gPSBpbmRleCB3aXRoIDxzdHJ1
Y3RmaWVsZD5pbmRpc3JlcGxpZGVudDwvc3RydWN0ZmllbGQ+IHNldCAoaWYgYW55KQogICAgICAg
PC9lbnRyeT4KICAgICAgPC9yb3c+CiAK
--=_35fd66266b707da3f9ab4c9e65b7f8d4--