Subject: Re: pg_monitor role description
To: Julien Rouhaud <rjuju123@gmail.com>, Michael Paquier <michael@paquier.xyz>
Cc: pluzanov@postgrespro.ru, pgsql-docs@lists.postgresql.org
References: <162149110071.26171.15811576640435665698@wrigleys.postgresql.org>
 <YKYJDXxnQ4hcUVYd@paquier.xyz>
 <CAOBaU_Y3b1Vet2UPDwjyi-pVv1wxT8fH4Fe4UKEZbZi6C-SGWQ@mail.gmail.com>
From: Pavel Luzanov <p.luzanov@postgrespro.ru>
Message-ID: <7018bb3a-26f1-a9be-1659-3bdafd122669@postgrespro.ru>
Date: Thu, 20 May 2021 15:44:52 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: 
 <CAOBaU_Y3b1Vet2UPDwjyi-pVv1wxT8fH4Fe4UKEZbZi6C-SGWQ@mail.gmail.com>
Content-Type: multipart/alternative;
 boundary="------------10CE3BC877A9A279575AC8F9"
Content-Language: en-US
Archived-At: 
 <https://www.postgresql.org/message-id/7018bb3a-26f1-a9be-1659-3bdafd122669%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------10CE3BC877A9A279575AC8F9
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

On 20.05.2021 11:54, Julien Rouhaud wrote:

> On Thu, May 20, 2021 at 3:01 PM Michael Paquier <michael@paquier.xyz> wrote:
>> On Thu, May 20, 2021 at 06:11:40AM +0000, PG Doc comments form wrote:
>>> "This role is a member of pg_read_all_settings, pg_read_all_stats and
>>> pg_stat_scan_tables."
>>> Is it correct sentence?
>>> It seems for me that pg_read_all_stats is a member of pg_monitor. But not
>>> vice versa.
>> Here is what I am getting:
>> =# \dgS pg_monitor
>>                                        List of roles
>>   Role name  |  Attributes  |                         Member of
>> ------------+--------------+--------------------------------------------------------------
>>   pg_monitor | Cannot login | {pg_read_all_settings,pg_read_all_stats,pg_stat_scan_tables}
>>
>> =# \dgS pg_read_all_data
>>                  List of roles
>>
>>      Role name     |  Attributes  | Member of
>> ------------------+--------------+-----------
>>   pg_read_all_data | Cannot login | {}
>>
>> So the docs look correct to me.
> Indeed.  In other words pg_monitor is the sum of the authorizations
> given by all those roles.

Let me try one more time.
What is correct from the English language point of view:

1. Julien Rouhaud is a member of PostgreSQL Community.

or

2. PostgreSQL Community is a member of Julien Rouhaud, Michael Paquier.

Or both forms are correct?

I think that 1 is correct. And column header in a \du output must be something like 'members' instead of 'member of'.

-- 
Pavel Luzanov
Postgres Professional: https://postgrespro.com
The Russian Postgres Company


--------------10CE3BC877A9A279575AC8F9
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <pre>
</pre>
    <div class="moz-cite-prefix">
      <pre>On 20.05.2021 11:54, Julien Rouhaud wrote:</pre>
    </div>
    <blockquote type="cite"
cite="mid:CAOBaU_Y3b1Vet2UPDwjyi-pVv1wxT8fH4Fe4UKEZbZi6C-SGWQ@mail.gmail.com">
      <pre class="moz-quote-pre" wrap="">On Thu, May 20, 2021 at 3:01 PM Michael Paquier <a class="moz-txt-link-rfc2396E" href="mailto:michael@paquier.xyz">&lt;michael@paquier.xyz&gt;</a> wrote:
</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">
On Thu, May 20, 2021 at 06:11:40AM +0000, PG Doc comments form wrote:
</pre>
        <blockquote type="cite">
          <pre class="moz-quote-pre" wrap="">"This role is a member of pg_read_all_settings, pg_read_all_stats and
pg_stat_scan_tables."
Is it correct sentence?
It seems for me that pg_read_all_stats is a member of pg_monitor. But not
vice versa.
</pre>
        </blockquote>
        <pre class="moz-quote-pre" wrap="">
Here is what I am getting:
=# \dgS pg_monitor
                                      List of roles
 Role name  |  Attributes  |                         Member of
------------+--------------+--------------------------------------------------------------
 pg_monitor | Cannot login | {pg_read_all_settings,pg_read_all_stats,pg_stat_scan_tables}

=# \dgS pg_read_all_data
                List of roles

    Role name     |  Attributes  | Member of
------------------+--------------+-----------
 pg_read_all_data | Cannot login | {}

So the docs look correct to me.
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
Indeed.  In other words pg_monitor is the sum of the authorizations
given by all those roles.</pre>
    </blockquote>
    <font face="monospace"></font>
    <pre>Let me try one more time.
What is correct from the English language point of view:

1. Julien Rouhaud is a member of PostgreSQL Community.

or 

2. PostgreSQL Community is a member of Julien Rouhaud, Michael Paquier.

Or both forms are correct? 

I think that 1 is correct. And column header in a \du output must be something like 'members' instead of 'member of'.
</pre>
    <pre class="moz-signature" cols="72">-- 
Pavel Luzanov
Postgres Professional: <a class="moz-txt-link-freetext" href="https://postgrespro.com">https://postgrespro.com</a>
The Russian Postgres Company</pre>
  </body>
</html>

--------------10CE3BC877A9A279575AC8F9--