From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Fiedler <david.fido.fiedler@gmail.com>
cc: pgsql-docs@lists.postgresql.org
Subject: Re: WHEN SQLSTATE '00000' THEN equals to WHEN OTHERS THEN
In-reply-to: 
 <CAHjN70-=H5EpTOuZVbC8mPvRS5EfZ4MY2=OUdVDWoyGvKhb+Rw@mail.gmail.com>
References: 
 <CAHjN70-=H5EpTOuZVbC8mPvRS5EfZ4MY2=OUdVDWoyGvKhb+Rw@mail.gmail.com>
Comments: In-reply-to David Fiedler <david.fido.fiedler@gmail.com>
	message dated "Wed, 19 Mar 2025 15:03:34 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <706648.1742398190.1@sss.pgh.pa.us>
Date: Wed, 19 Mar 2025 11:29:50 -0400
Message-ID: <706649.1742398190@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/706649.1742398190%40sss.pgh.pa.us>
Precedence: bulk

David Fiedler <david.fido.fiedler@gmail.com> writes:
> I've stumbled across a code that used this condition, resulting in
> unexpected behavior. I think it worths a note that catching 00000 is not
> possible and that it results in a catch all handler.

Hmph.  The code thinks

	 * OTHERS is represented as code 0 (which would map to '00000', but we
	 * have no need to represent that as an exception condition).

but it evidently didn't consider the possibility of a user writing
'00000'.  I'm more inclined to consider this a bug and change plpgsql
to use something else internally to represent OTHERS.  We could use
-1, which AFAICS cannot be generated by MAKE_SQLSTATE.

			regards, tom lane