Received: from maia.hub.org (maia-3.hub.org [200.46.204.243]) by mail.postgresql.org (Postfix) with ESMTP id 506BFB5DBEA for ; Wed, 7 Sep 2011 19:07:14 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.243]) (amavisd-maia, port 10024) with ESMTP id 91661-02 for ; Wed, 7 Sep 2011 22:07:08 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id E840DB5DBE8 for ; Wed, 7 Sep 2011 19:07:07 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id p87M734n007071; Wed, 7 Sep 2011 18:07:04 -0400 (EDT) To: Bruce Momjian cc: Susanne Ebrecht , Robert Haas , Grzegorz Szpetkowski , pgsql-docs@postgresql.org Subject: Re: createuser/dropuser username In-reply-to: <201109072148.p87LmaM23680@momjian.us> References: <201109072148.p87LmaM23680@momjian.us> Comments: In-reply-to Bruce Momjian message dated "Wed, 07 Sep 2011 17:48:36 -0400" Date: Wed, 07 Sep 2011 18:07:03 -0400 Message-ID: <7070.1315433223@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.404 tagged_above=-5 required=5 tests=BAYES_00=-1.9, RP_MATCHES_RCVD=-0.504 X-Spam-Level: X-Archive-Number: 201109/26 X-Sequence-Number: 6947 Bruce Momjian writes: > Uh, I did some digging after this email report and found it does need > some cleanup, which is done in the attached patch. > It removes quoting for table references in clusterdb and index/table > references in reindexdb, Uh, surely that breaks things. Or did you miss my statement that the current behavior is what is intended? > and adds a general documentation overview about > when case is preserved and suggests quoting, and adds documentation > where special quoting happens. I don't find the documentation changes to be improvements either. Possibly instead of > ! Specifies the default tablespace for the database (double-quoted internally). you could do something like Specifies the default tablespace for the database. (This name is not subject to case-folding.) > + > + When specified on the command line, user and databases names have > + their case preserved — the presence of spaces or special > + characters might require quoting. Table names and other identifiers > + do not have their case preserved, except where documented, and > + might require quoting. > + This latter sentence is just plain wrong. regards, tom lane